From patchwork Sat Jan 13 17:22:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 10162307 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1EBC1602A7 for ; Sat, 13 Jan 2018 17:22:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 050BB28B1E for ; Sat, 13 Jan 2018 17:22:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDDD628B20; Sat, 13 Jan 2018 17:22:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 13B2228B1F for ; Sat, 13 Jan 2018 17:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755231AbeAMRWN (ORCPT ); Sat, 13 Jan 2018 12:22:13 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:37839 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755102AbeAMRWM (ORCPT ); Sat, 13 Jan 2018 12:22:12 -0500 Received: by mail-lf0-f66.google.com with SMTP id f3so9082301lfe.4 for ; Sat, 13 Jan 2018 09:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:user-agent:date:to:cc:subject:mime-version :content-disposition; bh=qMgVjYP2C/7lKYw35U1qVty/JyvRAQF6LemTHIvpKWY=; b=YxHQnBiF7zXs9xjwJ0VVLykvj0aXsDX1fh+StZiEBqQbi3fpPkKXRENHHZQufwPMaz 6hpGN1Gajy0OYl3FDlYiueP8YlYs/ycXSdv7QrDd9XZbAeHhBN15P30ROSyScAXiU05g vReU06F/7hgO0DiQpjj/fqZufjFqVxsLayh3Wv67/BjxaiiZyWASG0vzwGLinRVFLMXT 66n3m6fRCRsunUH/kSnc2dEkYMiaVzaFZW8Prhn6WBqygGJIVHYYrevTwbyNLHtfnuey 9XYND7jZ7bHnTA0kqExifsyT6541poOLvurV1v4/55n8XgjRyCIXzlq4U8nvNho+deYP 5q6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:user-agent:date:to:cc:subject :mime-version:content-disposition; bh=qMgVjYP2C/7lKYw35U1qVty/JyvRAQF6LemTHIvpKWY=; b=S2OyGADnsZlPaEJ8PNypC1Ft10u0snTpo4zK91QuofTu8O+qxEQx35Rnz92JN16S2o ma7Uucj9w8sjtLoR70xkMpXuZb1UPgqLYkufOlc+CQ7YpuxGfh6vuotCMAIRD/qN+39B bME2WWVRjTxY+lYGpDQVttCFsaMD00/NeKWuJBNS2Hh6ugZr2YNZon/JsbKH6w/u42eV CMieqsz1LeZqEMpevb6Viqv/aawFKGj4/4hJTLX/6SAyZ4cifqfA97VSLTXo27cLxGwl uQGgsOiydzhdMD5btzJSaD9yOtJ3tQ9aYZaAwEiew5iKyRw0Pq4bo135smaybzwKHF58 yO7A== X-Gm-Message-State: AKwxytdwyjPZpvN5BVqui3TtM81EGTdryG40AX7U4K0zSIdI6xzWZb4g MpQOVdI6kKr2fWEze97/WUpTig== X-Google-Smtp-Source: ACJfBou63GknW2/iebNtYyOfS7ekypYHCJS7cIn5PwkbMxmazaZyW3IRYxb3MHl9Pb22WnIKqy+LVQ== X-Received: by 10.46.101.150 with SMTP id e22mr1271037ljf.97.1515864131188; Sat, 13 Jan 2018 09:22:11 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.80.40]) by smtp.gmail.com with ESMTPSA id 74sm1239577ljx.58.2018.01.13.09.22.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Jan 2018 09:22:09 -0800 (PST) From: Sergei Shtylyov X-Google-Original-From: "Sergei Shtylyov" Received: by wasted.cogentembedded.com (sSMTP sendmail emulation); Sat, 13 Jan 2018 20:22:07 +0300 Message-Id: <20180113172207.201026516@cogentembedded.com> User-Agent: quilt/0.64 Date: Sat, 13 Jan 2018 20:22:01 +0300 To: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: linux-sh@vger.kernel.org, Sergei Shtylyov Subject: [PATCH] sh_eth: dix dumping ARSTR MIME-Version: 1.0 Content-Disposition: inline; filename=sh_eth-fix-dumping-ARSTR.patch Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ARSTR is always located at the start of the TSU register region, thus using add_reg() instead of add_tsu_reg() in __sh_eth_get_regs() to dump it causes EDMR or EDSR (depending on the register layout) to be dumped instead of ARSTR. Use the correct condition/macro there... Fixes: 6b4b4fead342 ("sh_eth: Implement ethtool register dump operations") Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: net/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net/drivers/net/ethernet/renesas/sh_eth.c @@ -2089,8 +2089,8 @@ static size_t __sh_eth_get_regs(struct n add_reg(CSMR); if (cd->select_mii) add_reg(RMII_MII); - add_reg(ARSTR); if (cd->tsu) { + add_tsu_reg(ARSTR); add_tsu_reg(TSU_CTRST); add_tsu_reg(TSU_FWEN0); add_tsu_reg(TSU_FWEN1);