From patchwork Tue Apr 23 20:29:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10913735 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C4D64112C for ; Tue, 23 Apr 2019 20:29:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B663828563 for ; Tue, 23 Apr 2019 20:29:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AA589288A2; Tue, 23 Apr 2019 20:29:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BAA428563 for ; Tue, 23 Apr 2019 20:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbfDWU3Z (ORCPT ); Tue, 23 Apr 2019 16:29:25 -0400 Received: from mail-qt1-f201.google.com ([209.85.160.201]:55375 "EHLO mail-qt1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbfDWU3Z (ORCPT ); Tue, 23 Apr 2019 16:29:25 -0400 Received: by mail-qt1-f201.google.com with SMTP id w53so7775231qtj.22 for ; Tue, 23 Apr 2019 13:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=BAEeSB7WGLvyDCfjwH+OOZ5AXvciJFw3qki2ZdjWtqk=; b=rNb+/yQd2oJ6Ajh3K+GJoteTQiuU1XWUI8+ojiGXzxP3NWfXLPE8GZRRO6aLRQUjv0 y9vm4CQ7TB+pU8KgxaLbUdOjKbWUUFJhhkQ6rve1b/AiNpSNkNmHWpSpT5PxRB/Piwff 9lMQ7b+iR4bdPCmCaKZ6BsMacA0OCJ1pTxZZEw1IJmNvWoCQ9Ghh11QKj6oWfWDBUNjE DoxWkQ2W79k/Zy+LBhbDXggzKka0q0rq3qUbtb1bJUlzKd+EXAQ52ErM/x1dcoxxYoAD JQyKc2NrZbjJHIE4QdIbRAyr8LMQw1sMfE31nEadL2pLEM1UGldr76znBP2eoKnqO+DB NQ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=BAEeSB7WGLvyDCfjwH+OOZ5AXvciJFw3qki2ZdjWtqk=; b=dyP116Ng3hvh4dL/Iw/g8we3CkeQY5AOovMma88gcUxT6yZF0bl/cQ6B1ckRtI5kRO gR6FBSWMpuZUq6/0PWCFzg2z3vWK889bLViZeMvliBxbjW/5AEbR1bi6uXeDCTyfkSUY 5lD9JxV9lPzgshzvP6rCLHvorhp3bR+Y/DNFMkY+OONvED8wYsya41FJHXsOtloN3C3j 712QxOxf7VG9/21Z5YORCZhWch54i0BsPKckkagIEmBnv701vmNio8r/OtYWirpqj/wX HO6Z8nK9MzduRL0j4oSmPumhipI7I+2zxBrFovFvxQqRdEGzgIBHamUIyU0FqwRFbqD0 BR6A== X-Gm-Message-State: APjAAAVdqvGRHl7DNs/nhAVXEycGtpON1Zg7oOM4EUMsNYkqAkFeQ+lt iq4Sgb4qf+JOW8hPIpRgMURU5R7YAHRSa16CHLY= X-Google-Smtp-Source: APXvYqyHBWfne7Rhm7SSxkktmG3M+4Zkv5H3nTWiSwql9vMWiQwqUWuoIsdRIQug3xaxUac6nox+uotiQOZVZKRQWfI= X-Received: by 2002:a05:6214:327:: with SMTP id j7mr7710680qvu.150.1556051364679; Tue, 23 Apr 2019 13:29:24 -0700 (PDT) Date: Tue, 23 Apr 2019 13:29:05 -0700 Message-Id: <20190423202907.234180-1-ndesaulniers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.593.g511ec345e18-goog Subject: [PATCH] sh: require --Wl,--hash-style=sysv From: Nick Desaulniers To: ysato@users.sourceforge.jp, dalias@libc.org Cc: Nick Desaulniers , Andy Lutomirsky , clang-built-linux@googlegroups.com, Masahiro Yamada , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Towards the goal of removing cc-ldoption, prefer ld-option, or better yet, require --Wl,--hash-style=sysv since the selftest for vdso's requires DT_HASH. Cc: Andy Lutomirsky Cc: clang-built-linux@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/sh/kernel/vsyscall/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile index 5db6579bc44c..6e8664448048 100644 --- a/arch/sh/kernel/vsyscall/Makefile +++ b/arch/sh/kernel/vsyscall/Makefile @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@ export CPPFLAGS_vsyscall.lds += -P -C -Ush -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \ - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv SYSCFLAGS_vsyscall-trapa.so = $(vsyscall-flags)