diff mbox series

sh: push-switch: add missing MODULE_DESCRIPTION() macro

Message ID 20240702-md-sh-arch-sh-drivers-v1-1-2c5d439a5479@quicinc.com (mailing list archive)
State New
Headers show
Series sh: push-switch: add missing MODULE_DESCRIPTION() macro | expand

Commit Message

Jeff Johnson July 2, 2024, 7:29 p.m. UTC 
With ARCH=sh, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/sh/drivers/push-switch.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
MODULE_DESCRIPTION copied from file prologue:
/*
 * Generic push-switch framework
 *
 * Copyright (C) 2006  Paul Mundt
 */
---
 arch/sh/drivers/push-switch.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 1dfe225e9af5bd3399a1dbc6a4df6a6041ff9c23
change-id: 20240702-md-sh-arch-sh-drivers-40af731eb66c

Comments

John Paul Adrian Glaubitz July 3, 2024, 3:12 p.m. UTC | #1 
Hi Jeff,

On Tue, 2024-07-02 at 12:29 -0700, Jeff Johnson wrote:
> With ARCH=sh, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/sh/drivers/push-switch.o
> 
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> MODULE_DESCRIPTION copied from file prologue:
> /*
>  * Generic push-switch framework
>  *
>  * Copyright (C) 2006  Paul Mundt
>  */
> ---
>  arch/sh/drivers/push-switch.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sh/drivers/push-switch.c b/arch/sh/drivers/push-switch.c
> index 362e4860bf52..1dea43381b5a 100644
> --- a/arch/sh/drivers/push-switch.c
> +++ b/arch/sh/drivers/push-switch.c
> @@ -131,4 +131,5 @@ module_exit(switch_exit);
>  
>  MODULE_VERSION(DRV_VERSION);
>  MODULE_AUTHOR("Paul Mundt");
> +MODULE_DESCRIPTION("Generic push-switch framework");
>  MODULE_LICENSE("GPL v2");
> 
> ---
> base-commit: 1dfe225e9af5bd3399a1dbc6a4df6a6041ff9c23
> change-id: 20240702-md-sh-arch-sh-drivers-40af731eb66c

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Thanks for fixing this. Will pick this up later this week.

Adrian
diff mbox series

Patch

diff --git a/arch/sh/drivers/push-switch.c b/arch/sh/drivers/push-switch.c
index 362e4860bf52..1dea43381b5a 100644
--- a/arch/sh/drivers/push-switch.c
+++ b/arch/sh/drivers/push-switch.c
@@ -131,4 +131,5 @@  module_exit(switch_exit);
 
 MODULE_VERSION(DRV_VERSION);
 MODULE_AUTHOR("Paul Mundt");
+MODULE_DESCRIPTION("Generic push-switch framework");
 MODULE_LICENSE("GPL v2");