| Message ID | 2080620.GIKTJkNfbk@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, Dec 27, 2014 at 12:20 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Define the generic R8A7791 parts of the CAN0/1 device nodes. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Apart from the minor nit below: Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi > +++ renesas/arch/arm/boot/dts/r8a7791.dtsi > @@ -816,6 +816,26 @@ > }; > }; > > + can0: can@e6e80000 { > + compatible = "renesas,can-r8a7791"; > + reg = <0 0xe6e80000 0 0x1000>; > + interrupts = <0 186 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp9_clks R8A7791_CLK_RCAN0>, > + <&cpg_clocks R8A7791_CLK_RCAN>, <&can_clk>; .git/rebase-apply/patch:18: space before tab in indent. <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; > + clock-names = "clkp1", "clkp2", "can_clk"; > + status = "disabled"; > + }; > + > + can1: can@e6e88000 { > + compatible = "renesas,can-r8a7791"; > + reg = <0 0xe6e88000 0 0x1000>; > + interrupts = <0 187 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp9_clks R8A7791_CLK_RCAN1>, > + <&cpg_clocks R8A7791_CLK_RCAN>, <&can_clk>; .git/rebase-apply/patch:28: space before tab in indent. <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; warning: 2 lines add whitespace errors. > + clock-names = "clkp1", "clkp2", "can_clk"; > + status = "disabled"; > + }; > +
On Mon, Jan 5, 2015 at 2:36 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> + clocks = <&mstp9_clks R8A7791_CLK_RCAN0>, >> + <&cpg_clocks R8A7791_CLK_RCAN>, <&can_clk>; > > .git/rebase-apply/patch:18: space before tab in indent. > <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; Sorry, my copy-'n-paste-foo has deteriorated over the holidays... s/7790/7791/ >> + clock-names = "clkp1", "clkp2", "can_clk"; >> + status = "disabled"; >> + }; >> + >> + can1: can@e6e88000 { >> + compatible = "renesas,can-r8a7791"; >> + reg = <0 0xe6e88000 0 0x1000>; >> + interrupts = <0 187 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&mstp9_clks R8A7791_CLK_RCAN1>, >> + <&cpg_clocks R8A7791_CLK_RCAN>, <&can_clk>; > > .git/rebase-apply/patch:28: space before tab in indent. > <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; s/7790/7791/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: renesas/arch/arm/boot/dts/r8a7791.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi +++ renesas/arch/arm/boot/dts/r8a7791.dtsi @@ -816,6 +816,26 @@ }; }; + can0: can@e6e80000 { + compatible = "renesas,can-r8a7791"; + reg = <0 0xe6e80000 0 0x1000>; + interrupts = <0 186 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_RCAN0>, + <&cpg_clocks R8A7791_CLK_RCAN>, <&can_clk>; + clock-names = "clkp1", "clkp2", "can_clk"; + status = "disabled"; + }; + + can1: can@e6e88000 { + compatible = "renesas,can-r8a7791"; + reg = <0 0xe6e88000 0 0x1000>; + interrupts = <0 187 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp9_clks R8A7791_CLK_RCAN1>, + <&cpg_clocks R8A7791_CLK_RCAN>, <&can_clk>; + clock-names = "clkp1", "clkp2", "can_clk"; + status = "disabled"; + }; + clocks { #address-cells = <2>; #size-cells = <2>;
Define the generic R8A7791 parts of the CAN0/1 device nodes. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- Changes in version 4: - refreshed the patch. Changes in version 3: - added 2 more CAN clocks along with "clock-names" property in the CAN0/1 device nodes; - refreshed the patch. Changes in version 2: - fixed the "compatible" property in the CAN device nodes. arch/arm/boot/dts/r8a7791.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html