From patchwork Thu Mar 14 12:54:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 2270621 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id E20A03FC8A for ; Thu, 14 Mar 2013 12:53:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755818Ab3CNMxe (ORCPT ); Thu, 14 Mar 2013 08:53:34 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:59424 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989Ab3CNMxd (ORCPT ); Thu, 14 Mar 2013 08:53:33 -0400 Received: from avalon.localnet (unknown [109.134.78.251]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A8493598D; Thu, 14 Mar 2013 13:53:21 +0100 (CET) From: Laurent Pinchart To: Simon Horman Cc: Laurent Pinchart , linux-sh@vger.kernel.org, Paul Mundt , Magnus Damm , Kuninori Morimoto , Guennadi Liakhovetski , Linus Walleij Subject: Re: [PATCH v4 00/88] PFC pinctrl functions for sh7372, sh73a0, r8a7740 and r8a7779 Date: Thu, 14 Mar 2013 13:54:11 +0100 Message-ID: <2240978.MXCESHIJiU@avalon> User-Agent: KMail/4.10 (Linux/3.7.10-gentoo; KDE/4.10.0; x86_64; ; ) In-Reply-To: <20130314094654.GN11196@verge.net.au> References: <1363215633-4264-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20130314091959.GK11196@verge.net.au> <20130314094654.GN11196@verge.net.au> MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Hi Simon, On Thursday 14 March 2013 10:46:55 Simon Horman wrote: [snip] > I am seeing (a hopefully minor) problem which is using the defconfigs for > the armadillo800eva I see: > > fbdev-laurent > > I believe this applies at least to all the other arm-based boards too. > > drivers/built-in.o:(.rodata+0xa4): undefined reference to > `pinconf_generic_dump_config' > > It seems like some Kconfig updates might be in order. I see two ways to fix this but I'm not sure which one is best. The first one handles the issue in the pinctrl core: Linus, what's your opinion? diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h index 1f7113e..971636d 100644 --- a/drivers/pinctrl/pinconf.h +++ b/drivers/pinctrl/pinconf.h @@ -90,7 +90,7 @@ static inline void pinconf_init_device_debugfs(struct dentry *devroot, * pin config. */ -#ifdef CONFIG_GENERIC_PINCONF +#if defined(CONFIG_GENERIC_PINCONF) && defined (CONFIG_DEBUG_FS) void pinconf_generic_dump_pin(struct pinctrl_dev *pctldev, struct seq_file *s, unsigned pin); And the second one in the PFC driver: diff --git a/drivers/pinctrl/sh-pfc/pinctrl.c b/drivers/pinctrl/sh-pfc/pinctrl.c index aef268b..b5ec109 100644 --- a/drivers/pinctrl/sh-pfc/pinctrl.c +++ b/drivers/pinctrl/sh-pfc/pinctrl.c @@ -365,7 +365,9 @@ static const struct pinconf_ops sh_pfc_pinconf_ops = { .pin_config_get = sh_pfc_pinconf_get, .pin_config_set = sh_pfc_pinconf_set, .pin_config_group_set = sh_pfc_pinconf_group_set, +#ifdef CONFIG_DEBUG_FS .pin_config_config_dbg_show = pinconf_generic_dump_config, +#endif }; /* PFC ranges -> pinctrl pin descs */