From patchwork Sat Jun 20 00:33:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 6649911 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 90CA7C05AC for ; Sat, 20 Jun 2015 00:34:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EB3C920893 for ; Sat, 20 Jun 2015 00:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 489A02088D for ; Sat, 20 Jun 2015 00:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160AbbFTAd6 (ORCPT ); Fri, 19 Jun 2015 20:33:58 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:36738 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754122AbbFTAd4 (ORCPT ); Fri, 19 Jun 2015 20:33:56 -0400 Received: by lbbqq2 with SMTP id qq2so80868421lbb.3 for ; Fri, 19 Jun 2015 17:33:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=gm2dABAufOTZxK1m/W1XJWraCd0D7xvHJJ2q63ZVFIs=; b=QUu7lQNtCC5A+vn5BihIGTlZQwMbbk1FaiZOXUE4EmaN2Ja994zd5tfxLCd6bZ0sKc WF01eMySg8xQX5IDY2raka6chtdHEpUY1rrTohvHLVTZnh8qawGdQDxYiEoKs8Pu2kFB zYDy2YyprYokLYghB7l+mN/rOVNWQ5fy+kkCX1MU1rlOWzwKNiksbcuP7nG5gPQLxSYD VGhPJLc0kjYMUVBYHS9xMUQIz5TT+1c6viqCSc5rRxoAb0uSdCQzcysocaC8Bw6/iwug iyaCx0/UT/cFvV42nyHTPtQpUJR5Lv26JejV6qH4mpHthRo3RXPipE4XwmotZMpS6mR7 6uDA== X-Gm-Message-State: ALoCoQmgb17R9gg52MG/ixAHkfF1nDoz80jToYLyVPGOriSoQINdhLo96D8VfeZxRvgB0evSH6l3 X-Received: by 10.152.239.131 with SMTP id vs3mr20513805lac.102.1434760435575; Fri, 19 Jun 2015 17:33:55 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp83-237-255-137.pppoe.mtu-net.ru. [83.237.255.137]) by mx.google.com with ESMTPSA id q9sm2829357lag.20.2015.06.19.17.33.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jun 2015 17:33:54 -0700 (PDT) From: Sergei Shtylyov To: netdev@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org Cc: linux-sh@vger.kernel.org Subject: [PATCH 2/3] rcar_can: print signed IRQ # Date: Sat, 20 Jun 2015 03:33:53 +0300 Message-ID: <2390389.thI8mIvbv5@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.7 (Linux/4.0.4-202.fc21.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <2010452.WyFito6egU@wasted.cogentembedded.com> References: <2010452.WyFito6egU@wasted.cogentembedded.com> MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as 'ndev->irq' is of type *int*, so the "%d" format needs to be used instead. While fixing this, beautify the dev_info() message in rcar_can_probe() a bit. Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver") Signed-off-by: Sergei Shtylyov --- drivers/net/can/rcar_can.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in Index: linux-can/drivers/net/can/rcar_can.c =================================================================== --- linux-can.orig/drivers/net/can/rcar_can.c +++ linux-can/drivers/net/can/rcar_can.c @@ -526,7 +526,7 @@ static int rcar_can_open(struct net_devi napi_enable(&priv->napi); err = request_irq(ndev->irq, rcar_can_interrupt, 0, ndev->name, ndev); if (err) { - netdev_err(ndev, "error requesting interrupt %x\n", ndev->irq); + netdev_err(ndev, "error requesting interrupt %d\n", ndev->irq); goto out_close; } can_led_event(ndev, CAN_LED_EVENT_OPEN); @@ -824,7 +824,7 @@ static int rcar_can_probe(struct platfor devm_can_led_init(ndev); - dev_info(&pdev->dev, "device registered (reg_base=%p, irq=%u)\n", + dev_info(&pdev->dev, "device registered (regs @ %p, IRQ%d)\n", priv->regs, ndev->irq); return 0;