| Message ID | 2641177.jdYX8POT82@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
On Sat, Sep 06, 2014 at 03:34:32AM +0400, Sergei Shtylyov wrote: > Bits 8-31 of all registers reflect the value of bits 0-7 on reads and should be > 0 on writes, according to the manuals. RCAR_IRQ_ACK_{RECV|SEND} macros have all > 1's in bits 8-31, thus going against the manuals, so fix them. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Cc: stable@vger.kernel.org > Applied to for-current, thanks!
Hello. On 09/20/2014 01:51 PM, Wolfram Sang wrote: >> Bits 8-31 of all registers reflect the value of bits 0-7 on reads and should be >> 0 on writes, according to the manuals. RCAR_IRQ_ACK_{RECV|SEND} macros have all >> 1's in bits 8-31, thus going against the manuals, so fix them. >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> Cc: stable@vger.kernel.org > Applied to for-current, thanks! Thanks. However, I don't see it in your tree (and neither my cleanups). WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux/drivers/i2c/busses/i2c-rcar.c =================================================================== --- linux.orig/drivers/i2c/busses/i2c-rcar.c +++ linux/drivers/i2c/busses/i2c-rcar.c @@ -76,8 +76,8 @@ #define RCAR_IRQ_RECV (MNR | MAL | MST | MAT | MDR) #define RCAR_IRQ_STOP (MST) -#define RCAR_IRQ_ACK_SEND (~(MAT | MDE)) -#define RCAR_IRQ_ACK_RECV (~(MAT | MDR)) +#define RCAR_IRQ_ACK_SEND (~(MAT | MDE) & 0xFF) +#define RCAR_IRQ_ACK_RECV (~(MAT | MDR) & 0xFF) #define ID_LAST_MSG (1 << 0) #define ID_IOERROR (1 << 1)
Bits 8-31 of all registers reflect the value of bits 0-7 on reads and should be 0 on writes, according to the manuals. RCAR_IRQ_ACK_{RECV|SEND} macros have all 1's in bits 8-31, thus going against the manuals, so fix them. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: stable@vger.kernel.org --- The patch is against Wolfram Sang's 'linux.git' repo's 'i2c/for-current' branch. drivers/i2c/busses/i2c-rcar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html