| Message ID | 31c717c18bd94839d46c4de726cc573ff563b3e1.1699856600.git.ysato@users.sourceforge.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Device Tree support for SH7751 based board | expand |
On 14/11/2023 09:00, Yoshinori Sato wrote: > Add SH7750 TMU entry. > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Still not tested. I repeated it multiple times. Please answer below, whether you understand it: Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. > --- > .../devicetree/bindings/timer/renesas,tmu.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > index a67e427a9e7e..925c2a691b25 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > @@ -21,6 +21,7 @@ properties: > compatible: > items: > - enum: > + - renesas,tmu-sh7750 # SH7750 > - renesas,tmu-r8a7740 # R-Mobile A1 > - renesas,tmu-r8a774a1 # RZ/G2M > - renesas,tmu-r8a774b1 # RZ/G2N > @@ -46,7 +47,14 @@ properties: > > interrupts: > minItems: 2 > - maxItems: 3 > + maxItems: 4 > + > + interrupt-names: > + items: > + - const: tuni0 > + - const: tuni1 > + - const: tuni2 > + - const: ticpi2 Other variants should be constrained to three items. Best regards, Krzysztof
Hi Krzysztof, On Tue, Nov 14, 2023 at 10:26 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 14/11/2023 09:00, Yoshinori Sato wrote: > > Add SH7750 TMU entry. > > > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > > diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > > index a67e427a9e7e..925c2a691b25 100644 > > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml > > @@ -21,6 +21,7 @@ properties: > > compatible: > > items: > > - enum: > > + - renesas,tmu-sh7750 # SH7750 > > - renesas,tmu-r8a7740 # R-Mobile A1 > > - renesas,tmu-r8a774a1 # RZ/G2M > > - renesas,tmu-r8a774b1 # RZ/G2N > > @@ -46,7 +47,14 @@ properties: > > > > interrupts: > > minItems: 2 > > - maxItems: 3 > > + maxItems: 4 > > + > > + interrupt-names: > > + items: > > + - const: tuni0 > > + - const: tuni1 > > + - const: tuni2 > > + - const: ticpi2 > > Other variants should be constrained to three items. Actually that is not true: the number of interrupts depends on the instance, not on the SoC. The fourth interrupt is present on some instances on other SoCs, too, but was never described before, as the driver doesn't support it yet (I know this is not a good reason). Of course none of this is obvious to the casual reviewer if it is not mentioned in the patch description... I'm working on making this more clear, and adding support for missing variants. Gr{oetje,eeting}s, Geert
On 15/11/2023 09:17, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Tue, Nov 14, 2023 at 10:26 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> On 14/11/2023 09:00, Yoshinori Sato wrote: >>> Add SH7750 TMU entry. >>> >>> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > >>> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml >>> index a67e427a9e7e..925c2a691b25 100644 >>> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml >>> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml >>> @@ -21,6 +21,7 @@ properties: >>> compatible: >>> items: >>> - enum: >>> + - renesas,tmu-sh7750 # SH7750 >>> - renesas,tmu-r8a7740 # R-Mobile A1 >>> - renesas,tmu-r8a774a1 # RZ/G2M >>> - renesas,tmu-r8a774b1 # RZ/G2N >>> @@ -46,7 +47,14 @@ properties: >>> >>> interrupts: >>> minItems: 2 >>> - maxItems: 3 >>> + maxItems: 4 >>> + >>> + interrupt-names: >>> + items: >>> + - const: tuni0 >>> + - const: tuni1 >>> + - const: tuni2 >>> + - const: ticpi2 >> >> Other variants should be constrained to three items. > > Actually that is not true: the number of interrupts depends on the > instance, not on the SoC. The fourth interrupt is present on some > instances on other SoCs, too, but was never described before, as the > driver doesn't support it yet (I know this is not a good reason). > Of course none of this is obvious to the casual reviewer if it is > not mentioned in the patch description... > > I'm working on making this more clear, and adding support for missing > variants. OK, thanks for explanation. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml index a67e427a9e7e..925c2a691b25 100644 --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml @@ -21,6 +21,7 @@ properties: compatible: items: - enum: + - renesas,tmu-sh7750 # SH7750 - renesas,tmu-r8a7740 # R-Mobile A1 - renesas,tmu-r8a774a1 # RZ/G2M - renesas,tmu-r8a774b1 # RZ/G2N @@ -46,7 +47,14 @@ properties: interrupts: minItems: 2 - maxItems: 3 + maxItems: 4 + + interrupt-names: + items: + - const: tuni0 + - const: tuni1 + - const: tuni2 + - const: ticpi2 clocks: maxItems: 1 @@ -84,6 +92,7 @@ if: - renesas,tmu-r8a7740 - renesas,tmu-r8a7778 - renesas,tmu-r8a7779 + - renesas,tmu-sh7750 then: required: - resets
Add SH7750 TMU entry. Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> --- .../devicetree/bindings/timer/renesas,tmu.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)