| Message ID | 53871338.8050606@renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello. On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote: > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index e06c486..e6b04f2 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -902,4 +902,14 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + xhci: xhci@ee000000 { The node name should be "usb@ee000000", according to section 2.2.2 of the ePAPR standard [1]: > + compatible = "renesas,xhci-r8a7790"; > + reg = <0 0xee000000 0 0xc00>; > + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; > + phys = <&usbphy 1 1>; This part is dependent on the generic PHY support in the USB HCD in order to work. > + phy-names = "usb"; > + status = "disabled"; > + }; > }; [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. (2014/05/30 1:08), Sergei Shtylyov wrote: > Hello. > > On 05/29/2014 03:00 PM, Yoshihiro Shimoda wrote: > >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> --- >> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > >> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi >> index e06c486..e6b04f2 100644 >> --- a/arch/arm/boot/dts/r8a7790.dtsi >> +++ b/arch/arm/boot/dts/r8a7790.dtsi >> @@ -902,4 +902,14 @@ >> #size-cells = <0>; >> status = "disabled"; >> }; >> + >> + xhci: xhci@ee000000 { > > The node name should be "usb@ee000000", according to section 2.2.2 of the > ePAPR standard [1]: Thank you for the point! I will fix this and r8a7791's one. >> + compatible = "renesas,xhci-r8a7790"; >> + reg = <0 0xee000000 0 0xc00>; >> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; >> + phys = <&usbphy 1 1>; > > This part is dependent on the generic PHY support in the USB HCD in order > to work. This means that I should wait to add this parameter until the generic USB PHY Gen2 driver is supported in upstream? Best regards, Yoshihiro Shimoda >> + phy-names = "usb"; >> + status = "disabled"; >> + }; >> }; > > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf > > WBR, Sergei >
Hello. On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote: >>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>> --- >>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi >>> index e06c486..e6b04f2 100644 >>> --- a/arch/arm/boot/dts/r8a7790.dtsi >>> +++ b/arch/arm/boot/dts/r8a7790.dtsi >>> @@ -902,4 +902,14 @@ >>> #size-cells = <0>; >>> status = "disabled"; >>> }; >>> + >>> + xhci: xhci@ee000000 { >> The node name should be "usb@ee000000", according to section 2.2.2 of the >> ePAPR standard [1]: > Thank you for the point! I will fix this and r8a7791's one. >>> + compatible = "renesas,xhci-r8a7790"; >>> + reg = <0 0xee000000 0 0xc00>; >>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; >>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; >>> + phys = <&usbphy 1 1>; >> This part is dependent on the generic PHY support in the USB HCD in order >> to work. Oops, I hadn't seen that you added generic PHY support to the xHCI driver when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers. > This means that I should wait to add this parameter until the generic USB PHY Gen2 > driver is supported in upstream? At least describe that dependency. > Best regards, > Yoshihiro Shimoda WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. (2014/05/30 22:08), Sergei Shtylyov wrote: > Hello. > > On 05/30/2014 04:14 PM, Yoshihiro Shimoda wrote: > >>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >>>> --- >>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) > >>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi >>>> index e06c486..e6b04f2 100644 >>>> --- a/arch/arm/boot/dts/r8a7790.dtsi >>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi >>>> @@ -902,4 +902,14 @@ >>>> #size-cells = <0>; >>>> status = "disabled"; >>>> }; >>>> + >>>> + xhci: xhci@ee000000 { > >>> The node name should be "usb@ee000000", according to section 2.2.2 of the >>> ePAPR standard [1]: > >> Thank you for the point! I will fix this and r8a7791's one. > >>>> + compatible = "renesas,xhci-r8a7790"; >>>> + reg = <0 0xee000000 0 0xc00>; >>>> + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; >>>> + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; >>>> + phys = <&usbphy 1 1>; > >>> This part is dependent on the generic PHY support in the USB HCD in order >>> to work. > > Oops, I hadn't seen that you added generic PHY support to the xHCI driver when writing this. I'm however for adding the generic PHY support to the generic USB HCD code, so that we can use it for the PCI controllers. > >> This means that I should wait to add this parameter until the generic USB PHY Gen2 >> driver is supported in upstream? > > At least describe that dependency. Thank you for the reply! I will add such a describption in change log. Best regards, Yoshihiro Shimoda >> Best regards, >> Yoshihiro Shimoda > > WBR, Sergei >
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index e06c486..e6b04f2 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -902,4 +902,14 @@ #size-cells = <0>; status = "disabled"; }; + + xhci: xhci@ee000000 { + compatible = "renesas,xhci-r8a7790"; + reg = <0 0xee000000 0 0xc00>; + interrupts = <0 101 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp3_clks R8A7790_CLK_SSUSB>; + phys = <&usbphy 1 1>; + phy-names = "usb"; + status = "disabled"; + }; };
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)