From patchwork Thu Aug 27 01:16:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 7080731 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8D655BEEC1 for ; Thu, 27 Aug 2015 01:16:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8A497207FA for ; Thu, 27 Aug 2015 01:16:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80F37207F7 for ; Thu, 27 Aug 2015 01:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbbH0BQU (ORCPT ); Wed, 26 Aug 2015 21:16:20 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:20253 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751339AbbH0BQS (ORCPT ); Wed, 26 Aug 2015 21:16:18 -0400 Received: from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152]) by relmlie1.idc.renesas.com with ESMTP; 27 Aug 2015 10:16:16 +0900 Received: from relmlac2.idc.renesas.com (relmlac2.idc.renesas.com [10.200.69.22]) by relmlir2.idc.renesas.com (Postfix) with ESMTP id C6F104F871; Thu, 27 Aug 2015 10:16:16 +0900 (JST) Received: by relmlac2.idc.renesas.com (Postfix, from userid 0) id B9C372806E; Thu, 27 Aug 2015 10:16:16 +0900 (JST) Received: from relmlac2.idc.renesas.com (localhost [127.0.0.1]) by relmlac2.idc.renesas.com (Postfix) with ESMTP id 9A1712806D; Thu, 27 Aug 2015 10:16:16 +0900 (JST) Received: from relmlii1.idc.renesas.com [10.200.68.65] by relmlac2.idc.renesas.com with ESMTP id LAC22565; Thu, 27 Aug 2015 10:16:16 +0900 X-IronPort-AV: E=Sophos;i="5.17,419,1437404400"; d="scan'";a="193177952" Received: from mail-sg2apc01lp0241.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.241]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA; 27 Aug 2015 10:16:15 +0900 Received: from SIXPR06MB0924.apcprd06.prod.outlook.com (10.162.180.29) by SIXPR06MB079.apcprd06.prod.outlook.com (10.242.63.148) with Microsoft SMTP Server (TLS) id 15.1.256.15; Thu, 27 Aug 2015 01:16:14 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; linux-m68k.org; dkim=none (message not signed) header.d=none; linux-m68k.org; dmarc=none action=none header.from=renesas.com; Received: from [10.166.13.234] (211.11.155.144) by SIXPR06MB0924.apcprd06.prod.outlook.com (10.162.180.29) with Microsoft SMTP Server (TLS) id 15.1.243.23; Thu, 27 Aug 2015 01:16:12 +0000 Message-ID: <55DE64D7.3070600@renesas.com> Date: Thu, 27 Aug 2015 10:16:07 +0900 From: Yoshihiro Shimoda User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Geert Uytterhoeven , Kuninori Morimoto , Takeshi Kihara CC: Simon , Magnus , Linux-sh list , YOSHIYUKI ITO , Hisao Munakata , Yusuke Goda , TOSHIAKI KOMATSU , Gaku Inami Subject: Re: [PATCH 16/25 v7][RFC] arm64: renesas: salvator-x: add pfc node and subnodes for usb 2.0 References: <87si7977g4.wl%kuninori.morimoto.gx@renesas.com> <876145776m.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: KAWPR01CA0034.jpnprd01.prod.outlook.com (25.165.48.144) To SIXPR06MB0924.apcprd06.prod.outlook.com (25.162.180.29) X-Microsoft-Exchange-Diagnostics: 1; SIXPR06MB0924; 2:rJMvqXUPbGMgt1EbKP17sFrmIcrxCwXHCfzS95brKz9yf4rIUcHDuiq3B2x0cqSE5WYM9XLVSRrXW4/ZcQqy7ylJmbNUYhyNWLLSJumNhlCZIF0TfHHGtcfxbE4k3LBFesRW9rpXLW730JDCWgZpOUEo2jaX56QjVhCXRIWPhbM=; 3:OIegV4I5ugK4/4gvAG7DRUea6ADzW9f70wNXDomg0dfYJGEoKFmf/KUx3kk+WkMEmFjzr0FDbvF+/IBihu6MtBSPAaNiX92ATa1JawRMR/VclejjyLnqLt3aYxbgZb+zXjCtH6fz615BUcRV9eBRWw==; 25:JQGF42Cyq/9fqfWa+/GPK7QlwGI6PqaEGvxtdS/orrfuQPhrKx7gbv3s/WznbYAHmhcaHNcgwgVy2M5TBqOoLJj06eBsw6I9pRWfSkutImAL3M5QNjzdqWgaeIjnurM/wsY9kGi1xg5Aa8K9wJ+kQ+ObOzGk/7wrAh3cNG6oPM7ZHSYcp0K9rXeLlpnwt4K7wWCJcbRg63qiOSB4wCNEup2UOdjcI65xdthCztWMtWpkQMTFlrOgxPKlX8XbUBYwAvDZoAWLPJlg7SG5y0mI1A== X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:; SRVR:SIXPR06MB0924; UriScan:; BCL:0; PCL:0; RULEID:; SRVR:SIXPR06MB079; X-Microsoft-Exchange-Diagnostics: 1; SIXPR06MB0924; 20:/+20drxDYbO6S6UksUjeARU4K0SfmIB1IIQRzK9pUoFdi3r/7QUlaOpGz+qq1NQV86DjkSjCICJ3GsE452VPhnXs7kdv6KZxvJ0JULOie5V5iDFTswNr43oHSYO98Wccorw0CCb3oKGiNySI4pTTPJr1OJmHuxjkJjfkPbX5rxvXxkTzy8Jop5YGWe/jC+In1+3akUJ2By4fCWkp3W865rUOA3H8vBTZd1fhi9LwSYRX9IbjJBE6kDfFDnTD+p2DufVKZhfqRXPu8yrexVBEVZ6DCX8rp9fEGBC+VALwfDq3ZGWW5HqEdWDtlk2xnB67H+p8arRHb3kK2HnNWCGVdzMcLeTbscgV7rud1tQlKo3eE3YNNlxtWIeH2j/MLlVbYvfXlpgvSFam17gBwNCRQ8dFdpqBpMzooRReqr15NcZ19z5+8OZ9GfVkKnkL9LwQhs+3qOh1mkIp9ARO5BWM+a1eqSygqpjlUBja6duKhtycBZ8pAussADiel+3Gdn+w; 4:X+ZLu1hA5zmUV5mUbpTotfX5Ta/CR1X4gOZoTNG4YlB0t+c8AoZR8PEF2J3Px/mr8Snix6XRkV2Gc2qrLIjf4A+ewjB21eyJ21uOHtuCcKlHXJchL0U6NBBv4T6Ras0y2BSeOGlVt9c/6w1DX1yWXeTQQvhDRLNZXJ0+uD6i/WXIwXaJc+6mfKwzdk8VhryXkt50IFaSRdCdm6kKUI4L/VeoRmnq0atOsgPGk1IR1YNAsqesbZX1PxooTbp6ANe6xXgPD+qaoCbOqE8kWOTW7KtkLQhiXXJMoLLiemkLqXPx7GBdsMGmczgNwjD45Ifd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(8121501046)(3002001); SRVR:SIXPR06MB0924; BCL:0; PCL:0; RULEID:; SRVR:SIXPR06MB0924; X-Forefront-PRVS: 06818431B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6049001)(6009001)(24454002)(189002)(199003)(377454003)(45984002)(479174004)(5001830100001)(189998001)(92566002)(107886002)(81156007)(5001770100001)(5001960100002)(4001540100001)(59896002)(77096005)(4001450100002)(65816999)(101416001)(77156002)(5001860100001)(2950100001)(50466002)(62966003)(19580395003)(80316001)(83506001)(66066001)(4001350100001)(19580405001)(97736004)(68736005)(42186005)(87976001)(5007970100001)(46102003)(64126003)(65956001)(86362001)(36756003)(106356001)(33656002)(40100003)(105586002)(76176999)(122386002)(47776003)(50986999)(54356999)(87266999)(23756003)(5004730100002)(65806001)(64706001)(4001430100001); DIR:OUT; SFP:1102; SCL:1; SRVR:SIXPR06MB0924; H:[10.166.13.234]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; SIXPR06MB0924; 23:6iHrvul/lsLUNU2ZhWOXkLYlPd9V4YyNEiVBbIL?= =?iso-8859-1?Q?OOejMCmTNk7ID4CNDPs7Pz+fhAw3EgmVqOUpYfUTJ46s4AFfONAOiJWdw5?= =?iso-8859-1?Q?c5/7+tOe7z6p1h716Sb8wvhaxKYjO8onOWL+cUpJsEDdLo/Xq8Ch2QOpmq?= =?iso-8859-1?Q?2B5isasGCiHSFQQktxVsYix/BsVgbt7nIbiI2uebaGmWKgM3/+TdgT+6H3?= =?iso-8859-1?Q?Xg1DyXuAFDjoHeJ9JnGaKvCiUNftgLuGPV/fEZ2ik3QSYKtvLfp1ezNtzF?= =?iso-8859-1?Q?ym4K8Xe0CgSaL9m2ninXlDGRapd9gpjBVPpW4J5MQQJDgYhIS5NRu0Yr3U?= =?iso-8859-1?Q?Uikc58i3dC97r58TcLN+lF5fggFbsBQC381bKz+PDOXpSN1whwY52WfICA?= =?iso-8859-1?Q?zDR7ECbCc+fUni7KphEpag+fZBeBuNXe6GFrd3jwGTuPXmSTBMzrVXmMMm?= =?iso-8859-1?Q?V7zCtLPQE7LE3UuCfF3djCUJY5biJYnM/KE0MCSjqRlNiuJ3YX8b1ZCMWh?= =?iso-8859-1?Q?2xipfLcLBFPm0Mpy3D7gWZdT02N0a4PHx+Y93xH3cbQcbG9dH4eLz5fu3t?= =?iso-8859-1?Q?h4yJXrFWtSlDaBCva77+I6efLWVA/LekxPHnzu39ATmzMUSb13OTGycNP7?= =?iso-8859-1?Q?pifdzYN4sBCCp5qHphs/EfjCL0u+7wPLBFkwqOOekhX1zQD+UE7F2+bYDv?= =?iso-8859-1?Q?Q8LgVUX3ZnFFJfwAGy8UmsAkDQ3ewktaOa3vQrupB+rwmAtgmOWj2stqR1?= =?iso-8859-1?Q?hQQLWOSxv3uqHD2JZhZcgoKKxJ9i14D8mXSeYpH7n8pNJ8iqCLNEZRPqqR?= =?iso-8859-1?Q?tRDTgzvkzGe0yVDDrj7pUkVpumDojf+DxpBlzCMuuWnQNrBLv6gN0eNS+Z?= =?iso-8859-1?Q?kNvFcgrKUzGA5hczXzOxH0T87WZx2n2qyusr1lKUUZkT8fda4t6EVzc7nZ?= =?iso-8859-1?Q?QnA6+K9zOhBXa/mmoJw3xBoyPdq7iKod4MErMRehoxv/fi/npP9wZ8AvL5?= =?iso-8859-1?Q?hi9q6coTb3w7ej0lPeqWkj5ZkNUtFW3yAG28Q8z3LEyAj6zbV9u+UpDclk?= =?iso-8859-1?Q?jUh1WIQ3KCqs80vuL8C/sg6jOX06Wu+3jbAEimnPeczyhYNwmWE9gKE5zk?= =?iso-8859-1?Q?dMQ/CrZkWobXFGawyq78LQBvVsUlaw9SeHVkQHxGxZ7HCZikHJ8lSDBhjn?= =?iso-8859-1?Q?f8dCWKNz3IARJRWsYm/EoNQTR/NzVwJOCCkmp4kI+u30omhTl14cWydJUh?= =?iso-8859-1?Q?NE4ntktdjNuDJnE+aoAbtpCua1eDIxDC+EBRTBtSlnUq+3Qv01PLfZuC10?= =?iso-8859-1?Q?br9mW0j6dMQhawhA3NuAJQZbV4OmgdUthM0fZRx3aslKmUZdva4LawRAVP?= =?iso-8859-1?Q?XwUhkggAnBJvM5wyUuoL8kAxAzrYfK1q7HKnU8BvOr/Aq7lblnUmOUHmvE?= =?iso-8859-1?Q?PGry05+ougFjt685uj3oir2E7ERs0sFTkUWuvSxofqkN3wkhRU4sbh+s1+?= =?iso-8859-1?Q?aRD94D5t7mfWLSzq9n5dFJTgTNL6uucFavrXNQROCtzJy4LY3ftky3OICc?= =?iso-8859-1?Q?ahVeRXe3g084mqltq2XuiNpq/w=3D?= X-Microsoft-Exchange-Diagnostics: 1; SIXPR06MB0924; 5:QGFfXTUBDhCtps5t+Jn5ED4Q9SrdMRmYTQXyhSnZZfxIVR4L8izibzUKqsOcXh1s1yAUtLdIklJvYxNslHN/mvu0bMGoch10j5AXuOGoQHHRnA9vtKkzVbKT3YmHCm57pjAwtqE+DQiXK9j8IxZqQw==; 24:K/nDVu+aqic1DaE0T0j6kzTF/x2unFWTDGzEr9PRlg8I6ff4pdFE1z5nyPmKhyMvO3GAfiCoTyLuOpJMN3Bvim2eSjE0GH4m9MA/MrZxCOw=; 20:tWc9cMMrBhvVV+yZMalOHdCu41jFEONEnztgGwMlL8mkmjzw2gqqDwcLqw0cWgo9XWSe03KivTdWmL/CpO1+XcYdPMrzQlSkszTWzq1fA93MD7yv6HtwjiyiihZKoMo2wFfXqVmtMsf1VZ7rdhR9uptFYCWcxJGQ60Y9qf3AosM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2015 01:16:12.5815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR06MB0924 X-Microsoft-Exchange-Diagnostics: 1; SIXPR06MB079; 2:Dg6IZweYh55Z6EEf1YeENfFCkkKrJ6Q2rgMss0Gz4DHnev2QCCguw9LVQMTf2ZEY9uS05FoMnKPIYquMKJblkGpD+ZtoMSOf1NXAFWFTPNHB7/h9mcykTrnKgh3SoKKNu1W1OUH4ZA1TWASheAYYT3JV7+63oUFTXnLeUAhrQSc=; 3:AGE0wKzdqwhcFzFJWKXFMKdDZSj1ylUc9DdXBuLLlCcPDPfxJEJSEMVux/zjyk9AHP6CcRLQ+ryA43b0u3HjRmwbIXz28pyfMk4OXYAkobRCID4w7LQ+8ZhwhpGftjct4DRk5ZJfr8krsm4smKRYtQ==; 25:jcGzBv/ME490up2q+HVv3E23zZd78KJNHxQvmEdrATV+dfEDV1GWdLQZ57Ut4DoZUEOYE6kfN9mhp2F8G2jROnx2toa5ld16PFyfXrM0Z5VLrKJXHVh1gjxv+7E2dZeanRSsKdWaQGKfGnroH72Oq02XIVxo2wW729yh9D9SEITBUnO9XfekxFYAbCGKP6lMLqHu3ZUPFTvp3FQlYydQYFexqo3J1qPvXGi4m2CtNVmzeLlQSIywZKHNsTI/UQqm7SViDI0/1B5V2ZQUNapnAQ==; 23:b0IbpdiKY0lj1P61FmNWFJbejmFDOM5Hxjn1+lRGsvUyeKCeQ5pz5NuEnfhCJ6l3N2zkKQlhaeCkCaU/CLtdnSIBPyyfWltTk5PJpwdqCeSEpjlaTolMH9d535Im9ECgJmx2w3UraeHIDm7nFmlmkgqKUtQxFKnnIFmSYKyEeKBVIHUaMGNig3YjzBqVvkET X-OriginatorOrg: renesas.com Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Geert-san, (2015/08/26 23:26), Geert Uytterhoeven wrote: > Hi Shimoda-san, Morimoto-san, Kihara-san, > > On Mon, Aug 24, 2015 at 4:30 AM, Kuninori Morimoto > wrote: >> From: Yoshihiro Shimoda > >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts >> @@ -38,6 +38,23 @@ >> }; >> }; >> >> +&pfc { >> + usb0_pins: usb0 { >> + renesas,groups = "usb0"; >> + renesas,function = "usb0"; >> + }; >> + >> + usb1_pins: usb1 { >> + renesas,groups = "usb1"; >> + renesas,function = "usb1"; >> + }; >> + >> + usb2_pins: usb2 { >> + renesas,groups = "usb2"; >> + renesas,function = "usb2"; >> + }; >> +}; > > If CONFIG_PINCTRL=y: > > | sh-pfc e6060000.pfc: cannot locate data/mark enum_id for mark 2253 > | phy_rcar_gen3_usb2 ee080200.usb-phy: Error applying setting, reverse > things back > > mark 2253 = USB0_PWEN_MARK > > I believe this is due to the IPSR16 section in the pinmux_data[] array in > drivers/pinctrl/sh-pfc/pfc-r8a7795.c lacking data for IP16_11_8. > Data for usb1 (IP16_19_16) and usb2 (IP15_3_0) is present. > > Unfortunately my pinctrl foo is not strong enough to fill in the missing > pieces... Thank you very much for the point. I have ignored the error message because usb0 worked on my environment :) However, we should fix it. And then, I found missing pieces for usb0 part as you mentioned. If I applied the following patch, the error message disappeared and usb0 also worked. So, Morimoto-san, if possible, would you merge this patch in v8? Best regards, Yoshihiro Shimoda --- -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c index 9437e87..1f60f4c 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c @@ -1335,6 +1335,19 @@ static const u16 pinmux_data[] = { PINMUX_IPSR_DATA(IP15_31_28, SCK5), /* IPSR16 */ + PINMUX_IPSR_DATA(IP16_11_8, USB0_PWEN), + PINMUX_IPSR_MODSEL_DATA(IP16_11_8, SIM0_RST_C, SEL_SIMCARD_2), + PINMUX_IPSR_MODSEL_DATA(IP16_11_8, TS_SCK1_D, SEL_TSIF1_3), + PINMUX_IPSR_MODSEL_DATA(IP16_11_8, STP_ISCLK_1_D, SEL_SSP1_1_3), + PINMUX_IPSR_MODSEL_DATA(IP16_11_8, BPFCLK_B, SEL_FM_1), + PINMUX_IPSR_MODSEL_DATA(IP16_11_8, RIF3_CLK_B, SEL_DRIF3_1), + + PINMUX_IPSR_DATA(IP16_15_12, USB0_OVC), + PINMUX_IPSR_MODSEL_DATA(IP16_15_12, SIM0_D_C, SEL_SIMCARD_2), + PINMUX_IPSR_MODSEL_DATA(IP16_15_12, TS_SDAT1_D, SEL_TSIF1_3), + PINMUX_IPSR_MODSEL_DATA(IP16_15_12, STP_ISD_1_D, SEL_SSP1_1_3), + PINMUX_IPSR_MODSEL_DATA(IP16_15_12, RIF3_SYNC_B, SEL_DRIF3_1), + PINMUX_IPSR_DATA(IP16_19_16, USB1_PWEN), PINMUX_IPSR_MODSEL_DATA(IP16_19_16, SIM0_CLK_C, SEL_SIMCARD_2), PINMUX_IPSR_MODSEL_DATA(IP16_19_16, SSI_SCK1_A, SEL_SSI_0),