| Message ID | 7554aadc5afb915ee1065cea56053cb6@208suo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned' | expand |
On Sun, Jul 9, 2023 at 2:39 PM <xuanzhenggang001@208suo.com> wrote: > Fix the following warnings reported by checkpatch: > > arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > > Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> > --- > arch/sh/drivers/heartbeat.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c > index 24391b444b28..07f04ed0d517 100644 > --- a/arch/sh/drivers/heartbeat.c > +++ b/arch/sh/drivers/heartbeat.c > @@ -30,7 +30,7 @@ > static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 }; > > static inline void heartbeat_toggle_bit(struct heartbeat_data *hd, > - unsigned bit, unsigned int inverted) > + unsigned int bit, unsigned int inverted) > { > unsigned int new; > > @@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct > heartbeat_data *hd, patch: **** malformed patch at line 19: heartbeat_data *hd, Please fix your email setup. Gr{oetje,eeting}s, Geert
diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c index 24391b444b28..07f04ed0d517 100644 --- a/arch/sh/drivers/heartbeat.c +++ b/arch/sh/drivers/heartbeat.c @@ -30,7 +30,7 @@ static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 }; static inline void heartbeat_toggle_bit(struct heartbeat_data *hd, - unsigned bit, unsigned int inverted) + unsigned int bit, unsigned int inverted) { unsigned int new; @@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct heartbeat_data *hd, static void heartbeat_timer(struct timer_list *t) { struct heartbeat_data *hd = from_timer(hd, t, timer); - static unsigned bit = 0, up = 1; + static unsigned int bit = 0, up = 1; heartbeat_toggle_bit(hd, bit, hd->flags & HEARTBEAT_INVERTED);
Fix the following warnings reported by checkpatch: arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> --- arch/sh/drivers/heartbeat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)