| Message ID | 87d1yd7797.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
Hi Morimoto-san, Shimoda-san, On Mon, Aug 24, 2015 at 4:28 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -100,6 +100,16 @@ > renesas,clock-indices = <R8A7795_CLK_SCIF2>; > clock-output-names = "scif2"; > }; > + > + mstp7_clks: mstp7_clks@e615014c { > + compatible = "renesas,r8a7795-mstp-clocks", > + "renesas,cpg-mstp-clocks"; > + reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; > + clocks = <&s3d4_clk>; Shouldn't this be the "s3d2" clock? > + #clock-cells = <1>; > + renesas,clock-indices = <R8A7795_CLK_HSUSB>; > + clock-output-names = "hsusb"; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert-san, > Sent: Monday, August 24, 2015 6:31 PM > > Hi Morimoto-san, Shimoda-san, > > On Mon, Aug 24, 2015 at 4:28 AM, Kuninori Morimoto > <kuninori.morimoto.gx@renesas.com> wrote: > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > @@ -100,6 +100,16 @@ > > renesas,clock-indices = <R8A7795_CLK_SCIF2>; > > clock-output-names = "scif2"; > > }; > > + > > + mstp7_clks: mstp7_clks@e615014c { > > + compatible = "renesas,r8a7795-mstp-clocks", > > + "renesas,cpg-mstp-clocks"; > > + reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; > > + clocks = <&s3d4_clk>; > > Shouldn't this be the "s3d2" clock? Thank you for the point. Yes, this should be the "s3d2" clock. Perhaps Morimoto-san will fix this in v8. Best regards, Yoshihiro Shimoda > > + #clock-cells = <1>; > > + renesas,clock-indices = <R8A7795_CLK_HSUSB>; > > + clock-output-names = "hsusb"; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hello Morimoto-san, Thank you for the patch. On Monday 24 August 2015 02:28:56 Kuninori Morimoto wrote: > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > v5 -> v7 > > - based on Gen3 v7 patch set > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 10 ++++++++++ > include/dt-bindings/clock/r8a7795-clock.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index c3421b3..77cfcea 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > @@ -100,6 +100,16 @@ > renesas,clock-indices = <R8A7795_CLK_SCIF2>; > clock-output-names = "scif2"; > }; > + > + mstp7_clks: mstp7_clks@e615014c { > + compatible = "renesas,r8a7795-mstp-clocks", > + "renesas,cpg-mstp-clocks"; > + reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; > + clocks = <&s3d4_clk>; > + #clock-cells = <1>; > + renesas,clock-indices = <R8A7795_CLK_HSUSB>; You should use the standard clock-indices property instead of the Renesas- specific version. > + clock-output-names = "hsusb"; > + }; > }; > }; > > diff --git a/include/dt-bindings/clock/r8a7795-clock.h > b/include/dt-bindings/clock/r8a7795-clock.h index 27b3a29..ffb0b5b 100644 > --- a/include/dt-bindings/clock/r8a7795-clock.h > +++ b/include/dt-bindings/clock/r8a7795-clock.h > @@ -29,6 +29,7 @@ > /* MSTP5 */ > > /* MSTP7 */ > +#define R8A7795_CLK_HSUSB 4 > > /* MSTP8 */
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index c3421b3..77cfcea 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -100,6 +100,16 @@ renesas,clock-indices = <R8A7795_CLK_SCIF2>; clock-output-names = "scif2"; }; + + mstp7_clks: mstp7_clks@e615014c { + compatible = "renesas,r8a7795-mstp-clocks", + "renesas,cpg-mstp-clocks"; + reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; + clocks = <&s3d4_clk>; + #clock-cells = <1>; + renesas,clock-indices = <R8A7795_CLK_HSUSB>; + clock-output-names = "hsusb"; + }; }; }; diff --git a/include/dt-bindings/clock/r8a7795-clock.h b/include/dt-bindings/clock/r8a7795-clock.h index 27b3a29..ffb0b5b 100644 --- a/include/dt-bindings/clock/r8a7795-clock.h +++ b/include/dt-bindings/clock/r8a7795-clock.h @@ -29,6 +29,7 @@ /* MSTP5 */ /* MSTP7 */ +#define R8A7795_CLK_HSUSB 4 /* MSTP8 */