| Message ID | 87db26af4a30210ab54519b91bb8541e88519185.1694596125.git.ysato@users.sourceforge.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Device Tree support for SH7751 based board | expand |
Hi Sato-san, On Wed, Sep 13, 2023 at 11:24 AM Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> Thanks for your patch! > --- > drivers/pci/controller/Kconfig | 9 +++++++++ > drivers/pci/controller/Makefile | 1 + Please combine this with "[RFC PATCH v2 07/30] drivers/pci: SH7751 PCI Host bridge controller driver.". Gr{oetje,eeting}s, Geert
On Wed, Sep 13, 2023 at 06:23:33PM +0900, Yoshinori Sato wrote: Update subject line and include a commit log. > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > --- > drivers/pci/controller/Kconfig | 9 +++++++++ > drivers/pci/controller/Makefile | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index c0c3f2824990..037ff44bd1e8 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -342,6 +342,15 @@ config PCIE_XILINX_CPM > Say 'Y' here if you want kernel support for the > Xilinx Versal CPM host bridge. > > +config PCI_SH7751 > + bool "Renesas SH7751 PCI controller" > + depends on OF > + depends on CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7751R || COMPILE_TEST > + select PCI_HOST_COMMON > + help > + Say 'Y' here if you want kernel to support the Renesas SH7751 PCI > + Host Bridge driver. Sort this so it appears in alpha order by vendor, device in menuconfig, etc. Since I didn't get the entire series, here are the whitespace errors from git-am: Applying: arch/sh: head_32.S passing FDT address to initialize function. .git/rebase-apply/patch:25: trailing whitespace. Applying: Documentation/devicetree: Add renesas,sh7751-cpg binding document. .git/rebase-apply/patch:66: space before tab in indent. clocks = <&xtal>; Applying: drivers/irqchip: SH7751 IRL external encoder with enable gate. .git/rebase-apply/patch:33: new blank line at EOF.
Hi Sato-san, On Wed, Sep 13, 2023 at 11:24 AM Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -342,6 +342,15 @@ config PCIE_XILINX_CPM > Say 'Y' here if you want kernel support for the > Xilinx Versal CPM host bridge. > > +config PCI_SH7751 > + bool "Renesas SH7751 PCI controller" > + depends on OF > + depends on CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7751R || COMPILE_TEST > + select PCI_HOST_COMMON > + help > + Say 'Y' here if you want kernel to support the Renesas SH7751 PCI > + Host Bridge driver. > + When compile-testing: drivers/pci/controller/pci-sh7751.c: In function ‘sh7751_pci_probe’: drivers/pci/controller/pci-sh7751.c:276:16: error: implicit declaration of function ‘P2SEGADDR’ [-Werror=implicit-function-declaration] 276 | word = P2SEGADDR(wres->start); | ^~~~~~~~~ P2SEGADDR() depends on the SH-specific CONFIG_29BIT. Gr{oetje,eeting}s, Geert
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig index c0c3f2824990..037ff44bd1e8 100644 --- a/drivers/pci/controller/Kconfig +++ b/drivers/pci/controller/Kconfig @@ -342,6 +342,15 @@ config PCIE_XILINX_CPM Say 'Y' here if you want kernel support for the Xilinx Versal CPM host bridge. +config PCI_SH7751 + bool "Renesas SH7751 PCI controller" + depends on OF + depends on CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7751R || COMPILE_TEST + select PCI_HOST_COMMON + help + Say 'Y' here if you want kernel to support the Renesas SH7751 PCI + Host Bridge driver. + source "drivers/pci/controller/cadence/Kconfig" source "drivers/pci/controller/dwc/Kconfig" source "drivers/pci/controller/mobiveil/Kconfig" diff --git a/drivers/pci/controller/Makefile b/drivers/pci/controller/Makefile index 37c8663de7fe..ce96cfe9f1f2 100644 --- a/drivers/pci/controller/Makefile +++ b/drivers/pci/controller/Makefile @@ -39,6 +39,7 @@ obj-$(CONFIG_PCI_LOONGSON) += pci-loongson.o obj-$(CONFIG_PCIE_HISI_ERR) += pcie-hisi-error.o obj-$(CONFIG_PCIE_APPLE) += pcie-apple.o obj-$(CONFIG_PCIE_MT7621) += pcie-mt7621.o +obj-$(CONFIG_PCI_SH7751) += pci-sh7751.o # pcie-hisi.o quirks are needed even without CONFIG_PCIE_DW obj-y += dwc/
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> --- drivers/pci/controller/Kconfig | 9 +++++++++ drivers/pci/controller/Makefile | 1 + 2 files changed, 10 insertions(+)