| Message ID | 87twzvuvl1.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On 14 January 2015 at 03:21, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > tmio_mmc_host_alloc/free were added on tmio_mmc_pio.c, > but, it is missing EXPORT_SYMBOL for it. > Compile will be failed without this patch > > ERROR: "tmio_mmc_host_free" [drivers/mmc/host/tmio_mmc.ko] undefined! > ERROR: "tmio_mmc_host_alloc" [drivers/mmc/host/tmio_mmc.ko] undefined! > ERROR: "tmio_mmc_host_free" [drivers/mmc/host/sh_mobile_sdhi.ko] undefined! > ERROR: "tmio_mmc_host_alloc" [drivers/mmc/host/sh_mobile_sdhi.ko] undefined! > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks! I decided to squashed this change into patch "mmc: tmio: add tmio_mmc_host_alloc/free()", which was the one adding the related functions. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ulf > > tmio_mmc_host_alloc/free were added on tmio_mmc_pio.c, > > but, it is missing EXPORT_SYMBOL for it. > > Compile will be failed without this patch > > > > ERROR: "tmio_mmc_host_free" [drivers/mmc/host/tmio_mmc.ko] undefined! > > ERROR: "tmio_mmc_host_alloc" [drivers/mmc/host/tmio_mmc.ko] undefined! > > ERROR: "tmio_mmc_host_free" [drivers/mmc/host/sh_mobile_sdhi.ko] undefined! > > ERROR: "tmio_mmc_host_alloc" [drivers/mmc/host/sh_mobile_sdhi.ko] undefined! > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Thanks! > > I decided to squashed this change into patch "mmc: tmio: add > tmio_mmc_host_alloc/free()", which was the one adding the related > functions. Thank you good idea :) Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
+ MFD maintainer On 13 January 2015 at 05:56, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > Hi Ulf > > These are v2 of tmio mmc / sh_mobile_sdhi cleanup patches. > v1 patch and in its discuss, we need 3 type of patch-set > 1. header cleanup > 2. sh_mobile_sdhi DMA > 3. DMAEngine cleanup > > These are including 1. header cleanup, and one part of 2. sh_mobile_sdhi DMA. > If these are accepted, I will send 3. DMAEngine cleanup patch to DMAEngine ML, > and, left of 2. sh_mobile_sdhi DMA to MMC ML again. > > 1) - 9) are header cleanup > 10) - 17) are one part of sh_mobile_sdhi DMA > > Kuninori Morimoto (17): > 1) mmc: tmio: add tmio_mmc_host_alloc/free() > 2) mmc: tmio: tmio_mmc_host has .dma > 3) mmc: tmio: tmio_mmc_host has .write16_hook > 4) mmc: tmio: tmio_mmc_host has .clk_enable > 5) mmc: tmio: tmio_mmc_host has .clk_disable > 6) mmc: tmio: tmio_mmc_host has .multi_io_quirk > 7) mmc: tmio: tmio_mmc_host has .bus_shift > 8) mmc: tmio: tmio_mmc_data has .alignment_shift > 9) mmc: tmio: tmio_mmc_data has .dma_rx_offset > 10) mmc: tmio: add .enable_dma on tmio_mmc_data > 11) mmc: tmio: enable SoC specific DMA buswidth settings > 12) mmc: sh_mobile_sdhi: remove .init/.cleanup > 13) mmc: sh_mobile_sdhi: tidyup mmc_data->bus_shift for latest SoC > 14) mmc: sh_mobile_sdhi: add new macro for mmc_host to sh_mobile_sdhi > 15) mmc: sh_mobile_sdhi: use .enable_dma > 16) mmc: sh_mobile_sdhi: enable 32bit DMA access > 17) mmc: remove TMIO_MMC_HAVE_CTL_DMA_REG flag > > drivers/mmc/host/sh_mobile_sdhi.c | 117 ++++++++++++++++++++---------------- > drivers/mmc/host/tmio_mmc.c | 15 +++-- > drivers/mmc/host/tmio_mmc.h | 43 +++++++++---- > drivers/mmc/host/tmio_mmc_dma.c | 38 ++++++------ > drivers/mmc/host/tmio_mmc_pio.c | 59 ++++++++++-------- > include/linux/mfd/tmio.h | 28 +-------- > include/linux/mmc/sh_mobile_sdhi.h | 15 ----- > 7 files changed, 164 insertions(+), 151 deletions(-) > > > Best regards > --- > Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
+ MFD maintainer On 14 January 2015 at 09:30, Ulf Hansson <ulf.hansson@linaro.org> wrote: > On 14 January 2015 at 03:21, Kuninori Morimoto > <kuninori.morimoto.gx@renesas.com> wrote: >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> tmio_mmc_host_alloc/free were added on tmio_mmc_pio.c, >> but, it is missing EXPORT_SYMBOL for it. >> Compile will be failed without this patch >> >> ERROR: "tmio_mmc_host_free" [drivers/mmc/host/tmio_mmc.ko] undefined! >> ERROR: "tmio_mmc_host_alloc" [drivers/mmc/host/tmio_mmc.ko] undefined! >> ERROR: "tmio_mmc_host_free" [drivers/mmc/host/sh_mobile_sdhi.ko] undefined! >> ERROR: "tmio_mmc_host_alloc" [drivers/mmc/host/sh_mobile_sdhi.ko] undefined! >> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Thanks! > > I decided to squashed this change into patch "mmc: tmio: add > tmio_mmc_host_alloc/free()", which was the one adding the related > functions. > > Kind regards > Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index 67c8182..a31c357 100644 --- a/drivers/mmc/host/tmio_mmc_pio.c +++ b/drivers/mmc/host/tmio_mmc_pio.c @@ -1068,6 +1068,7 @@ tmio_mmc_host_alloc(struct platform_device *pdev) return host; } +EXPORT_SYMBOL(tmio_mmc_host_alloc); void tmio_mmc_host_free(struct tmio_mmc_host *host) { @@ -1075,6 +1076,7 @@ void tmio_mmc_host_free(struct tmio_mmc_host *host) host->mmc = NULL; } +EXPORT_SYMBOL(tmio_mmc_host_free); int tmio_mmc_host_probe(struct tmio_mmc_host *_host, struct tmio_mmc_data *pdata)