| Message ID | 87wpz5vaia.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear Morimoto-san, Thanks for your patch. On 6/15/2015 11:54 AM, Kuninori Morimoto wrote: > This patch enables Renesas R-Car Gen3 SoCs in the arm64 defconfig. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > arch/arm64/configs/defconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 866640b..b175c2a 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -34,6 +34,7 @@ CONFIG_MODULE_UNLOAD=y > CONFIG_ARCH_EXYNOS7=y > CONFIG_ARCH_FSL_LS2085A=y > CONFIG_ARCH_MEDIATEK=y > +CONFIG_ARCH_RCAR_GEN3=y > CONFIG_ARCH_SEATTLE=y > CONFIG_ARCH_TEGRA=y > CONFIG_ARCH_TEGRA_132_SOC=y > @@ -102,6 +103,8 @@ CONFIG_SERIAL_8250_CONSOLE=y > CONFIG_SERIAL_8250_MT6577=y > CONFIG_SERIAL_AMBA_PL011=y > CONFIG_SERIAL_AMBA_PL011_CONSOLE=y > +CONFIG_SERIAL_SH_SCI=m I wonder whether we can use built-in module, instead of dynamic module. Is there any strong reason for using dynamic module ? > +CONFIG_SERIAL_SH_SCI_NR_UARTS=6 > CONFIG_SERIAL_MSM=y > CONFIG_SERIAL_MSM_CONSOLE=y > CONFIG_SERIAL_OF_PLATFORM=y >
Hi Khiem-san, On Mon, Jun 15, 2015 at 7:05 PM, khiemnguyen <khiem.nguyen.xt@rvc.renesas.com> wrote: > Dear Morimoto-san, > > Thanks for your patch. > > On 6/15/2015 11:54 AM, Kuninori Morimoto wrote: >> >> This patch enables Renesas R-Car Gen3 SoCs in the arm64 defconfig. >> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> --- >> arch/arm64/configs/defconfig | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index 866640b..b175c2a 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -34,6 +34,7 @@ CONFIG_MODULE_UNLOAD=y >> CONFIG_ARCH_EXYNOS7=y >> CONFIG_ARCH_FSL_LS2085A=y >> CONFIG_ARCH_MEDIATEK=y >> +CONFIG_ARCH_RCAR_GEN3=y >> CONFIG_ARCH_SEATTLE=y >> CONFIG_ARCH_TEGRA=y >> CONFIG_ARCH_TEGRA_132_SOC=y >> @@ -102,6 +103,8 @@ CONFIG_SERIAL_8250_CONSOLE=y >> CONFIG_SERIAL_8250_MT6577=y >> CONFIG_SERIAL_AMBA_PL011=y >> CONFIG_SERIAL_AMBA_PL011_CONSOLE=y >> +CONFIG_SERIAL_SH_SCI=m > > > I wonder whether we can use built-in module, instead of dynamic module. > Is there any strong reason for using dynamic module ? Thanks, I agree with your question. =) Also, what I can tell it seems that the DTS does not include any SCIF nodes, so enabling the SCIF here in the defconfig seems a bit of a mismatch. Best, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Magnus, Khiem-san > >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > >> index 866640b..b175c2a 100644 > >> --- a/arch/arm64/configs/defconfig > >> +++ b/arch/arm64/configs/defconfig > >> @@ -34,6 +34,7 @@ CONFIG_MODULE_UNLOAD=y > >> CONFIG_ARCH_EXYNOS7=y > >> CONFIG_ARCH_FSL_LS2085A=y > >> CONFIG_ARCH_MEDIATEK=y > >> +CONFIG_ARCH_RCAR_GEN3=y > >> CONFIG_ARCH_SEATTLE=y > >> CONFIG_ARCH_TEGRA=y > >> CONFIG_ARCH_TEGRA_132_SOC=y > >> @@ -102,6 +103,8 @@ CONFIG_SERIAL_8250_CONSOLE=y > >> CONFIG_SERIAL_8250_MT6577=y > >> CONFIG_SERIAL_AMBA_PL011=y > >> CONFIG_SERIAL_AMBA_PL011_CONSOLE=y > >> +CONFIG_SERIAL_SH_SCI=m > > > > > > I wonder whether we can use built-in module, instead of dynamic module. > > Is there any strong reason for using dynamic module ? > > Thanks, I agree with your question. =) > > Also, what I can tell it seems that the DTS does not include any SCIF > nodes, so enabling the SCIF here in the defconfig seems a bit of a > mismatch. Ohh my.. =m was my mistake. And the reason why this series doesn't have SCIF is that emulator != real board. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 866640b..b175c2a 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -34,6 +34,7 @@ CONFIG_MODULE_UNLOAD=y CONFIG_ARCH_EXYNOS7=y CONFIG_ARCH_FSL_LS2085A=y CONFIG_ARCH_MEDIATEK=y +CONFIG_ARCH_RCAR_GEN3=y CONFIG_ARCH_SEATTLE=y CONFIG_ARCH_TEGRA=y CONFIG_ARCH_TEGRA_132_SOC=y @@ -102,6 +103,8 @@ CONFIG_SERIAL_8250_CONSOLE=y CONFIG_SERIAL_8250_MT6577=y CONFIG_SERIAL_AMBA_PL011=y CONFIG_SERIAL_AMBA_PL011_CONSOLE=y +CONFIG_SERIAL_SH_SCI=m +CONFIG_SERIAL_SH_SCI_NR_UARTS=6 CONFIG_SERIAL_MSM=y CONFIG_SERIAL_MSM_CONSOLE=y CONFIG_SERIAL_OF_PLATFORM=y
This patch enables Renesas R-Car Gen3 SoCs in the arm64 defconfig. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+)