From patchwork Wed Aug 10 07:54:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 1051902 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7A7t3XI020429 for ; Wed, 10 Aug 2011 07:55:04 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998Ab1HJHyz (ORCPT ); Wed, 10 Aug 2011 03:54:55 -0400 Received: from mail-iy0-f170.google.com ([209.85.210.170]:48192 "EHLO mail-iy0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058Ab1HJHyx convert rfc822-to-8bit (ORCPT ); Wed, 10 Aug 2011 03:54:53 -0400 Received: by iye16 with SMTP id 16so704515iye.1 for ; Wed, 10 Aug 2011 00:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=ratL3BKOuydMn7KRc38/5NYP8dkZ0mytOInGMvl7T6Q=; b=BwcQFNKSOMq1QKgU5lYjIR9Z1GpmlNCmzNyQw4yQ/fbKEGQSi70SbXX5uYkYcsWQbE uv9LqBYjbSgNBGgYvM1PXn7Ug+qdyOQbVescl9Ir9P0pufXw6q6BHtUDNynjNLSg5g3A m0izKcPtQYoMjJqgowxplidz4zReadqwKjyPc= MIME-Version: 1.0 Received: by 10.43.52.136 with SMTP id vm8mr7437550icb.25.1312962892312; Wed, 10 Aug 2011 00:54:52 -0700 (PDT) Received: by 10.231.35.131 with HTTP; Wed, 10 Aug 2011 00:54:52 -0700 (PDT) In-Reply-To: References: <20110809080411.GA1831@n2100.arm.linux.org.uk> Date: Wed, 10 Aug 2011 09:54:52 +0200 Message-ID: Subject: Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations From: Linus Walleij To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sh@vger.kernel.org, linux-tegra@vger.kernel.org, Grant Likely , Nicolas Pitre Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 10 Aug 2011 07:55:04 +0000 (UTC) 2011/8/9 Russell King - ARM Linux : > Consolidate 24 trivial gpiolib implementions out of mach/gpio.h > into asm/gpio.h.  This is basically the include of asm-generic/gpio.h > and the definition of gpio_get_value, gpio_set_value, and gpio_cansleep > as described in Documentation/gpio.txt > > Signed-off-by: Russell King reaks compile of plat-nomadik due to missing u32, feel free to fold in the below fix. With that it's Tested-by: Linus Walleij for Nomadik, U300 and Ux500. From 2e4496fc7643d804ccf50a8efe1a0304210176d1 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Wed, 10 Aug 2011 09:51:16 +0200 Subject: [PATCH] plat-nomadik: small fixup for gpio.h Removing the generic gpio.h broke compilation of the Nomadik GPIO driver since it implicitly got u32 from it. Explicitly include so we get u32 defined. Signed-off-by: Linus Walleij --- arch/arm/plat-nomadik/include/plat/gpio.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-nomadik/include/plat/gpio.h b/arch/arm/plat-nomadik/include/plat/gpio.h index cf0b78b..b894a53 100644 --- a/arch/arm/plat-nomadik/include/plat/gpio.h +++ b/arch/arm/plat-nomadik/include/plat/gpio.h @@ -12,6 +12,8 @@ #ifndef __ASM_PLAT_GPIO_H #define __ASM_PLAT_GPIO_H +#include + /* * "nmk_gpio" and "NMK_GPIO" stand for "Nomadik GPIO", leaving * the "gpio" namespace for generic and cross-machine functions