diff mbox

[v2,04/05] staging: board: Initial board staging support

Message ID CANqRtoQDQLsWOyRSbQmtbmJc_qO=5X3ZMK12ZuwZ-FSR1iWCog@mail.gmail.com (mailing list archive)
State Changes Requested
Headers show

Commit Message

Magnus Damm May 29, 2014, 1:53 p.m. UTC 
On Thu, May 29, 2014 at 10:27 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> Hi Dan,
>
> On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
>> On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
>>> --- /dev/null
>>> +++ work/drivers/staging/board/Kconfig        2014-05-29 21:40:41.000000000 +0900
>>> @@ -0,0 +1,7 @@
>>> +config STAGING_BOARD
>>> +     boolean "Staging Board Support"
>>> +     help
>>> +       Select to enable per-board staging support code.
>>> +
>>> +       If in doubt, say N here.
>>> +
>>
>> Actually, you're probably going to need to add a bunch of dependencies
>> here or it will break "make randconfig" right away.  Sorry that I forgot
>> about this in the first review.
>
> Good point, thanks for checking. I will have a look at this and add
> dependencies to make sure it builds on a wide range of platforms.

To begin with, this hunk fixes the i386_defconfig + staging board build.

Actually, there are not many dependencies - I believe the OF bits is about it.

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Paul Bolle May 29, 2014, 2:03 p.m. UTC | #1 
On Thu, 2014-05-29 at 22:53 +0900, Magnus Damm wrote:
> --- 0011/drivers/staging/board/Kconfig
> +++ work/drivers/staging/board/Kconfig    2014-05-29 22:32:39.000000000 +0900
> @@ -1,5 +1,6 @@
>  config STAGING_BOARD
>      boolean "Staging Board Support"
> +    depends on OF && OF_ADDRESS

I have no idea what this is all about, but wouldn't just OF_ADDRESS be
enough here (as OF_ADDRESS depends on OF)?

>      help
>        Select to enable per-board staging support code.
> 
> Actually, there are not many dependencies - I believe the OF bits is about it.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Magnus Damm May 30, 2014, 6:23 a.m. UTC | #2 
On Thu, May 29, 2014 at 11:03 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Thu, 2014-05-29 at 22:53 +0900, Magnus Damm wrote:
>> --- 0011/drivers/staging/board/Kconfig
>> +++ work/drivers/staging/board/Kconfig    2014-05-29 22:32:39.000000000 +0900
>> @@ -1,5 +1,6 @@
>>  config STAGING_BOARD
>>      boolean "Staging Board Support"
>> +    depends on OF && OF_ADDRESS
>
> I have no idea what this is all about, but wouldn't just OF_ADDRESS be
> enough here (as OF_ADDRESS depends on OF)?

Yeah, that makes sense. I am also considering stubbing in the missing
function prototypes in the header files to be able to get rid of this
dependency.

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- 0011/drivers/staging/board/Kconfig
+++ work/drivers/staging/board/Kconfig    2014-05-29 22:32:39.000000000 +0900
@@ -1,5 +1,6 @@ 
 config STAGING_BOARD
     boolean "Staging Board Support"
+    depends on OF && OF_ADDRESS
     help
       Select to enable per-board staging support code.