From patchwork Thu May 29 13:53:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 4264531 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 242319F333 for ; Thu, 29 May 2014 13:54:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4E7342034A for ; Thu, 29 May 2014 13:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 825522011E for ; Thu, 29 May 2014 13:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933016AbaE2NyA (ORCPT ); Thu, 29 May 2014 09:54:00 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:62301 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932945AbaE2Nx7 (ORCPT ); Thu, 29 May 2014 09:53:59 -0400 Received: by mail-lb0-f181.google.com with SMTP id q8so206241lbi.26 for ; Thu, 29 May 2014 06:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=93VXWACVSyIhogWZAsbXTzlBqIR3dSmtwLxYC8/Lhes=; b=tS/Ngy+TTPkcOPSk2/JA70yQ628Ksco/kbo3scDz4wXcCkR+hZinbkkPDgJ/Pj/N7i IdOV8ZhA8GVO1xac3j0je1W4GKS/X9w7DBukIW3d6ymUsy8aKY4UB9ZtG7e0jHIhUcC1 QDxyOBg9OLqYkzIi6HlgrckP+qIBhUJzkqhCdGYlPQsnDnicrQWnM6BjchBjfVekKuSm IBr7PIz7Ei4LLxPTmQ6+eR4b7zgWCF9kBY4Nu5FCJrJUPS5exL8v997gNpA/A0BW91De FSRvrb7txue7DZN43jfsNQ0P4ZSHcyqANOhJi1lXiK3FLCOuLHdKixGB8RxGO8D6FdHp cvdA== MIME-Version: 1.0 X-Received: by 10.152.20.194 with SMTP id p2mr6342385lae.13.1401371637272; Thu, 29 May 2014 06:53:57 -0700 (PDT) Received: by 10.112.5.104 with HTTP; Thu, 29 May 2014 06:53:57 -0700 (PDT) In-Reply-To: References: <20140529131650.2329.3197.sendpatchset@w520> <20140529131732.2329.50630.sendpatchset@w520> <20140529132034.GB15585@mwanda> Date: Thu, 29 May 2014 22:53:57 +0900 Message-ID: Subject: Re: [PATCH v2 04/05] staging: board: Initial board staging support From: Magnus Damm To: Dan Carpenter Cc: linux-kernel , devel , SH-Linux , Greg KH , "Simon Horman [Horms]" , Geert Uytterhoeven , Laurent Pinchart , Olof Johansson Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, May 29, 2014 at 10:27 PM, Magnus Damm wrote: > Hi Dan, > > On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter > wrote: >> On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote: >>> --- /dev/null >>> +++ work/drivers/staging/board/Kconfig 2014-05-29 21:40:41.000000000 +0900 >>> @@ -0,0 +1,7 @@ >>> +config STAGING_BOARD >>> + boolean "Staging Board Support" >>> + help >>> + Select to enable per-board staging support code. >>> + >>> + If in doubt, say N here. >>> + >> >> Actually, you're probably going to need to add a bunch of dependencies >> here or it will break "make randconfig" right away. Sorry that I forgot >> about this in the first review. > > Good point, thanks for checking. I will have a look at this and add > dependencies to make sure it builds on a wide range of platforms. To begin with, this hunk fixes the i386_defconfig + staging board build. Actually, there are not many dependencies - I believe the OF bits is about it. Cheers, / magnus --- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 0011/drivers/staging/board/Kconfig +++ work/drivers/staging/board/Kconfig 2014-05-29 22:32:39.000000000 +0900 @@ -1,5 +1,6 @@ config STAGING_BOARD boolean "Staging Board Support" + depends on OF && OF_ADDRESS help Select to enable per-board staging support code.