From patchwork Fri May 17 12:22:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 2582501 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 0DBA73FD4E for ; Fri, 17 May 2013 12:22:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755817Ab3EQMW0 (ORCPT ); Fri, 17 May 2013 08:22:26 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:63645 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755748Ab3EQMW0 (ORCPT ); Fri, 17 May 2013 08:22:26 -0400 Received: from axis700.grange (dslb-088-076-018-110.pools.arcor-ip.net [88.76.18.110]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MErMM-1UjMKy2tlC-00FWaO; Fri, 17 May 2013 14:22:22 +0200 Received: by axis700.grange (Postfix, from userid 1000) id 4B5C640BB4; Fri, 17 May 2013 14:22:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by axis700.grange (Postfix) with ESMTP id 4874F40BB3; Fri, 17 May 2013 14:22:22 +0200 (CEST) Date: Fri, 17 May 2013 14:22:22 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Laurent Pinchart cc: linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Linus Walleij , Magnus Damm Subject: Re: [RFC/PATCH 2/2] gpio-rcar: Add DT support In-Reply-To: <1368197317-13169-3-git-send-email-laurent.pinchart@ideasonboard.com> Message-ID: References: <1368197317-13169-1-git-send-email-laurent.pinchart@ideasonboard.com> <1368197317-13169-3-git-send-email-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-Provags-ID: V02:K0:W1ad5bErsuEVJpSU1zlYJbUeQTTf9IyvF7GQJUG9/S1 sfo/5lkS4Rx93Mg/l1IIohR72A9nKnlYMIkIEzr1KsmjqmxnP2 54Nt49gExZIclwU/yyeDANdZAD2WLv/leRmQdbs6TbiIBrRXwN pr85RcgbfoUt2whC6fkQ8MNB/tk8feaMp3M9MrCAX20KHmEXoG BH3+g1X2fjzQvn58kKc9PMeYMpu4ycoH2mzIy2csmey+ty4NRi DP9dwFZXYb8GC8L7qUHCspM9ZvtVSx/L8TgfugR4LKllu/D9pC xe3OSatP/G2XMRI+3BShVFFwcaB4J0OsthC/iMluRT3WXh5Dkc RJI8gr/ueIFHuDXILyn0nNsBSWepZ1bBq1EgO5ZB0pMTZSVlAH F+0MYwhWh7FCg== Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Hi Laurent On Fri, 10 May 2013, Laurent Pinchart wrote: > Add DT bindings for the gpio-rcar driver and read the device > configuration from the DT node at probe time if available. > > Cc: devicetree-discuss@lists.ozlabs.org > Signed-off-by: Laurent Pinchart > --- > .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 48 +++++++++++++++++ > drivers/gpio/gpio-rcar.c | 63 ++++++++++++++++++---- > 2 files changed, 101 insertions(+), 10 deletions(-) > create mode 100644 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt Testing this patch reveals, that (at least) one thing is missing here: Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index a499ea6..e233778 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -342,6 +342,7 @@ static int gpio_rcar_probe(struct platform_device *pdev) gpio_chip->owner = THIS_MODULE; gpio_chip->base = p->config.gpio_base; gpio_chip->ngpio = p->config.number_of_pins; + gpio_chip->dev = &pdev->dev; irq_chip = &p->irq_chip; irq_chip->name = name;