[v5,0/3] mmc: Adding support for Microchip Sparx5 SoC

Message

Lars Povlsen Aug. 25, 2020, 8:13 a.m. UTC

The patch adds eMMC support for Sparx5, by adding a driver for the SoC
SDHCI controller, DT configuration and DT binding documentation.

Changes in v5:
- DT+yaml: Change (mmc|sdhci)@600800000 to mmc0@600800000
- Add missing "static" attribute to probe function
- Drop MMC_SDHCI_IO_ACCESSORS, as it is not required (anymore)

Changes in v4:
- Disable clock if sdhci_add_host() fails
- Remove dev_err if sdhci_add_host() fails

Changes in v3:
- Add dt-bindings for property "microchip,clock-delay"
- Enforce "microchip,clock-delay" valid range in driver
- Removed a noisy pr_debug() in sdhci_sparx5_adma_write_desc()

Changes in v2:
- Changes in driver as per review comments
 - Drop debug code
 - Drop sysfs code
 - use usleep_range()
 - use mmc_hostname() in pr_debug()
 - Remove deactivated code
 - Minor cosmetics

Lars Povlsen (3):
  dt-bindings: mmc: Add Sparx5 SDHCI controller bindings
  sdhci: sparx5: Add Sparx5 SoC eMMC driver
  arm64: dts: sparx5: Add Sparx5 eMMC support

 .../mmc/microchip,dw-sparx5-sdhci.yaml        |  65 +++++
 arch/arm64/boot/dts/microchip/sparx5.dtsi     |  24 ++
 .../boot/dts/microchip/sparx5_pcb125.dts      |  23 ++
 .../boot/dts/microchip/sparx5_pcb134_emmc.dts |  23 ++
 .../boot/dts/microchip/sparx5_pcb135_emmc.dts |  23 ++
 drivers/mmc/host/Kconfig                      |  12 +
 drivers/mmc/host/Makefile                     |   1 +
 drivers/mmc/host/sdhci-of-sparx5.c            | 269 ++++++++++++++++++
 8 files changed, 440 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml
 create mode 100644 drivers/mmc/host/sdhci-of-sparx5.c

Comments

Ulf Hansson Aug. 25, 2020, 9:38 a.m. UTC | #1

On Tue, 25 Aug 2020 at 10:14, Lars Povlsen <[e-mail]> wrote:
>
> The patch adds eMMC support for Sparx5, by adding a driver for the SoC
> SDHCI controller, DT configuration and DT binding documentation.
>
> Changes in v5:
> - DT+yaml: Change (mmc|sdhci)@600800000 to mmc0@600800000
> - Add missing "static" attribute to probe function
> - Drop MMC_SDHCI_IO_ACCESSORS, as it is not required (anymore)
>
> Changes in v4:
> - Disable clock if sdhci_add_host() fails
> - Remove dev_err if sdhci_add_host() fails
>
> Changes in v3:
> - Add dt-bindings for property "microchip,clock-delay"
> - Enforce "microchip,clock-delay" valid range in driver
> - Removed a noisy pr_debug() in sdhci_sparx5_adma_write_desc()
>
> Changes in v2:
> - Changes in driver as per review comments
>  - Drop debug code
>  - Drop sysfs code
>  - use usleep_range()
>  - use mmc_hostname() in pr_debug()
>  - Remove deactivated code
>  - Minor cosmetics
>
> Lars Povlsen (3):
>   dt-bindings: mmc: Add Sparx5 SDHCI controller bindings
>   sdhci: sparx5: Add Sparx5 SoC eMMC driver
>   arm64: dts: sparx5: Add Sparx5 eMMC support
>
>  .../mmc/microchip,dw-sparx5-sdhci.yaml        |  65 +++++
>  arch/arm64/boot/dts/microchip/sparx5.dtsi     |  24 ++
>  .../boot/dts/microchip/sparx5_pcb125.dts      |  23 ++
>  .../boot/dts/microchip/sparx5_pcb134_emmc.dts |  23 ++
>  .../boot/dts/microchip/sparx5_pcb135_emmc.dts |  23 ++
>  drivers/mmc/host/Kconfig                      |  12 +
>  drivers/mmc/host/Makefile                     |   1 +
>  drivers/mmc/host/sdhci-of-sparx5.c            | 269 ++++++++++++++++++
>  8 files changed, 440 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml
>  create mode 100644 drivers/mmc/host/sdhci-of-sparx5.c
>

For some reason, patchwork doesn't seem to accept your patches. Can
you please have a look to figure it out, at least until next time.

In this case, I picked them from the emails, so patch 1 and patch2
applied for next, thanks!

Kind regards
Uffe