| Message ID | 20230331-topic-oxnas-upstream-remove-v1-0-5bd58fd1dd1f@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: oxnas support removal | expand |
On Fri, Mar 31, 2023 at 10:34 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > With [1] removing MPCore SMP support, this makes the OX820 barely usable, > associated with a clear lack of maintainance, development and migration to > dt-schema it's clear that Linux support for OX810 and OX820 should be removed. > > In addition, the OX810 hasn't been booted for years and isn't even present > in an ARM config file. > > For the OX820, lack of USB and SATA support makes the platform not usable > in the current Linux support and relies on off-tree drivers hacked from the > vendor (defunct for years) sources. > > The last users are in the OpenWRT distribution, and today's removal means > support will still be in stable 6.1 LTS kernel until end of 2026. > > If someone wants to take over the development even with lack of SMP, I'll > be happy to hand off maintainance. > > The plan is to apply the first 4 patches first, then the drivers > followed by bindings. Finally the MAINTAINANCE entry can be removed. > > I'm not sure about the process of bindings removal, but perhaps the bindings > should be marked as deprecated first then removed later on ? > > It has been a fun time adding support for this architecture, but it's time > to get over! > > Patch 2 obviously depends on [1]. > > [1] https://lore.kernel.org/all/20230327121317.4081816-1-arnd@kernel.org/ > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, Mar 31, 2023, at 10:34, Neil Armstrong wrote: > With [1] removing MPCore SMP support, this makes the OX820 barely usable, > associated with a clear lack of maintainance, development and migration to > dt-schema it's clear that Linux support for OX810 and OX820 should be removed. > > In addition, the OX810 hasn't been booted for years and isn't even present > in an ARM config file. > > For the OX820, lack of USB and SATA support makes the platform not usable > in the current Linux support and relies on off-tree drivers hacked from the > vendor (defunct for years) sources. > > The last users are in the OpenWRT distribution, and today's removal means > support will still be in stable 6.1 LTS kernel until end of 2026. > > If someone wants to take over the development even with lack of SMP, I'll > be happy to hand off maintainance. > > The plan is to apply the first 4 patches first, then the drivers > followed by bindings. Finally the MAINTAINANCE entry can be removed. > > I'm not sure about the process of bindings removal, but perhaps the bindings > should be marked as deprecated first then removed later on ? > > It has been a fun time adding support for this architecture, but it's time > to get over! > > Patch 2 obviously depends on [1]. > > [1] https://lore.kernel.org/all/20230327121317.4081816-1-arnd@kernel.org/ > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Thanks a lot for going through this and preparing the patches! I've discussed this with Daniel Golle on the OpenWRT channel as well, and he indicated that the timing is probably fine here, as there are already close to zero downloads for oxnas builds, and the 6.1 kernel will only be part of a release in 2024. For the dependency on my other patch, I'd suggest you instead remove the SMP files here as well, which means we can merge either part independently based on just 6.3-rc. I can do that change myself by picking up patches 1-4 of your RFC series, or maybe you can send resend them after rebase to 6.3-rc1. For the driver removals, I think we can merge those at the same time as the platform removal since there are no shared header files that would cause build time regressions and there are no runtime regressions other than breaking the platform itself. Maybe just send the driver removal separately to the subsystem maintainers with my Acked-by: Arnd Bergmann <arnd@arndb.de> Arnd
On Fri, Mar 31, 2023 at 03:42:15PM +0200, Arnd Bergmann wrote: > On Fri, Mar 31, 2023, at 10:34, Neil Armstrong wrote: > > With [1] removing MPCore SMP support, this makes the OX820 barely usable, > > associated with a clear lack of maintainance, development and migration to > > dt-schema it's clear that Linux support for OX810 and OX820 should be removed. > > > > In addition, the OX810 hasn't been booted for years and isn't even present > > in an ARM config file. > > > > For the OX820, lack of USB and SATA support makes the platform not usable > > in the current Linux support and relies on off-tree drivers hacked from the > > vendor (defunct for years) sources. > > > > The last users are in the OpenWRT distribution, and today's removal means > > support will still be in stable 6.1 LTS kernel until end of 2026. > > > > If someone wants to take over the development even with lack of SMP, I'll > > be happy to hand off maintainance. > > > > The plan is to apply the first 4 patches first, then the drivers > > followed by bindings. Finally the MAINTAINANCE entry can be removed. > > > > I'm not sure about the process of bindings removal, but perhaps the bindings > > should be marked as deprecated first then removed later on ? > > > > It has been a fun time adding support for this architecture, but it's time > > to get over! > > > > Patch 2 obviously depends on [1]. > > > > [1] https://lore.kernel.org/all/20230327121317.4081816-1-arnd@kernel.org/ > > > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > Thanks a lot for going through this and preparing the patches! > > I've discussed this with Daniel Golle on the OpenWRT channel as well, > and he indicated that the timing is probably fine here, as there are > already close to zero downloads for oxnas builds, and the 6.1 kernel > will only be part of a release in 2024. > > For the dependency on my other patch, I'd suggest you instead > remove the SMP files here as well, which means we can merge either > part independently based on just 6.3-rc. I can do that change > myself by picking up patches 1-4 of your RFC series, or maybe you > can send resend them after rebase to 6.3-rc1. > > For the driver removals, I think we can merge those at the same > time as the platform removal since there are no shared header files > that would cause build time regressions and there are no runtime > regressions other than breaking the platform itself. Maybe > just send the driver removal separately to the subsystem > maintainers with my > > Acked-by: Arnd Bergmann <arnd@arndb.de> Sounds reasonable, so also Acked-by: Daniel Golle <daniel@makrotopia.org> (but I am a bit sad about it anyway. without SMP it doesn't make sense to keep ox820 though)
On 31/03/2023 15:42, Arnd Bergmann wrote: > On Fri, Mar 31, 2023, at 10:34, Neil Armstrong wrote: >> With [1] removing MPCore SMP support, this makes the OX820 barely usable, >> associated with a clear lack of maintainance, development and migration to >> dt-schema it's clear that Linux support for OX810 and OX820 should be removed. >> >> In addition, the OX810 hasn't been booted for years and isn't even present >> in an ARM config file. >> >> For the OX820, lack of USB and SATA support makes the platform not usable >> in the current Linux support and relies on off-tree drivers hacked from the >> vendor (defunct for years) sources. >> >> The last users are in the OpenWRT distribution, and today's removal means >> support will still be in stable 6.1 LTS kernel until end of 2026. >> >> If someone wants to take over the development even with lack of SMP, I'll >> be happy to hand off maintainance. >> >> The plan is to apply the first 4 patches first, then the drivers >> followed by bindings. Finally the MAINTAINANCE entry can be removed. >> >> I'm not sure about the process of bindings removal, but perhaps the bindings >> should be marked as deprecated first then removed later on ? >> >> It has been a fun time adding support for this architecture, but it's time >> to get over! >> >> Patch 2 obviously depends on [1]. >> >> [1] https://lore.kernel.org/all/20230327121317.4081816-1-arnd@kernel.org/ >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > Thanks a lot for going through this and preparing the patches! > > I've discussed this with Daniel Golle on the OpenWRT channel as well, > and he indicated that the timing is probably fine here, as there are > already close to zero downloads for oxnas builds, and the 6.1 kernel > will only be part of a release in 2024. > > For the dependency on my other patch, I'd suggest you instead > remove the SMP files here as well, which means we can merge either > part independently based on just 6.3-rc. I can do that change > myself by picking up patches 1-4 of your RFC series, or maybe you > can send resend them after rebase to 6.3-rc1. Ack I'll send patches 1-4 rebased on v6.3-rc1 with the acks and sent a PR next week. > > For the driver removals, I think we can merge those at the same > time as the platform removal since there are no shared header files > that would cause build time regressions and there are no runtime > regressions other than breaking the platform itself. Maybe > just send the driver removal separately to the subsystem > maintainers with my > > Acked-by: Arnd Bergmann <arnd@arndb.de> Thanks, I'll submit those individually once the first patches are merged. Neil > > Arnd
Hi Daniel, On 31/03/2023 15:50, Daniel Golle wrote: > On Fri, Mar 31, 2023 at 03:42:15PM +0200, Arnd Bergmann wrote: >> On Fri, Mar 31, 2023, at 10:34, Neil Armstrong wrote: >>> With [1] removing MPCore SMP support, this makes the OX820 barely usable, >>> associated with a clear lack of maintainance, development and migration to >>> dt-schema it's clear that Linux support for OX810 and OX820 should be removed. >>> >>> In addition, the OX810 hasn't been booted for years and isn't even present >>> in an ARM config file. >>> >>> For the OX820, lack of USB and SATA support makes the platform not usable >>> in the current Linux support and relies on off-tree drivers hacked from the >>> vendor (defunct for years) sources. >>> >>> The last users are in the OpenWRT distribution, and today's removal means >>> support will still be in stable 6.1 LTS kernel until end of 2026. >>> >>> If someone wants to take over the development even with lack of SMP, I'll >>> be happy to hand off maintainance. >>> >>> The plan is to apply the first 4 patches first, then the drivers >>> followed by bindings. Finally the MAINTAINANCE entry can be removed. >>> >>> I'm not sure about the process of bindings removal, but perhaps the bindings >>> should be marked as deprecated first then removed later on ? >>> >>> It has been a fun time adding support for this architecture, but it's time >>> to get over! >>> >>> Patch 2 obviously depends on [1]. >>> >>> [1] https://lore.kernel.org/all/20230327121317.4081816-1-arnd@kernel.org/ >>> >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> >> Thanks a lot for going through this and preparing the patches! >> >> I've discussed this with Daniel Golle on the OpenWRT channel as well, >> and he indicated that the timing is probably fine here, as there are >> already close to zero downloads for oxnas builds, and the 6.1 kernel >> will only be part of a release in 2024. >> >> For the dependency on my other patch, I'd suggest you instead >> remove the SMP files here as well, which means we can merge either >> part independently based on just 6.3-rc. I can do that change >> myself by picking up patches 1-4 of your RFC series, or maybe you >> can send resend them after rebase to 6.3-rc1. >> >> For the driver removals, I think we can merge those at the same >> time as the platform removal since there are no shared header files >> that would cause build time regressions and there are no runtime >> regressions other than breaking the platform itself. Maybe >> just send the driver removal separately to the subsystem >> maintainers with my >> >> Acked-by: Arnd Bergmann <arnd@arndb.de> > > Sounds reasonable, so also > > Acked-by: Daniel Golle <daniel@makrotopia.org> > > (but I am a bit sad about it anyway. without SMP it doesn't make sense > to keep ox820 though) Same ! I would have loved to see the full support mainline, but the platform is old and apart you nobody were interested in working on this. Thanks a lot for you work keeping Oxnas support alive! Neil
With [1] removing MPCore SMP support, this makes the OX820 barely usable, associated with a clear lack of maintainance, development and migration to dt-schema it's clear that Linux support for OX810 and OX820 should be removed. In addition, the OX810 hasn't been booted for years and isn't even present in an ARM config file. For the OX820, lack of USB and SATA support makes the platform not usable in the current Linux support and relies on off-tree drivers hacked from the vendor (defunct for years) sources. The last users are in the OpenWRT distribution, and today's removal means support will still be in stable 6.1 LTS kernel until end of 2026. If someone wants to take over the development even with lack of SMP, I'll be happy to hand off maintainance. The plan is to apply the first 4 patches first, then the drivers followed by bindings. Finally the MAINTAINANCE entry can be removed. I'm not sure about the process of bindings removal, but perhaps the bindings should be marked as deprecated first then removed later on ? It has been a fun time adding support for this architecture, but it's time to get over! Patch 2 obviously depends on [1]. [1] https://lore.kernel.org/all/20230327121317.4081816-1-arnd@kernel.org/ Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Neil Armstrong (20): ARM: dts: oxnas: remove obsolete device tree files ARM: oxnas: remove OXNAS support ARM: configs: remove oxnas_v6_defconfig dt-bindings: arm: oxnas: remove obsolete bindings clk: oxnas: remove obsolete clock driver dt-bindings: clk: oxnas: remove obsolete bindings clksource: timer-oxnas-rps: remove obsolete timer driver dt-bindings: timer: oxsemi,rps-timer: remove obsolete bindings nand: oxnas_nand: remove obsolete raw nand driver dt-bindings: mtd: oxnas-nand: remove obsolete bindings net: stmmac: dwmac-oxnas: remove obsolete dwmac glue driver dt-bindings: net: oxnas-dwmac: remove obsolete bindings pinctrl: pinctrl-oxnas: remove obsolete pinctrl driver dt-bindings: pinctrl: oxnas,pinctrl: remove obsolete bindings dt-bindings: gpio: gpio_oxnas: remove obsolete bindings power: reset: oxnas-restart: remove obsolete restart driver reset: oxnas: remove obsolete reset driver irqchip: irq-versatile-fpga: remove obsolete oxnas compatible dt-bindings: interrupt-controller: arm,versatile-fpga-irq: mark oxnas compatible as deprecated MAINTAINERS: remove OXNAS entry Documentation/devicetree/bindings/arm/oxnas.txt | 14 - .../devicetree/bindings/clock/oxnas,stdclk.txt | 28 - .../devicetree/bindings/gpio/gpio_oxnas.txt | 47 - .../arm,versatile-fpga-irq.txt | 4 +- .../devicetree/bindings/mtd/oxnas-nand.txt | 41 - .../devicetree/bindings/net/oxnas-dwmac.txt | 41 - .../devicetree/bindings/pinctrl/oxnas,pinctrl.txt | 56 - .../devicetree/bindings/reset/oxnas,reset.txt | 32 - .../devicetree/bindings/timer/oxsemi,rps-timer.txt | 17 - MAINTAINERS | 10 - arch/arm/Makefile | 1 - arch/arm/boot/dts/Makefile | 3 - arch/arm/boot/dts/ox810se-wd-mbwe.dts | 115 -- arch/arm/boot/dts/ox810se.dtsi | 357 ------ .../dts/ox820-cloudengines-pogoplug-series-3.dts | 93 -- arch/arm/boot/dts/ox820.dtsi | 299 ----- arch/arm/configs/oxnas_v6_defconfig | 92 -- arch/arm/mach-oxnas/Kconfig | 34 - arch/arm/mach-oxnas/Makefile | 1 - drivers/clk/Kconfig | 7 - drivers/clk/Makefile | 1 - drivers/clk/clk-oxnas.c | 251 ---- drivers/clocksource/Kconfig | 7 - drivers/clocksource/Makefile | 1 - drivers/clocksource/timer-oxnas-rps.c | 288 ----- drivers/irqchip/irq-versatile-fpga.c | 1 - drivers/mtd/nand/raw/Kconfig | 7 - drivers/mtd/nand/raw/Makefile | 1 - drivers/mtd/nand/raw/oxnas_nand.c | 211 ---- drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 - drivers/net/ethernet/stmicro/stmmac/Makefile | 1 - drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c | 245 ---- drivers/pinctrl/Kconfig | 11 - drivers/pinctrl/Makefile | 1 - drivers/pinctrl/pinctrl-oxnas.c | 1292 -------------------- drivers/power/reset/Kconfig | 7 - drivers/power/reset/Makefile | 1 - drivers/power/reset/oxnas-restart.c | 233 ---- drivers/reset/Kconfig | 3 - drivers/reset/Makefile | 1 - drivers/reset/reset-oxnas.c | 114 -- 41 files changed, 3 insertions(+), 3977 deletions(-) --- base-commit: df45499b419b31c4d44ef9f1d1656d1fc0897014 change-id: 20230331-topic-oxnas-upstream-remove-a62e9d96feee Best regards,