| Message ID | 20191210195202.622734-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7afec66e2bf5683d8bfc812cc295313d1b8473bc |
| Headers | show |
| Series | ARM: davinci: select CONFIG_RESET_CONTROLLER | expand |
wt., 10 gru 2019 o 20:52 Arnd Bergmann <arnd@arndb.de> napisał(a): > > Selecting RESET_CONTROLLER is actually required, otherwise we > can get a link failure in the clock driver: > > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks': > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register' > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init': > psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup' > > Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5") > Cc: <stable@vger.kernel.org> # v5.4 > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-davinci/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1102): https://linux.kernel.org/g/patchwork-soc/message/1102 Mute This Topic: https://linux.kernel.org/mt/69534225/1554929 Group Owner: patchwork-soc+owner@linux.kernel.org Unsubscribe: https://linux.kernel.org/g/patchwork-soc/unsub [patchwork-linux-kernel-org@patchwork.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, 2019-12-11 at 10:14 +0100, Bartosz Golaszewski wrote: > wt., 10 gru 2019 o 20:52 Arnd Bergmann <arnd@arndb.de> napisał(a): > > Selecting RESET_CONTROLLER is actually required, otherwise we > > can get a link failure in the clock driver: > > > > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks': > > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register' > > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init': > > psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup' > > > > Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5") > > Cc: <stable@vger.kernel.org> # v5.4 > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > arch/arm/mach-davinci/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1098): https://linux.kernel.org/g/patchwork-soc/message/1098 Mute This Topic: https://linux.kernel.org/mt/69534225/1554929 Group Owner: patchwork-soc+owner@linux.kernel.org Unsubscribe: https://linux.kernel.org/g/patchwork-soc/unsub [patchwork-linux-kernel-org@patchwork.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Arnd, On 11/12/19 1:21 AM, Arnd Bergmann wrote: > Selecting RESET_CONTROLLER is actually required, otherwise we > can get a link failure in the clock driver: > > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks': > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register' > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init': > psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup' > > Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5") > Cc: <stable@vger.kernel.org> # v5.4 > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Assuming you are going to apply directly to ARM-SoC, Acked-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar > --- > arch/arm/mach-davinci/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig > index dd427bd2768c..02b180ad7245 100644 > --- a/arch/arm/mach-davinci/Kconfig > +++ b/arch/arm/mach-davinci/Kconfig > @@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI > select PM_GENERIC_DOMAINS if PM > select PM_GENERIC_DOMAINS_OF if PM && OF > select REGMAP_MMIO > + select RESET_CONTROLLER > select HAVE_IDE > select PINCTRL_SINGLE > > -- > 2.20.0 >
Hello: This patch was applied to soc/soc.git (refs/heads/arm/fixes). On Tue, 10 Dec 2019 20:51:44 +0100 you wrote: > Selecting RESET_CONTROLLER is actually required, otherwise we > can get a link failure in the clock driver: > > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks': > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register' > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init': > psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup' > > [...] Here is a summary with links: - ARM: davinci: select CONFIG_RESET_CONTROLLER https://git.kernel.org/soc/soc/c/7afec66e2bf5683d8bfc812cc295313d1b8473bc You are awesome, thank you!
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig index dd427bd2768c..02b180ad7245 100644 --- a/arch/arm/mach-davinci/Kconfig +++ b/arch/arm/mach-davinci/Kconfig @@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI select PM_GENERIC_DOMAINS if PM select PM_GENERIC_DOMAINS_OF if PM && OF select REGMAP_MMIO + select RESET_CONTROLLER select HAVE_IDE select PINCTRL_SINGLE
Selecting RESET_CONTROLLER is actually required, otherwise we can get a link failure in the clock driver: drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks': psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register' drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init': psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup' Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5") Cc: <stable@vger.kernel.org> # v5.4 Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-davinci/Kconfig | 1 + 1 file changed, 1 insertion(+)