| Message ID | 20200527221327.3339232-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1f46d85ffa75ddf0403387eb731c73cd3e713f43 |
| Headers | show |
| Series | staging: tegra-video: fix V4L2 dependency | expand |
Hello: This patch was applied to soc/soc.git (refs/heads/for-next). On Thu, 28 May 2020 00:13:06 +0200 you wrote: > Rather than using a dependency on VIDEO_V4L2, this driver uses > "select", which fails when other dependencies are missing: > > WARNING: unmet direct dependencies detected for VIDEO_V4L2 > Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n] > Selected by [y]: > - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y] > (plus an endless stream of link errors for other drivers that > depend on VIDEO_V4L2 but are now lacking their dependencies) > > [...] Here is a summary with links: - staging: tegra-video: fix V4L2 dependency https://git.kernel.org/soc/soc/c/1f46d85ffa75ddf0403387eb731c73cd3e713f43 You are awesome, thank you!
On 5/27/20 3:13 PM, Arnd Bergmann wrote: > Rather than using a dependency on VIDEO_V4L2, this driver uses > "select", which fails when other dependencies are missing: > > WARNING: unmet direct dependencies detected for VIDEO_V4L2 > Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n] > Selected by [y]: > - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y] > (plus an endless stream of link errors for other drivers that > depend on VIDEO_V4L2 but are now lacking their dependencies) > > Fixes: 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/staging/media/tegra-video/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig > index 3f03b5b39e6c..f6c61ec74386 100644 > --- a/drivers/staging/media/tegra-video/Kconfig > +++ b/drivers/staging/media/tegra-video/Kconfig > @@ -2,7 +2,7 @@ > config VIDEO_TEGRA > tristate "NVIDIA Tegra VI driver" > depends on TEGRA_HOST1X > - select VIDEO_V4L2 > + depends on VIDEO_V4L2 > select MEDIA_CONTROLLER > select VIDEOBUF2_DMA_CONTIG > help Acked-by: Sowjanya Komatineni <skomatineni@nvidia.com>
diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig index 3f03b5b39e6c..f6c61ec74386 100644 --- a/drivers/staging/media/tegra-video/Kconfig +++ b/drivers/staging/media/tegra-video/Kconfig @@ -2,7 +2,7 @@ config VIDEO_TEGRA tristate "NVIDIA Tegra VI driver" depends on TEGRA_HOST1X - select VIDEO_V4L2 + depends on VIDEO_V4L2 select MEDIA_CONTROLLER select VIDEOBUF2_DMA_CONTIG help
Rather than using a dependency on VIDEO_V4L2, this driver uses "select", which fails when other dependencies are missing: WARNING: unmet direct dependencies detected for VIDEO_V4L2 Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n] Selected by [y]: - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y] (plus an endless stream of link errors for other drivers that depend on VIDEO_V4L2 but are now lacking their dependencies) Fixes: 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/media/tegra-video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)