diff mbox series

ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS

Message ID 20201203231847.1484900-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 9280f726097b436c8c907825131cd346d7eb0c0f
Headers show
Series ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS | expand

Commit Message

Arnd Bergmann Dec. 3, 2020, 11:18 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

These definitions are evidently left over from the days when
sparsemem settings were platform specific. This was no longer
the case when the platform got merged.

There was no warning in the past, but now the asm/sparsemem.h
header ends up being included indirectly, causing this warning:

In file included from /git/arm-soc/arch/arm/mach-keystone/keystone.c:24:
arch/arm/mach-keystone/memory.h:10:9: warning: 'SECTION_SIZE_BITS' macro redefined [-Wmacro-redefined]
 #define SECTION_SIZE_BITS       34
        ^
arch/arm/include/asm/sparsemem.h:23:9: note: previous definition is here
 #define SECTION_SIZE_BITS       28
        ^

Clearly the definitions never had any effect here, so remove them.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-keystone/memory.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Santosh Shilimkar Dec. 4, 2020, 1:57 a.m. UTC | #1 
On 12/3/20 3:18 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> These definitions are evidently left over from the days when
> sparsemem settings were platform specific. This was no longer
> the case when the platform got merged.
> 
> There was no warning in the past, but now the asm/sparsemem.h
> header ends up being included indirectly, causing this warning:
> 
> In file included from /git/arm-soc/arch/arm/mach-keystone/keystone.c:24:
> arch/arm/mach-keystone/memory.h:10:9: warning: 'SECTION_SIZE_BITS' macro redefined [-Wmacro-redefined]
>   #define SECTION_SIZE_BITS       34
>          ^
> arch/arm/include/asm/sparsemem.h:23:9: note: previous definition is here
>   #define SECTION_SIZE_BITS       28
>          ^
> 
> Clearly the definitions never had any effect here, so remove them.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Arnd Bergmann Dec. 8, 2020, 4:11 p.m. UTC | #2 
From: Arnd Bergmann <arnd@arndb.de>

On Fri, 4 Dec 2020 00:18:40 +0100, Arnd Bergmann wrote:
> These definitions are evidently left over from the days when
> sparsemem settings were platform specific. This was no longer
> the case when the platform got merged.
> 
> There was no warning in the past, but now the asm/sparsemem.h
> header ends up being included indirectly, causing this warning:
> 
> [...]

Applied to arm/fixes, thanks!

[1/1] ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS
      commit: 9280f726097b436c8c907825131cd346d7eb0c0f

       Arnd
patchwork-bot+linux-soc@kernel.org Dec. 8, 2020, 5:10 p.m. UTC | #3 
Hello:

This patch was applied to soc/soc.git (refs/heads/arm/fixes):

On Fri,  4 Dec 2020 00:18:40 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> These definitions are evidently left over from the days when
> sparsemem settings were platform specific. This was no longer
> the case when the platform got merged.
> 
> There was no warning in the past, but now the asm/sparsemem.h
> header ends up being included indirectly, causing this warning:
> 
> [...]

Here is the summary with links:
  - ARM: keystone: remove SECTION_SIZE_BITS/MAX_PHYSMEM_BITS
    https://git.kernel.org/soc/soc/c/9280f726097b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/arch/arm/mach-keystone/memory.h b/arch/arm/mach-keystone/memory.h
index 9147565d0581..1b9ed1271e05 100644
--- a/arch/arm/mach-keystone/memory.h
+++ b/arch/arm/mach-keystone/memory.h
@@ -6,9 +6,6 @@ 
 #ifndef __MEMORY_H
 #define __MEMORY_H
 
-#define MAX_PHYSMEM_BITS	36
-#define SECTION_SIZE_BITS	34
-
 #define KEYSTONE_LOW_PHYS_START		0x80000000ULL
 #define KEYSTONE_LOW_PHYS_SIZE		0x80000000ULL /* 2G */
 #define KEYSTONE_LOW_PHYS_END		(KEYSTONE_LOW_PHYS_START + \