| Message ID | 20201230152010.3914962-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bac717171971176b78c72d15a8b6961764ab197f |
| Headers | show |
| Series | ARM: picoxcell: fix missing interrupt-parent properties | expand |
Hi Arnd, On Wed, Dec 30, 2020 at 04:20:05PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > dtc points out that the interrupts for some devices are not parsable: > > picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent > > There are two VIC instances, so it's not clear which one needs to be > used. I found the BSP sources that reference VIC0, so use that: > > https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Rob has a series to remove Picoxcell as there's no active development on this anymore and Intel have stopped producing the chips. Thanks, Jamie
On Thu, Dec 31, 2020 at 1:49 PM Jamie Iles <jamie@jamieiles.com> wrote: > > Hi Arnd, > > On Wed, Dec 30, 2020 at 04:20:05PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > dtc points out that the interrupts for some devices are not parsable: > > > > picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent > > picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent > > picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent > > picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent > > > > There are two VIC instances, so it's not clear which one needs to be > > used. I found the BSP sources that reference VIC0, so use that: > > > > https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Rob has a series to remove Picoxcell as there's no active development on > this anymore and Intel have stopped producing the chips. Right, I am aware of Rob's series. My patch was a little older but I only got around to submitting it now. I'd still like to merge it as a bugfix for v5.11 though and have it backported to avoid the warnings with new dtc on stable kernels, while doing the platform removal for v5.12. Arnd
On Wed, Dec 30, 2020 at 04:20:05PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > dtc points out that the interrupts for some devices are not parsable: > > picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent > > There are two VIC instances, so it's not clear which one needs to be > used. I found the BSP sources that reference VIC0, so use that: > > https://github.com/r1mikey/meta-picoxcell/blob/master/recipes-kernel/linux/linux-picochip-3.0/0001-picoxcell-support-for-Picochip-picoXcell-SoC.patch > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Jamie Iles <jamie@jamieiles.com> Thanks Arnd! Jamie
Hello: This patch was applied to soc/soc.git (refs/heads/arm/fixes): On Wed, 30 Dec 2020 16:20:05 +0100 you wrote: > From: Arnd Bergmann <arnd@arndb.de> > > dtc points out that the interrupts for some devices are not parsable: > > picoxcell-pc3x2.dtsi:45.19-49.5: Warning (interrupts_property): /paxi/gem@30000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:51.21-55.5: Warning (interrupts_property): /paxi/dmac@40000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:57.21-61.5: Warning (interrupts_property): /paxi/dmac@50000: Missing interrupt-parent > picoxcell-pc3x2.dtsi:233.21-237.5: Warning (interrupts_property): /rwid-axi/axi2pico@c0000000: Missing interrupt-parent > > [...] Here is the summary with links: - ARM: picoxcell: fix missing interrupt-parent properties https://git.kernel.org/soc/soc/c/bac717171971 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm/boot/dts/picoxcell-pc3x2.dtsi b/arch/arm/boot/dts/picoxcell-pc3x2.dtsi index c4c6c7e9e37b..5898879a3038 100644 --- a/arch/arm/boot/dts/picoxcell-pc3x2.dtsi +++ b/arch/arm/boot/dts/picoxcell-pc3x2.dtsi @@ -45,18 +45,21 @@ paxi { emac: gem@30000 { compatible = "cadence,gem"; reg = <0x30000 0x10000>; + interrupt-parent = <&vic0>; interrupts = <31>; }; dmac1: dmac@40000 { compatible = "snps,dw-dmac"; reg = <0x40000 0x10000>; + interrupt-parent = <&vic0>; interrupts = <25>; }; dmac2: dmac@50000 { compatible = "snps,dw-dmac"; reg = <0x50000 0x10000>; + interrupt-parent = <&vic0>; interrupts = <26>; }; @@ -233,6 +236,7 @@ ebi@50000000 { axi2pico@c0000000 { compatible = "picochip,axi2pico-pc3x2"; reg = <0xc0000000 0x10000>; + interrupt-parent = <&vic0>; interrupts = <13 14 15 16 17 18 19 20 21>; }; };