diff mbox series

bus: arm-integrator-lm: Add of_node_put() before return statement

Message ID 20210112092549.251548-1-linus.walleij@linaro.org (mailing list archive)
State Queued, archived
Headers show
Series bus: arm-integrator-lm: Add of_node_put() before return statement | expand

Commit Message

Linus Walleij Jan. 12, 2021, 9:25 a.m. UTC 
From: Sumera Priyadarsini <sylphrenadin@gmail.com>

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in arm-integrator-lm.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829174154.GA9319@Kaladin
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
SoC people: please apply this directly as a non-urgent fix,
I have no other patches for Versatile right now.
---
 drivers/bus/arm-integrator-lm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann Jan. 15, 2021, 5:22 p.m. UTC | #1 
From: Arnd Bergmann <arnd@arndb.de>

On Tue, 12 Jan 2021 10:25:49 +0100, Linus Walleij wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
> 
> Fix a potential memory leak in arm-integrator-lm.c by inserting
> of_node_put() before a return statement.
> 
> [...]

Applied to arm/fixes, thanks!

[1/1] bus: arm-integrator-lm: Add of_node_put() before return statement
      commit: 1740e6736922cc1a5d061cc4240d08eacfbbaa71

       Arnd
diff mbox series

Patch

diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 845b6c43fef8..2344d560b144 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -54,6 +54,7 @@  static int integrator_lm_populate(int num, struct device *dev)
 			ret = of_platform_default_populate(child, NULL, dev);
 			if (ret) {
 				dev_err(dev, "failed to populate module\n");
+				of_node_put(child);
 				return ret;
 			}
 		}