| Message ID | 20210820173108.01d5c6de@xhacker.debian (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: synaptics: add DT for AS370-RDK | expand |
On 20/08/2021 11:31, Jisheng Zhang wrote: > Add a basic support for AS370-RDK board based on the AS370 SoC. We can > get a basic shell on the uart console now. > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > --- > Hi Arnd, > > If it's too late, I will add it in a PR for 5.16 in next development window. > > Thanks > > arch/arm64/boot/dts/synaptics/Makefile | 1 + > arch/arm64/boot/dts/synaptics/as370-rdk.dts | 29 +++++++++++++++++++++ > 2 files changed, 30 insertions(+) > create mode 100644 arch/arm64/boot/dts/synaptics/as370-rdk.dts > > diff --git a/arch/arm64/boot/dts/synaptics/Makefile b/arch/arm64/boot/dts/synaptics/Makefile > index de71ddda6835..c1c4f6c040b3 100644 > --- a/arch/arm64/boot/dts/synaptics/Makefile > +++ b/arch/arm64/boot/dts/synaptics/Makefile > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > # Berlin SoC Family > +dtb-$(CONFIG_ARCH_BERLIN) += as370-rdk.dtb > dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-dmp.dtb > dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-stb.dtb > diff --git a/arch/arm64/boot/dts/synaptics/as370-rdk.dts b/arch/arm64/boot/dts/synaptics/as370-rdk.dts > new file mode 100644 > index 000000000000..6f5c37c98be6 > --- /dev/null > +++ b/arch/arm64/boot/dts/synaptics/as370-rdk.dts > @@ -0,0 +1,29 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright (C) 2018-2021 Synaptics Incorporated > + * > + * Author: Jisheng Zhang <jszhang@kernel.org> > + */ > + > +/dts-v1/; > + > +#include "as370.dtsi" > + > +/ { > + model = "Synaptics AS370 RDK"; > + compatible = "syna,as370-rdk", "syna,as370"; There is no such binding. You need to update the bindings file (first patch in the series). Best regards, Krzysztof
On Fri, 20 Aug 2021 11:59:30 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe. > > > On 20/08/2021 11:31, Jisheng Zhang wrote: > > Add a basic support for AS370-RDK board based on the AS370 SoC. We can > > get a basic shell on the uart console now. > > > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > > --- > > Hi Arnd, > > > > If it's too late, I will add it in a PR for 5.16 in next development window. > > > > Thanks > > > > arch/arm64/boot/dts/synaptics/Makefile | 1 + > > arch/arm64/boot/dts/synaptics/as370-rdk.dts | 29 +++++++++++++++++++++ > > 2 files changed, 30 insertions(+) > > create mode 100644 arch/arm64/boot/dts/synaptics/as370-rdk.dts > > > > diff --git a/arch/arm64/boot/dts/synaptics/Makefile b/arch/arm64/boot/dts/synaptics/Makefile > > index de71ddda6835..c1c4f6c040b3 100644 > > --- a/arch/arm64/boot/dts/synaptics/Makefile > > +++ b/arch/arm64/boot/dts/synaptics/Makefile > > @@ -1,4 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > # Berlin SoC Family > > +dtb-$(CONFIG_ARCH_BERLIN) += as370-rdk.dtb > > dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-dmp.dtb > > dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-stb.dtb > > diff --git a/arch/arm64/boot/dts/synaptics/as370-rdk.dts b/arch/arm64/boot/dts/synaptics/as370-rdk.dts > > new file mode 100644 > > index 000000000000..6f5c37c98be6 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/synaptics/as370-rdk.dts > > @@ -0,0 +1,29 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +/* > > + * Copyright (C) 2018-2021 Synaptics Incorporated > > + * > > + * Author: Jisheng Zhang <jszhang@kernel.org> > > + */ > > + > > +/dts-v1/; > > + > > +#include "as370.dtsi" > > + > > +/ { > > + model = "Synaptics AS370 RDK"; > > + compatible = "syna,as370-rdk", "syna,as370"; > > There is no such binding. You need to update the bindings file (first > patch in the series). This is my plan ;) In fact, "berlin4ct" related binding is also missing. I want to convert Documentation/devicetree/bindings/arm/syna.txt to yaml, then add missing bindings. But it's too late for 5.15, If it's fine to keep as370.dtsi without board user(s), we can drop this patch. I will solve this issue in next development window. Thanks > > > Best regards, > Krzysztof
On Fri, Aug 20, 2021 at 12:27 PM Jisheng Zhang <Jisheng.Zhang@synaptics.com> wrote: > On Fri, 20 Aug 2021 11:59:30 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 20/08/2021 11:31, Jisheng Zhang wrote: > > > > There is no such binding. You need to update the bindings file (first > > patch in the series). > > This is my plan ;) In fact, "berlin4ct" related binding is also missing. > I want to convert Documentation/devicetree/bindings/arm/syna.txt > to yaml, then add missing bindings. But it's too late for 5.15, > > If it's fine to keep as370.dtsi without board user(s), we can drop > this patch. I will solve this issue in next development window. Yes, doing it for the next cycle is ok. Arnd
On 20/08/2021 21:55, Arnd Bergmann wrote: > On Fri, Aug 20, 2021 at 12:27 PM Jisheng Zhang > <Jisheng.Zhang@synaptics.com> wrote: >> On Fri, 20 Aug 2021 11:59:30 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: >>> On 20/08/2021 11:31, Jisheng Zhang wrote: >>> >>> There is no such binding. You need to update the bindings file (first >>> patch in the series). >> >> This is my plan ;) In fact, "berlin4ct" related binding is also missing. >> I want to convert Documentation/devicetree/bindings/arm/syna.txt >> to yaml, then add missing bindings. But it's too late for 5.15, >> >> If it's fine to keep as370.dtsi without board user(s), we can drop >> this patch. I will solve this issue in next development window. > > Yes, doing it for the next cycle is ok. Hi Arnd and Jisheng, This patch was discussed in Aug 2021 and since then there was no resend. I assume that AD370 will not get a board, so I propose to pick up my removal patch: https://lore.kernel.org/all/YRbDNInfG7caSr2r@robh.at.kernel.org/ I will resend it. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/synaptics/Makefile b/arch/arm64/boot/dts/synaptics/Makefile index de71ddda6835..c1c4f6c040b3 100644 --- a/arch/arm64/boot/dts/synaptics/Makefile +++ b/arch/arm64/boot/dts/synaptics/Makefile @@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 # Berlin SoC Family +dtb-$(CONFIG_ARCH_BERLIN) += as370-rdk.dtb dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-dmp.dtb dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-stb.dtb diff --git a/arch/arm64/boot/dts/synaptics/as370-rdk.dts b/arch/arm64/boot/dts/synaptics/as370-rdk.dts new file mode 100644 index 000000000000..6f5c37c98be6 --- /dev/null +++ b/arch/arm64/boot/dts/synaptics/as370-rdk.dts @@ -0,0 +1,29 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2018-2021 Synaptics Incorporated + * + * Author: Jisheng Zhang <jszhang@kernel.org> + */ + +/dts-v1/; + +#include "as370.dtsi" + +/ { + model = "Synaptics AS370 RDK"; + compatible = "syna,as370-rdk", "syna,as370"; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + memory@1000000 { + device_type = "memory"; + /* the first 16MB is for firmwares' usage */ + reg = <0 0x01000000 0 0x1f000000>; + }; +}; + +&uart0 { + status = "okay"; +};
Add a basic support for AS370-RDK board based on the AS370 SoC. We can get a basic shell on the uart console now. Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> --- Hi Arnd, If it's too late, I will add it in a PR for 5.16 in next development window. Thanks arch/arm64/boot/dts/synaptics/Makefile | 1 + arch/arm64/boot/dts/synaptics/as370-rdk.dts | 29 +++++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 arch/arm64/boot/dts/synaptics/as370-rdk.dts