diff mbox series

soc: samsung: exynos-pmu: select CONFIG_MFD_CORE

Message ID 20210920100613.1613919-1-arnd@kernel.org (mailing list archive)
State Not Applicable
Headers show
Series soc: samsung: exynos-pmu: select CONFIG_MFD_CORE | expand

Commit Message

Arnd Bergmann Sept. 20, 2021, 10:06 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Using devm_mfd_add_devices() fails if no driver selects the
MFD core code:

aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'

Add the missing select statement.

Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 20, 2021, 10:28 a.m. UTC | #1 
On 20/09/2021 12:06, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Using devm_mfd_add_devices() fails if no driver selects the
> MFD core code:
> 
> aarch64-linux-ld: drivers/soc/samsung/exynos-pmu.o: in function `exynos_pmu_probe':
> exynos-pmu.c:(.text+0xa0): undefined reference to `devm_mfd_add_devices'
> 
> Add the missing select statement.
> 
> Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/soc/samsung/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Hi Arnd,

Thanks for the patch but this was already committed few days ago from
different author:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/drivers&id=e37ef6dcdb1f4738b01cec7fb7be46af07816af9


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
index 5745d7e5908e..1f643c0f5c93 100644
--- a/drivers/soc/samsung/Kconfig
+++ b/drivers/soc/samsung/Kconfig
@@ -25,6 +25,7 @@  config EXYNOS_PMU
 	bool "Exynos PMU controller driver" if COMPILE_TEST
 	depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST)
 	select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS
+	select MFD_CORE
 
 # There is no need to enable these drivers for ARMv8
 config EXYNOS_PMU_ARM_DRIVERS