diff mbox series

dove: mark 'putc' as inline

Message ID 20210927095343.1015422-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit b9af50bcbcd2344640e4c2937bd2af1f856a4ced
Headers show
Series dove: mark 'putc' as inline | expand

Commit Message

Arnd Bergmann Sept. 27, 2021, 9:53 a.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

This can cause a randconfig warning without the 'inline' flag
that every other platform uses:

In file included from arch/arm/boot/compressed/misc.c:29:
arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
   14 | static void putc(const char c)
      |             ^~~~

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-dove/include/mach/uncompress.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Lunn Sept. 27, 2021, 12:40 p.m. UTC | #1
On Mon, Sep 27, 2021 at 11:53:33AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This can cause a randconfig warning without the 'inline' flag
> that every other platform uses:
> 
> In file included from arch/arm/boot/compressed/misc.c:29:
> arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
>    14 | static void putc(const char c)
>       |             ^~~~
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+linux-soc@kernel.org Oct. 5, 2021, 1:50 p.m. UTC | #2
Hello:

This patch was applied to soc/soc.git (refs/heads/arm/fixes):

On Mon, 27 Sep 2021 11:53:33 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This can cause a randconfig warning without the 'inline' flag
> that every other platform uses:
> 
> In file included from arch/arm/boot/compressed/misc.c:29:
> arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
>    14 | static void putc(const char c)
>       |             ^~~~
> 
> [...]

Here is the summary with links:
  - dove: mark 'putc' as inline
    https://git.kernel.org/soc/soc/c/b9af50bcbcd2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/arch/arm/mach-dove/include/mach/uncompress.h b/arch/arm/mach-dove/include/mach/uncompress.h
index 7a4bd8838036..ddf873f35e2b 100644
--- a/arch/arm/mach-dove/include/mach/uncompress.h
+++ b/arch/arm/mach-dove/include/mach/uncompress.h
@@ -11,7 +11,7 @@ 
 
 #define LSR_THRE	0x20
 
-static void putc(const char c)
+static inline void putc(const char c)
 {
 	int i;
 
@@ -24,7 +24,7 @@  static void putc(const char c)
 	*UART_THR = c;
 }
 
-static void flush(void)
+static inline void flush(void)
 {
 }