| Message ID | 20211022010027.11866-1-leoyang.li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [GIT,PULL] soc/fsl drivers changes for fix(v5.15) | expand |
On Fri, Oct 22, 2021 at 3:00 AM Li Yang <leoyang.li@nxp.com> wrote: > ---------------------------------------------------------------- > NXP/FSL SoC driver fixes for v5.15 > - fix qbman alignment error in the virtualization context This patch looks very suspicious to me, I don't think it's generally safe to use memcpy_toio() on a normal pointer, as the __iomem tokens may be in a separate address range, even though this currently works on arm64. Adding the (__iomem void *) cast without a comment that explains why it's added seems similarly wrong, and finally the changeset text does not seem to match what the code does: According to the text, the pointer is to a virtual address mapped as "device memory" (i.e. PROT_DEVICE_nGnRE or PROT_DEVICE_nGnRnE), but the code suggests it's actually write-combining normal (PROT_NORMAL_NC). I don't see any discussion of this patch on the mailing list either, so please resend the pull request without this patch, while we try to figure out what the driver should actually be doing here. Arnd
Hi soc maintainers, Please merge the following new changes for soc/fsl drivers. Regards, Leo The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f: Linux 5.15-rc1 (2021-09-12 16:28:37 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git tags/soc-fsl-fix-v5.15 for you to fetch changes up to 7e5e744183bbb0ad02412b21b1e61380c998dd18: soc: fsl: dpio: fix qbman alignment error in the virtualization context (2021-10-21 18:20:21 -0500) ---------------------------------------------------------------- NXP/FSL SoC driver fixes for v5.15 DPAA2 DPIO driver - replace smp_processor_id with raw_smp_processor_id to fix preempt debug BUG - use the combined functions to protect critical zone to fix deadlock - fix qbman alignment error in the virtualization context DPAA2 console - free buffer before returning from dpaa2_console_read ---------------------------------------------------------------- Diana Craciun (1): soc: fsl: dpio: fix qbman alignment error in the virtualization context Meng Li (2): soc: fsl: dpio: replace smp_processor_id with raw_smp_processor_id soc: fsl: dpio: use the combined functions to protect critical zone Robert-Ionut Alexa (1): soc: fsl: dpaa2-console: free buffer before returning from dpaa2_console_read drivers/soc/fsl/dpaa2-console.c | 1 + drivers/soc/fsl/dpio/dpio-service.c | 2 +- drivers/soc/fsl/dpio/qbman-portal.c | 33 +++++++++++++++------------------ 3 files changed, 17 insertions(+), 19 deletions(-)