| Message ID | 20211220115405.30434-2-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 96c8bddb6cdefb029cc7e411a5ee2183477368ea |
| Headers | show |
| Series | Samsung for v5.17 | expand |
On Mon, Dec 20, 2021 at 12:54 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > ---------------------------------------------------------------- > Samsung SoC drivers changes for v5.17 > > 1. Exynos ChipID: add Exynos7885 support. > 2. Exynos PMU: add Exynos850 support. > 3. Minor bindings cleanup. > 4. Add Exynos USIv2 (Universal Serial Interface) driver. The USI block is > a shared IP block between I2C, UART/serial and SPI. Basically one has > to choose which feature the USI block will support and later the > regular I2C/serial/SPI driver will bind and work. > This merges also one commit with dt-binding headers from my dts64 > pull request. > > Together with a future serial driver change, this will break the ABI. > > Affected: Serial on ExynosAutov9 SADK and out-of-tree ExynosAutov9 boards > > Why: To properly and efficiently support the USI with new hierarchy > of USI-{serial,SPI,I2C} devicetree nodes. > > Rationale: > Recently added serial and USI support was short-sighted and did not > allow to smooth support of other features (SPI and I2C). Adding > support for USI-SPI and USI-I2C would effect in code duplication. > Adding support for different USI versions (currently supported is > USIv2 but support for v1 is planned) would cause even more code > duplication and create a solution difficult to maintain. > Since USI-serial and ExynosAutov9 have been added recently, are > considered fresh development features and there are no supported > products using them, the code/solution is being refactored in > non-backwards compatible way. The compatibility is not broken yet. > It will be when serial driver changes are accepted. > The ABI break was discussed with only known users of ExynosAutov9 and > received their permission. Thanks a lot for the detailed description, very helpful! I've applied pull requests 1 through 4, though it seems that once more the automated emails did not go out. I can't find the two defconfig patches you mentioned in the introductory mail, neither in patchwork nor in my inbox, I assume these were numbered 5/6 and 6/6? Arnd
On 20/12/2021 17:26, Arnd Bergmann wrote: > On Mon, Dec 20, 2021 at 12:54 PM Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com> wrote: >> ---------------------------------------------------------------- >> Samsung SoC drivers changes for v5.17 >> >> 1. Exynos ChipID: add Exynos7885 support. >> 2. Exynos PMU: add Exynos850 support. >> 3. Minor bindings cleanup. >> 4. Add Exynos USIv2 (Universal Serial Interface) driver. The USI block is >> a shared IP block between I2C, UART/serial and SPI. Basically one has >> to choose which feature the USI block will support and later the >> regular I2C/serial/SPI driver will bind and work. >> This merges also one commit with dt-binding headers from my dts64 >> pull request. >> >> Together with a future serial driver change, this will break the ABI. >> >> Affected: Serial on ExynosAutov9 SADK and out-of-tree ExynosAutov9 boards >> >> Why: To properly and efficiently support the USI with new hierarchy >> of USI-{serial,SPI,I2C} devicetree nodes. >> >> Rationale: >> Recently added serial and USI support was short-sighted and did not >> allow to smooth support of other features (SPI and I2C). Adding >> support for USI-SPI and USI-I2C would effect in code duplication. >> Adding support for different USI versions (currently supported is >> USIv2 but support for v1 is planned) would cause even more code >> duplication and create a solution difficult to maintain. >> Since USI-serial and ExynosAutov9 have been added recently, are >> considered fresh development features and there are no supported >> products using them, the code/solution is being refactored in >> non-backwards compatible way. The compatibility is not broken yet. >> It will be when serial driver changes are accepted. >> The ABI break was discussed with only known users of ExynosAutov9 and >> received their permission. > > Thanks a lot for the detailed description, very helpful! > > I've applied pull requests 1 through 4, though it seems that once more > the automated emails did not go out. > > I can't find the two defconfig patches you mentioned in the introductory > mail, neither in patchwork nor in my inbox, I assume these were > numbered 5/6 and 6/6? > Yes, these were patches 5/6 and 6/6 but maybe I made mistakes in address list. Let me resend them now. Best regards, Krzysztof
Hi, See below in the tag explanation for ABI impact by this change and future serial driver changes. ABI break is not yet broken, although changes are not bisectable between DTS and driver. Best regards, Krzysztof The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf: Linux 5.16-rc1 (2021-11-14 13:56:52 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-5.17 for you to fetch changes up to 96c8bddb6cdefb029cc7e411a5ee2183477368ea: dt-bindings: soc: samsung: keep SoC driver bindings together (2021-12-18 11:55:59 +0100) ---------------------------------------------------------------- Samsung SoC drivers changes for v5.17 1. Exynos ChipID: add Exynos7885 support. 2. Exynos PMU: add Exynos850 support. 3. Minor bindings cleanup. 4. Add Exynos USIv2 (Universal Serial Interface) driver. The USI block is a shared IP block between I2C, UART/serial and SPI. Basically one has to choose which feature the USI block will support and later the regular I2C/serial/SPI driver will bind and work. This merges also one commit with dt-binding headers from my dts64 pull request. Together with a future serial driver change, this will break the ABI. Affected: Serial on ExynosAutov9 SADK and out-of-tree ExynosAutov9 boards Why: To properly and efficiently support the USI with new hierarchy of USI-{serial,SPI,I2C} devicetree nodes. Rationale: Recently added serial and USI support was short-sighted and did not allow to smooth support of other features (SPI and I2C). Adding support for USI-SPI and USI-I2C would effect in code duplication. Adding support for different USI versions (currently supported is USIv2 but support for v1 is planned) would cause even more code duplication and create a solution difficult to maintain. Since USI-serial and ExynosAutov9 have been added recently, are considered fresh development features and there are no supported products using them, the code/solution is being refactored in non-backwards compatible way. The compatibility is not broken yet. It will be when serial driver changes are accepted. The ABI break was discussed with only known users of ExynosAutov9 and received their permission. ---------------------------------------------------------------- David Virag (1): soc: samsung: exynos-chipid: add Exynos7885 SoC support Krzysztof Kozlowski (3): soc: samsung: exynos-chipid: describe which SoCs go with compatibles Merge tag 'samsung-dt64-exynos-usi-5.17' into next/drivers dt-bindings: soc: samsung: keep SoC driver bindings together Sam Protsenko (4): dt-bindings: samsung: pmu: Document Exynos850 soc: samsung: exynos-pmu: Add Exynos850 support dt-bindings: soc: samsung: Add Exynos USI bindings soc: samsung: Add USI driver .../{arm => soc}/samsung/exynos-chipid.yaml | 2 +- .../pmu.yaml => soc/samsung/exynos-pmu.yaml} | 4 +- .../bindings/soc/samsung/exynos-usi.yaml | 159 ++++++++++++ MAINTAINERS | 1 + drivers/soc/samsung/Kconfig | 14 + drivers/soc/samsung/Makefile | 2 + drivers/soc/samsung/exynos-chipid.c | 3 + drivers/soc/samsung/exynos-pmu.c | 2 + drivers/soc/samsung/exynos-usi.c | 285 +++++++++++++++++++++ include/dt-bindings/soc/samsung,exynos-usi.h | 17 ++ 10 files changed, 487 insertions(+), 2 deletions(-) rename Documentation/devicetree/bindings/{arm => soc}/samsung/exynos-chipid.yaml (93%) rename Documentation/devicetree/bindings/{arm/samsung/pmu.yaml => soc/samsung/exynos-pmu.yaml} (95%) create mode 100644 Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml create mode 100644 drivers/soc/samsung/exynos-usi.c create mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h