diff mbox series

[1/8] dt-bindings: rcc: Add optional external ethernet RX clock properties

Message ID 20220422150952.20587-2-alexandre.torgue@foss.st.com (mailing list archive)
State Changes Requested
Headers show
Series Add SCMI version of ST boards | expand

Commit Message

Alexandre TORGUE April 22, 2022, 3:09 p.m. UTC
From: Marek Vasut <marex@denx.de>

Describe optional external ethernet RX clock in the DT binding
to fix dtbs_check warnings like:

arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
Cc: Rob Herring <robh+dt@kernel.org>
To: devicetree@vger.kernel.org
Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>

Comments

Marek Vasut April 22, 2022, 4:28 p.m. UTC | #1
On 4/22/22 17:09, Alexandre Torgue wrote:
> From: Marek Vasut <marex@denx.de>
> 
> Describe optional external ethernet RX clock in the DT binding
> to fix dtbs_check warnings like:
> 
> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> To: devicetree@vger.kernel.org
> Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> 
> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> index a0ae4867ed27..7a251264582d 100644
> --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> @@ -59,6 +59,14 @@ properties:
>             - st,stm32mp1-rcc
>         - const: syscon
>   
> +  clocks:
> +    description:
> +      Specifies the external RX clock for ethernet MAC.
> +    maxItems: 1
> +
> +  clock-names:
> +    const: ETH_RX_CLK/ETH_REF_CLK
> +
>     reg:
>       maxItems: 1
>   

Should this patch be part of this series, maybe this was re-sent by 
accident ?
Alexandre TORGUE April 25, 2022, 5:21 p.m. UTC | #2
Hi Marek

On 4/22/22 18:28, Marek Vasut wrote:
> On 4/22/22 17:09, Alexandre Torgue wrote:
>> From: Marek Vasut <marex@denx.de>
>>
>> Describe optional external ethernet RX clock in the DT binding
>> to fix dtbs_check warnings like:
>>
>> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: rcc@50000000: 
>> 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 
>> 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
>> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> To: devicetree@vger.kernel.org
>> Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml 
>> b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>> index a0ae4867ed27..7a251264582d 100644
>> --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
>> @@ -59,6 +59,14 @@ properties:
>>             - st,stm32mp1-rcc
>>         - const: syscon
>> +  clocks:
>> +    description:
>> +      Specifies the external RX clock for ethernet MAC.
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: ETH_RX_CLK/ETH_REF_CLK
>> +
>>     reg:
>>       maxItems: 1
> 
> Should this patch be part of this series, maybe this was re-sent by 
> accident ?

Not by accident. As your patch is already merged in Rob tree (I guess), 
I added it in this series to avoid merge conflict later. I added a late 
note in the cover-letter.

regards
alex
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
index a0ae4867ed27..7a251264582d 100644
--- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
+++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
@@ -59,6 +59,14 @@  properties:
           - st,stm32mp1-rcc
       - const: syscon
 
+  clocks:
+    description:
+      Specifies the external RX clock for ethernet MAC.
+    maxItems: 1
+
+  clock-names:
+    const: ETH_RX_CLK/ETH_REF_CLK
+
   reg:
     maxItems: 1