| Message ID | 20220505125736.207029-1-broonie@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND] ARM: configs: at91: Enable options required for systemd | expand |
On 05/05/2022 at 14:57, Mark Brown wrote: > Even smaller embedded systems are using systemd these days, as > are test automation systems like KernelCI, so it is useful to be > able to use systemd on these boards by default. Enable options > that are missing in the at91_dt_defconfig, cgroups which is > critical and autofs4 which is less critical but causes warnings > on boot when not available. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > > This would be useful for KernelCI which uses a systemd based rootfs for > many tests. Sure Mark, sorry for the delay. We are just generating the 5.19 branches right now. Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> and queued in at91-defconfig branch for 5.19. It should appear in linux-next in a couple of days. Best regards, Nicolas > arch/arm/configs/at91_dt_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig > index 549d01be0b47..bbb7f400a57f 100644 > --- a/arch/arm/configs/at91_dt_defconfig > +++ b/arch/arm/configs/at91_dt_defconfig > @@ -4,6 +4,7 @@ CONFIG_SYSVIPC=y > CONFIG_NO_HZ_IDLE=y > CONFIG_HIGH_RES_TIMERS=y > CONFIG_LOG_BUF_SHIFT=14 > +CONFIG_CGROUPS=y > CONFIG_BLK_DEV_INITRD=y > CONFIG_CC_OPTIMIZE_FOR_SIZE=y > CONFIG_KALLSYMS_ALL=y > @@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y > CONFIG_PWM_ATMEL_HLCDC_PWM=y > CONFIG_PWM_ATMEL_TCB=y > CONFIG_EXT4_FS=y > +CONFIG_AUTOFS4_FS=m > CONFIG_FANOTIFY=y > CONFIG_VFAT_FS=y > CONFIG_TMPFS=y > -- > 2.30.2 >
Mark, On 05/05/2022 at 14:57, Mark Brown wrote: > Even smaller embedded systems are using systemd these days, as > are test automation systems like KernelCI, so it is useful to be > able to use systemd on these boards by default. Enable options > that are missing in the at91_dt_defconfig, cgroups which is > critical and autofs4 which is less critical but causes warnings > on boot when not available. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > > This would be useful for KernelCI which uses a systemd based rootfs for > many tests. > > arch/arm/configs/at91_dt_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig > index 549d01be0b47..bbb7f400a57f 100644 > --- a/arch/arm/configs/at91_dt_defconfig > +++ b/arch/arm/configs/at91_dt_defconfig > @@ -4,6 +4,7 @@ CONFIG_SYSVIPC=y > CONFIG_NO_HZ_IDLE=y > CONFIG_HIGH_RES_TIMERS=y > CONFIG_LOG_BUF_SHIFT=14 > +CONFIG_CGROUPS=y > CONFIG_BLK_DEV_INITRD=y > CONFIG_CC_OPTIMIZE_FOR_SIZE=y > CONFIG_KALLSYMS_ALL=y > @@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y > CONFIG_PWM_ATMEL_HLCDC_PWM=y > CONFIG_PWM_ATMEL_TCB=y > CONFIG_EXT4_FS=y > +CONFIG_AUTOFS4_FS=m While trying to add this option to our other defconfigs, I read this in the CONFIG_AUTOFS4_FS entry for 5.18-rc1: "This name exists for people to just automatically pick up the new name of the autofs Kconfig option. All it does is select the new option name. It will go away in a release or two as people have transitioned to just plain AUTOFS_FS." Don't we need to change to CONFIG_AUTOFS_FS now? Regards, Nicolas > CONFIG_FANOTIFY=y > CONFIG_VFAT_FS=y > CONFIG_TMPFS=y > -- > 2.30.2 >
On Thu, May 05, 2022 at 05:28:14PM +0200, Nicolas Ferre wrote: > On 05/05/2022 at 14:57, Mark Brown wrote: > > @@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y > > CONFIG_PWM_ATMEL_HLCDC_PWM=y > > CONFIG_PWM_ATMEL_TCB=y > > CONFIG_EXT4_FS=y > > +CONFIG_AUTOFS4_FS=m > While trying to add this option to our other defconfigs, I read this in the > CONFIG_AUTOFS4_FS entry for 5.18-rc1: > "This name exists for people to just automatically pick up the > new name of the autofs Kconfig option. All it does is select > the new option name. > It will go away in a release or two as people have > transitioned to just plain AUTOFS_FS." > Don't we need to change to CONFIG_AUTOFS_FS now? That should be fine. I was just picking up options from the systemd documentation.
diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig index 549d01be0b47..bbb7f400a57f 100644 --- a/arch/arm/configs/at91_dt_defconfig +++ b/arch/arm/configs/at91_dt_defconfig @@ -4,6 +4,7 @@ CONFIG_SYSVIPC=y CONFIG_NO_HZ_IDLE=y CONFIG_HIGH_RES_TIMERS=y CONFIG_LOG_BUF_SHIFT=14 +CONFIG_CGROUPS=y CONFIG_BLK_DEV_INITRD=y CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_KALLSYMS_ALL=y @@ -205,6 +206,7 @@ CONFIG_PWM_ATMEL=y CONFIG_PWM_ATMEL_HLCDC_PWM=y CONFIG_PWM_ATMEL_TCB=y CONFIG_EXT4_FS=y +CONFIG_AUTOFS4_FS=m CONFIG_FANOTIFY=y CONFIG_VFAT_FS=y CONFIG_TMPFS=y
Even smaller embedded systems are using systemd these days, as are test automation systems like KernelCI, so it is useful to be able to use systemd on these boards by default. Enable options that are missing in the at91_dt_defconfig, cgroups which is critical and autofs4 which is less critical but causes warnings on boot when not available. Signed-off-by: Mark Brown <broonie@kernel.org> --- This would be useful for KernelCI which uses a systemd based rootfs for many tests. arch/arm/configs/at91_dt_defconfig | 2 ++ 1 file changed, 2 insertions(+)