diff mbox series

arm64: defconfig: enable ARCH_BCM

Message ID 20220906033957.4377-1-f.fainelli@gmail.com (mailing list archive)
State Not Applicable
Headers show
Series arm64: defconfig: enable ARCH_BCM | expand

Commit Message

Florian Fainelli Sept. 6, 2022, 3:39 a.m. UTC
Commit 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom
menu") introduced a new symbol ARCH_BCM and made all of the Broadcom
SoCs Kconfig depend on it, but did not enable it in the defconfig.
Thus, now the defconfig doesn't include support for any Broadcom
architectures anymore. Fix it.

Fixes: 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom menu")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Anders Roxell Sept. 8, 2022, 6:17 p.m. UTC | #1
On 2022-09-05 20:39, Florian Fainelli wrote:
> Commit 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom
> menu") introduced a new symbol ARCH_BCM and made all of the Broadcom
> SoCs Kconfig depend on it, but did not enable it in the defconfig.
> Thus, now the defconfig doesn't include support for any Broadcom
> architectures anymore. Fix it.
> 
> Fixes: 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom menu")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Tested-by: Anders Roxell <anders.roxell@linaro.org>

Cheers,
Anders

> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 91e58cf59c99..4c8b09c6b49f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -33,6 +33,7 @@ CONFIG_ARCH_ACTIONS=y
>  CONFIG_ARCH_SUNXI=y
>  CONFIG_ARCH_ALPINE=y
>  CONFIG_ARCH_APPLE=y
> +CONFIG_ARCH_BCM=y
>  CONFIG_ARCH_BCM2835=y
>  CONFIG_ARCH_BCMBCA=y
>  CONFIG_ARCH_BCM_IPROC=y
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Naresh Kamboju Sept. 9, 2022, 7:35 a.m. UTC | #2
From: Naresh kamboju <naresh.kamboju@linaro.org>


On 2022-09-05 20:39, Florian Fainelli wrote:
> Commit 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom
> menu") introduced a new symbol ARCH_BCM and made all of the Broadcom
> SoCs Kconfig depend on it, but did not enable it in the defconfig.
> Thus, now the defconfig doesn't include support for any Broadcom
> architectures anymore. Fix it.
> 
> Fixes: 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom menu")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

--
Linaro LKFT
https://lkft.linaro.org
Krzysztof Kozlowski Sept. 9, 2022, 7:38 a.m. UTC | #3
On 09/09/2022 09:35, Naresh Kamboju wrote:
> From: Naresh kamboju <naresh.kamboju@linaro.org>
> 
> 
> On 2022-09-05 20:39, Florian Fainelli wrote:
>> Commit 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom
>> menu") introduced a new symbol ARCH_BCM and made all of the Broadcom
>> SoCs Kconfig depend on it, but did not enable it in the defconfig.
>> Thus, now the defconfig doesn't include support for any Broadcom
>> architectures anymore. Fix it.
>>
>> Fixes: 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom menu")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

The patch was sent on 6th of September. Your report on 8th of September...

Best regards,
Krzysztof
Naresh Kamboju Sept. 9, 2022, 12:24 p.m. UTC | #4
On Fri, 9 Sept 2022 at 13:08, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/09/2022 09:35, Naresh Kamboju wrote:
> > From: Naresh kamboju <naresh.kamboju@linaro.org>
> >
> >
> > On 2022-09-05 20:39, Florian Fainelli wrote:
> >> Commit 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom
> >> menu") introduced a new symbol ARCH_BCM and made all of the Broadcom
> >> SoCs Kconfig depend on it, but did not enable it in the defconfig.
> >> Thus, now the defconfig doesn't include support for any Broadcom
> >> architectures anymore. Fix it.
> >>
> >> Fixes: 96796c914b84 ("arm64: Kconfig.platforms: Re-organized Broadcom menu")
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> The patch was sent on 6th of September. Your report on 8th of September...

Understood !
Maybe off-topic,
Testing Linux next seems to be a bit late to report the regressions.
Our testing would have build and boot test devicetree/for-next or
devicetree / master branches to find early regressions.
or Any other well known maintainers trees.

Your suggestions are most welcome for improving Linux kernel quality.

Best regards
Naresh Kamboju

--
Linaro LKFT
https://lkft.linaro.org

>
> Best regards,
> Krzysztof
Mark Brown Sept. 9, 2022, 4:25 p.m. UTC | #5
On Fri, Sep 09, 2022 at 05:54:11PM +0530, Naresh Kamboju wrote:
> On Fri, 9 Sept 2022 at 13:08, Krzysztof Kozlowski
> > On 09/09/2022 09:35, Naresh Kamboju wrote:

> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

> > The patch was sent on 6th of September. Your report on 8th of September...

> Understood !

> Maybe off-topic,
> Testing Linux next seems to be a bit late to report the regressions.
> Our testing would have build and boot test devicetree/for-next or
> devicetree / master branches to find early regressions.
> or Any other well known maintainers trees.
> 
> Your suggestions are most welcome for improving Linux kernel quality.

Checking maintainer trees in addition to -next isn't going to be that
substantially faster except at weekends, the whole thing with -next is
that it gets built daily so depending on when patches appear in the
maintainer trees and how long -next takes to build you'll be running
tests less than two days earlier, the way people's timezones work out
it's often under a day for many maintainer trees.  It can reduce
turnaround time for the specific tree, and it can be useful for
identifying where problems come from, but on the other hand the
integration that -next offers is important, some critical stuff only
appears in -next and obviously each individual tree that gets covered
separately is more load on your systems and triage.

The key thing with -next is that it's a moving target so it's useful to
turn around results as fast as possible so they arrive before it gets
rebuilt, or if you've seen something on an older -next check that it's
still relevant when you do report it.
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 91e58cf59c99..4c8b09c6b49f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -33,6 +33,7 @@  CONFIG_ARCH_ACTIONS=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_ARCH_ALPINE=y
 CONFIG_ARCH_APPLE=y
+CONFIG_ARCH_BCM=y
 CONFIG_ARCH_BCM2835=y
 CONFIG_ARCH_BCMBCA=y
 CONFIG_ARCH_BCM_IPROC=y