diff mbox series

soc: tegra: fix CPU_BIG_ENDIAN dependencies

Message ID 20221215165336.1781080-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit ba4b4d0293ed12ec2eda09e0329d9831243ca699
Headers show
Series soc: tegra: fix CPU_BIG_ENDIAN dependencies | expand

Commit Message

Arnd Bergmann Dec. 15, 2022, 4:53 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

My previous patch to prevent BPMP from being enabled on big
endian kernels caused a build regression:

WARNING: unmet direct dependencies detected for TEGRA_BPMP
  Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y]
  Selected by [y]:
  - ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
  - ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
  - ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]

Add even more such dependencies for the SoC types that use
the BPMP driver.

Fixes: 4ddb1bf1a837 ("tegra: mark BPMP driver as little-endian only")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/tegra/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thierry Reding Dec. 16, 2022, 1:20 p.m. UTC | #1
On Thu, Dec 15, 2022 at 05:53:21PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> My previous patch to prevent BPMP from being enabled on big
> endian kernels caused a build regression:
> 
> WARNING: unmet direct dependencies detected for TEGRA_BPMP
>   Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y]
>   Selected by [y]:
>   - ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
>   - ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
>   - ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
> 
> Add even more such dependencies for the SoC types that use
> the BPMP driver.
> 
> Fixes: 4ddb1bf1a837 ("tegra: mark BPMP driver as little-endian only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/soc/tegra/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)

Do you want to pick this up into ARM SoC directly? If so:

Acked-by: Thierry Reding <treding@nvidia.com>
patchwork-bot+linux-soc@kernel.org Dec. 19, 2022, 4 p.m. UTC | #2
Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <arnd@arndb.de>:

On Thu, 15 Dec 2022 17:53:21 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> My previous patch to prevent BPMP from being enabled on big
> endian kernels caused a build regression:
> 
> WARNING: unmet direct dependencies detected for TEGRA_BPMP
>   Depends on [n]: ARCH_TEGRA [=y] && TEGRA_HSP_MBOX [=y] && TEGRA_IVC [=y] && !CPU_BIG_ENDIAN [=y]
>   Selected by [y]:
>   - ARCH_TEGRA_186_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
>   - ARCH_TEGRA_194_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
>   - ARCH_TEGRA_234_SOC [=y] && ARCH_TEGRA [=y] && ARM64 [=y]
> 
> [...]

Here is the summary with links:
  - soc: tegra: fix CPU_BIG_ENDIAN dependencies
    https://git.kernel.org/soc/soc/c/ba4b4d0293ed

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index 5f5324294636..3658fb0f0c5b 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -95,6 +95,7 @@  config ARCH_TEGRA_210_SOC
 
 config ARCH_TEGRA_186_SOC
 	bool "NVIDIA Tegra186 SoC"
+	depends on !CPU_BIG_ENDIAN
 	select MAILBOX
 	select TEGRA_BPMP
 	select TEGRA_HSP_MBOX
@@ -110,6 +111,7 @@  config ARCH_TEGRA_186_SOC
 
 config ARCH_TEGRA_194_SOC
 	bool "NVIDIA Tegra194 SoC"
+	depends on !CPU_BIG_ENDIAN
 	select MAILBOX
 	select PINCTRL_TEGRA194
 	select TEGRA_BPMP
@@ -121,6 +123,7 @@  config ARCH_TEGRA_194_SOC
 
 config ARCH_TEGRA_234_SOC
 	bool "NVIDIA Tegra234 SoC"
+	depends on !CPU_BIG_ENDIAN
 	select MAILBOX
 	select TEGRA_BPMP
 	select TEGRA_HSP_MBOX