| Message ID | 20230220-imx-pci-defconfig-v1-1-2210cf08340e@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0cd5780eb625cc4e49cf65df9ad29a6591658b74 |
| Headers | show |
| Series | arm64: defconfig: Fix unintentional disablement of PCI on i.MX | expand |
> -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: 2023年2月21日 3:10 > To: Catalin Marinas <catalin.marinas@arm.com>; Will Deacon > <will@kernel.org>; soc@kernel.org; Hongxing Zhu <hongxing.zhu@nxp.com>; > Lorenzo Pieralisi <lpieralisi@kernel.org>; Hongxing Zhu > <hongxing.zhu@nxp.com>; Lucas Stach <l.stach@pengutronix.de> > Cc: Michael Walle <michael@walle.cc>; Krzysztof Wilczyński > <kw@linux.com>; Kishon Vijay Abraham I <kishon@kernel.org>; > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Manivannan > Sadhasivam <mani@kernel.org>; kernelci.org bot <bot@kernelci.org>; Mark > Brown <broonie@kernel.org> > Subject: [PATCH] arm64: defconfig: Fix unintentional disablement of PCI on > i.MX > > A recent update to support PCI endpoint mode on i.MX platforms > unintentionally disabled PCI host support for i.MX in defconfig. The existing > PCI_IMX6 was made a hidden option, selected by new options > PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the endpoint > mode), but there has been no corresponding update to defconfig so the > PCI_IMX6 ends up getting disabled. Switch defconfig to PCI_IMX6_HOST to > preserve the existing functionality. > > Fixes: 75c2f26da03f ("PCI: imx6: Add i.MX PCIe EP mode support") > Reported-by: "kernelci.org bot" <bot@kernelci.org> > Signed-off-by: Mark Brown <broonie@kernel.org> > --- Thanks a lot for your fix. Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> Best Regards Richard Zhu > arch/arm64/configs/defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index b452d8d7a32c..36f5c9ecc871 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -219,7 +219,7 @@ CONFIG_PCI_HOST_THUNDER_ECAM=y > CONFIG_PCIE_ROCKCHIP_HOST=m CONFIG_PCIE_MEDIATEK_GEN3=m > CONFIG_PCIE_BRCMSTB=m -CONFIG_PCI_IMX6=y > +CONFIG_PCI_IMX6_HOST=y > CONFIG_PCI_LAYERSCAPE=y > CONFIG_PCI_HISI=y > CONFIG_PCIE_QCOM=y > > --- > base-commit: d2af0fa4bfa4ec29d03b449ccd43fee39501112d > change-id: 20230220-imx-pci-defconfig-8a3a283b798a > > Best regards, > -- > Mark Brown <broonie@kernel.org>
Hello: This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <arnd@arndb.de>: On Mon, 20 Feb 2023 19:09:45 +0000 you wrote: > A recent update to support PCI endpoint mode on i.MX platforms > unintentionally disabled PCI host support for i.MX in defconfig. The > existing PCI_IMX6 was made a hidden option, selected by new options > PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the > endpoint mode), but there has been no corresponding update to defconfig > so the PCI_IMX6 ends up getting disabled. Switch defconfig to > PCI_IMX6_HOST to preserve the existing functionality. > > [...] Here is the summary with links: - arm64: defconfig: Fix unintentional disablement of PCI on i.MX https://git.kernel.org/soc/soc/c/0cd5780eb625 You are awesome, thank you!
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index b452d8d7a32c..36f5c9ecc871 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -219,7 +219,7 @@ CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_PCIE_ROCKCHIP_HOST=m CONFIG_PCIE_MEDIATEK_GEN3=m CONFIG_PCIE_BRCMSTB=m -CONFIG_PCI_IMX6=y +CONFIG_PCI_IMX6_HOST=y CONFIG_PCI_LAYERSCAPE=y CONFIG_PCI_HISI=y CONFIG_PCIE_QCOM=y
A recent update to support PCI endpoint mode on i.MX platforms unintentionally disabled PCI host support for i.MX in defconfig. The existing PCI_IMX6 was made a hidden option, selected by new options PCI_IMX6_HOST (for the existing support) and PCI_IMX6_EP (for the endpoint mode), but there has been no corresponding update to defconfig so the PCI_IMX6 ends up getting disabled. Switch defconfig to PCI_IMX6_HOST to preserve the existing functionality. Fixes: 75c2f26da03f ("PCI: imx6: Add i.MX PCIe EP mode support") Reported-by: "kernelci.org bot" <bot@kernelci.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- arch/arm64/configs/defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: d2af0fa4bfa4ec29d03b449ccd43fee39501112d change-id: 20230220-imx-pci-defconfig-8a3a283b798a Best regards,