| Message ID | 20230516153109.514251-7-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ecd2a5769d09e57b6d9cafdbcf91c13f31286b06 |
| Headers | show |
| Series | ARM: SoC: address -Wmissing-prototype warnings | expand |
On 5/16/23 18:31, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > lpc32xx_loopback_set() is defined in linux/soc/nxp/lpc32xx-misc.h but > this is not included before the function definition. > > arch/arm/mach-lpc32xx/serial.c:63:6: error: no previous prototype for 'lpc32xx_loopback_set' > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-lpc32xx/serial.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-lpc32xx/serial.c b/arch/arm/mach-lpc32xx/serial.c > index 3e765c4bf986..3b1203db81b2 100644 > --- a/arch/arm/mach-lpc32xx/serial.c > +++ b/arch/arm/mach-lpc32xx/serial.c > @@ -15,6 +15,7 @@ > #include <linux/serial_8250.h> > #include <linux/clk.h> > #include <linux/io.h> > +#include <linux/soc/nxp/lpc32xx-misc.h> > > #include "lpc32xx.h" > #include "common.h" Acked-by: Vladimir Zapolskiy <vz@mleia.com> If you wish, you may consider to add one more tag: Fixes: ffba29c9ebd0 ("serial: lpc32xx: allow compile testing") -- Best wishes, Vladimir
diff --git a/arch/arm/mach-lpc32xx/serial.c b/arch/arm/mach-lpc32xx/serial.c index 3e765c4bf986..3b1203db81b2 100644 --- a/arch/arm/mach-lpc32xx/serial.c +++ b/arch/arm/mach-lpc32xx/serial.c @@ -15,6 +15,7 @@ #include <linux/serial_8250.h> #include <linux/clk.h> #include <linux/io.h> +#include <linux/soc/nxp/lpc32xx-misc.h> #include "lpc32xx.h" #include "common.h"