| Message ID | 20230718065735.10187-2-durai.manickamkr@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 92d39d018347ead1078dcba3cb1d8aeb9de79e04 |
| Headers | show |
| Series | update at91 usart compatible for sam9x60 | expand |
On Tue, Jul 18, 2023 at 12:27:34PM +0530, Durai Manickam KR wrote: > There is only one debug unit in the sam9x60 SOC and it has the chipid > register. So, the dbgu compatible strings are valid only for debug usart. > Defining these dbgu compatible strings are not valid for flexcom usart. > So adding the items which is valid only for flexcom usart and removing > the microchip,sam9x60-usart compatible string from the enum list as no > usart node defines only this specific compatible string. It may have been worth pointing out that had any DTS used the compatible that is being disallowed in isolation after this change, no driver in Linux would have bound to it anyway. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > > Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com> > --- > .../devicetree/bindings/serial/atmel,at91-usart.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > index 30b2131b5860..65cb2e5c5eee 100644 > --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > @@ -16,13 +16,15 @@ properties: > - enum: > - atmel,at91rm9200-usart > - atmel,at91sam9260-usart > - - microchip,sam9x60-usart > - items: > - const: atmel,at91rm9200-dbgu > - const: atmel,at91rm9200-usart > - items: > - const: atmel,at91sam9260-dbgu > - const: atmel,at91sam9260-usart > + - items: > + - const: microchip,sam9x60-usart > + - const: atmel,at91sam9260-usart > - items: > - const: microchip,sam9x60-dbgu > - const: microchip,sam9x60-usart > -- > 2.25.1 >
diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml index 30b2131b5860..65cb2e5c5eee 100644 --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml @@ -16,13 +16,15 @@ properties: - enum: - atmel,at91rm9200-usart - atmel,at91sam9260-usart - - microchip,sam9x60-usart - items: - const: atmel,at91rm9200-dbgu - const: atmel,at91rm9200-usart - items: - const: atmel,at91sam9260-dbgu - const: atmel,at91sam9260-usart + - items: + - const: microchip,sam9x60-usart + - const: atmel,at91sam9260-usart - items: - const: microchip,sam9x60-dbgu - const: microchip,sam9x60-usart
There is only one debug unit in the sam9x60 SOC and it has the chipid register. So, the dbgu compatible strings are valid only for debug usart. Defining these dbgu compatible strings are not valid for flexcom usart. So adding the items which is valid only for flexcom usart and removing the microchip,sam9x60-usart compatible string from the enum list as no usart node defines only this specific compatible string. Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com> --- .../devicetree/bindings/serial/atmel,at91-usart.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)