| Message ID | 20230720012826.430026-2-ychuang570808@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add support for nuvoton ma35d1 rtc controller | expand |
On 20/07/2023 03:28, Jacky Huang wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > Add documentation to describe nuvoton ma35d1 rtc driver. > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> > --- > .../bindings/rtc/nuvoton,ma35d1-rtc.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml > new file mode 100644 > index 000000000000..08c30f3018fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/nuvoton,ma35d1-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Read Time Clock > + > +maintainers: > + - Min-Jen Chen <mjchen@nuvoton.com> > + Missing ref to rtc.yaml. > +properties: > + compatible: > + enum: > + - nuvoton,ma35d1-rtc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false And then use unevaluatedProperties: false instead. Best regards, Krzysztof
On 2023/7/20 下午 02:10, Krzysztof Kozlowski wrote: > On 20/07/2023 03:28, Jacky Huang wrote: >> From: Jacky Huang <ychuang3@nuvoton.com> >> >> Add documentation to describe nuvoton ma35d1 rtc driver. >> >> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >> --- >> .../bindings/rtc/nuvoton,ma35d1-rtc.yaml | 45 +++++++++++++++++++ >> 1 file changed, 45 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml >> >> diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml >> new file mode 100644 >> index 000000000000..08c30f3018fb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/nuvoton,ma35d1-rtc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nuvoton MA35D1 Read Time Clock >> + >> +maintainers: >> + - Min-Jen Chen <mjchen@nuvoton.com> >> + > Missing ref to rtc.yaml. > > >> +properties: >> + compatible: >> + enum: >> + - nuvoton,ma35d1-rtc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + >> +additionalProperties: false > And then use unevaluatedProperties: false instead. > > > Best regards, > Krzysztof > Thank you for the advice. I will fix these two issues in the next version. Best Regards, Jacky Huang
On Thu, Jul 20, 2023 at 01:28:24AM +0000, Jacky Huang wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > Add documentation to describe nuvoton ma35d1 rtc driver. Bindings describe h/w, not drivers. For the subject: dt-bindings: rtc: Add Nuvoton ma35d1 rtc > > Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> > --- > .../bindings/rtc/nuvoton,ma35d1-rtc.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml > new file mode 100644 > index 000000000000..08c30f3018fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/nuvoton,ma35d1-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Read Time Clock s/Read/Real/ > + > +maintainers: > + - Min-Jen Chen <mjchen@nuvoton.com> > + > +properties: > + compatible: > + enum: > + - nuvoton,ma35d1-rtc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h> > + rtc@40410000 { > + compatible = "nuvoton,ma35d1-rtc"; > + reg = <0x40410000 0x200>; > + interrupts = <GIC_SPI 5 IRQ_TYPE_EDGE_RISING>; > + clocks = <&clk RTC_GATE>; > + }; > + > +... > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml new file mode 100644 index 000000000000..08c30f3018fb --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nuvoton,ma35d1-rtc.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/nuvoton,ma35d1-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton MA35D1 Read Time Clock + +maintainers: + - Min-Jen Chen <mjchen@nuvoton.com> + +properties: + compatible: + enum: + - nuvoton,ma35d1-rtc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h> + rtc@40410000 { + compatible = "nuvoton,ma35d1-rtc"; + reg = <0x40410000 0x200>; + interrupts = <GIC_SPI 5 IRQ_TYPE_EDGE_RISING>; + clocks = <&clk RTC_GATE>; + }; + +...