diff mbox series

ARM: locomo: fix locomolcd_power declaration

Message ID 20230927194844.680771-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 5e8a380b2dd3643392ba32711176fe710ad86e8b
Headers show
Series ARM: locomo: fix locomolcd_power declaration | expand

Commit Message

Arnd Bergmann Sept. 27, 2023, 7:38 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The locomolcd driver has one remaining missing-prototype warning:

drivers/video/backlight/locomolcd.c:83:6: error: no previous prototype for 'locomolcd_power' [-Werror=missing-prototypes]

There is in fact an unused prototype with a similar name in a global
header, so move the actual one there and remove the old one.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/include/asm/hardware/locomo.h     | 2 +-
 arch/arm/mach-sa1100/include/mach/collie.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

patchwork-bot+linux-soc@kernel.org Sept. 28, 2023, 8 a.m. UTC | #1 
Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <arnd@arndb.de>:

On Wed, 27 Sep 2023 21:38:10 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The locomolcd driver has one remaining missing-prototype warning:
> 
> drivers/video/backlight/locomolcd.c:83:6: error: no previous prototype for 'locomolcd_power' [-Werror=missing-prototypes]
> 
> There is in fact an unused prototype with a similar name in a global
> header, so move the actual one there and remove the old one.
> 
> [...]

Here is the summary with links:
  - ARM: locomo: fix locomolcd_power declaration
    https://git.kernel.org/soc/soc/c/5e8a380b2dd3

You are awesome, thank you!
diff mbox series

Patch

diff --git a/arch/arm/include/asm/hardware/locomo.h b/arch/arm/include/asm/hardware/locomo.h
index 246a3de25931d..aaaedafef7cce 100644
--- a/arch/arm/include/asm/hardware/locomo.h
+++ b/arch/arm/include/asm/hardware/locomo.h
@@ -195,7 +195,7 @@  struct locomo_driver {
 
 #define LOCOMO_DRIVER_NAME(_ldev) ((_ldev)->dev.driver->name)
 
-void locomo_lcd_power(struct locomo_dev *, int, unsigned int);
+extern void locomolcd_power(int on);
 
 int locomo_driver_register(struct locomo_driver *);
 void locomo_driver_unregister(struct locomo_driver *);
diff --git a/arch/arm/mach-sa1100/include/mach/collie.h b/arch/arm/mach-sa1100/include/mach/collie.h
index b7bc23ffd3c69..c95273c9567bb 100644
--- a/arch/arm/mach-sa1100/include/mach/collie.h
+++ b/arch/arm/mach-sa1100/include/mach/collie.h
@@ -16,8 +16,6 @@ 
 
 #include "hardware.h" /* Gives GPIO_MAX */
 
-extern void locomolcd_power(int on);
-
 #define COLLIE_SCOOP_GPIO_BASE	(GPIO_MAX + 1)
 #define COLLIE_GPIO_CHARGE_ON	(COLLIE_SCOOP_GPIO_BASE + 0)
 #define COLLIE_SCP_DIAG_BOOT1	SCOOP_GPCR_PA12