[PULL,v2] bus: Convert to platform remove callback returning void

Pull-request

https://git.pengutronix.de/git/ukl/linux tags/bus-platform-remove-void

Message

Uwe Kleine-König Nov. 28, 2023, 5:49 p.m. UTC

Hello Arnd,

On Thu, Nov 16, 2023 at 12:53:07PM +0100, Uwe Kleine-König wrote:
> On Fri, Nov 10, 2023 at 07:32:01AM +0100, Arnd Bergmann wrote:
> > On Thu, Nov 9, 2023, at 21:28, Uwe Kleine-König wrote:
> > > this series converts all drivers below drivers/bus to struct
> > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> > > Provide a remove callback that returns no value") for an extended
> > > explanation and the eventual goal.
> > >
> > > drivers/bus/fsl-mc was already addressed earlier with a separate
> > > series[1].
> > >
> > > All conversations are trivial, because all .remove() callbacks returned
> > > zero unconditionally.
> > >
> > > Some of the drivers touched here don't have a maintainer and there is no
> > > maintainer for all of drivers/bus. It would be great if someone could pick up
> > > the whole series, maybe Arnd might do that?
> > 
> > Sure, please send a pull request to [e-mail] if there
> > are no further comments.
> 
> here it comes:
> 
> The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:
> 
>   Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)

Here comes an updated PR. The only change is that it also includes two
Reviewed-by tags for Jernej Skrabec that came in after I sent the PR.
Obviously that changed the commit hash which made it necessary to redo
the PR. I hope it doesn't disturb your tooling that there are now two
similar pull requests.

Best regards
Uwe

The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:

  Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)

are available in the Git repository at:

  https://git.pengutronix.de/git/ukl/linux tags/bus-platform-remove-void

for you to fetch changes up to fc540426f7baa0c7d4b477e80435d075659092a2:

  bus: ts-nbus: Convert to platform remove callback returning void (2023-11-28 18:43:27 +0100)

----------------------------------------------------------------
This series converts all drivers below drivers/bus to struct
platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
Provide a remove callback that returns no value") for an extended
explanation and the eventual goal.

After the initial simplification in commit 864acca58000 ("bus: fsl-mc:
Drop if block with always false condition") all conversations are
trivial because the remove callbacks all return zero unconditionally.

----------------------------------------------------------------
Uwe Kleine-König (14):
      bus: fsl-mc: Drop if block with always false condition
      bus: fsl-mc: Convert to platform remove callback returning void
      bus: hisi_lpc: Convert to platform remove callback returning void
      bus: omap-ocp2scp: Convert to platform remove callback returning void
      bus: omap_l3_smx: Convert to platform remove callback returning void
      bus: qcom-ssc-block-bus: Convert to platform remove callback returning void
      bus: simple-pm-bus: Convert to platform remove callback returning void
      bus: sun50i-de2: Convert to platform remove callback returning void
      bus: sunxi-rsb: Convert to platform remove callback returning void
      bus: tegra-aconnect: Convert to platform remove callback returning void
      bus: tegra-gmi: Convert to platform remove callback returning void
      bus: ti-pwmss: Convert to platform remove callback returning void
      bus: ti-sysc: Convert to platform remove callback returning void
      bus: ts-nbus: Convert to platform remove callback returning void

 drivers/bus/fsl-mc/fsl-mc-bus.c  | 16 +++-------------
 drivers/bus/hisi_lpc.c           |  6 ++----
 drivers/bus/omap-ocp2scp.c       |  6 ++----
 drivers/bus/omap_l3_smx.c        |  6 ++----
 drivers/bus/qcom-ssc-block-bus.c |  6 ++----
 drivers/bus/simple-pm-bus.c      |  7 +++----
 drivers/bus/sun50i-de2.c         |  5 ++---
 drivers/bus/sunxi-rsb.c          |  6 ++----
 drivers/bus/tegra-aconnect.c     |  6 ++----
 drivers/bus/tegra-gmi.c          |  6 ++----
 drivers/bus/ti-pwmss.c           |  5 ++---
 drivers/bus/ti-sysc.c            |  6 ++----
 drivers/bus/ts-nbus.c            |  6 ++----
 13 files changed, 28 insertions(+), 59 deletions(-)

Comments

[e-mail] Dec. 6, 2023, 5:17 p.m. UTC | #1

Hello:

This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <[e-mail]>:

On Tue, 28 Nov 2023 18:49:27 +0100 you wrote:
> Hello Arnd,
> 
> On Thu, Nov 16, 2023 at 12:53:07PM +0100, Uwe Kleine-König wrote:
> > On Fri, Nov 10, 2023 at 07:32:01AM +0100, Arnd Bergmann wrote:
> > > On Thu, Nov 9, 2023, at 21:28, Uwe Kleine-König wrote:
> > > > this series converts all drivers below drivers/bus to struct
> > > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform:
> > > > Provide a remove callback that returns no value") for an extended
> > > > explanation and the eventual goal.
> > > >
> > > > drivers/bus/fsl-mc was already addressed earlier with a separate
> > > > series[1].
> > > >
> > > > All conversations are trivial, because all .remove() callbacks returned
> > > > zero unconditionally.
> > > >
> > > > Some of the drivers touched here don't have a maintainer and there is no
> > > > maintainer for all of drivers/bus. It would be great if someone could pick up
> > > > the whole series, maybe Arnd might do that?
> > >
> > > Sure, please send a pull request to [e-mail] if there
> > > are no further comments.
> >
> > here it comes:
> >
> > The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86:
> >
> >   Linux 6.7-rc1 (2023-11-12 16:19:07 -0800)
> 
> [...]

Here is the summary with links:
  - [PULL,v2] bus: Convert to platform remove callback returning void
    https://git.kernel.org/soc/soc/c/a351940d61e6

You are awesome, thank you!