diff mbox series

ARM: davinci: always select CONFIG_CPU_ARM926T

Message ID 20240108110055.1531153-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 40974ee421b4d1fc74ac733d86899ce1b83d8f65
Headers show
Series ARM: davinci: always select CONFIG_CPU_ARM926T | expand

Commit Message

Arnd Bergmann Jan. 8, 2024, 11 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The select was lost by accident during the multiplatform conversion.
Any davinci-only

arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
(.text+0x168): undefined reference to `arm926_flush_kern_cache_all'

Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I ran into this today for the first time after five years of randconfig testing
with the bug in place, so it is clearly very hard to hit.

It's an obvious fix, so I'm applying it to the soc/arm branch directly
for this week's pull requests.


 arch/arm/mach-davinci/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bartosz Golaszewski Jan. 8, 2024, 11:13 a.m. UTC | #1 
On Mon, Jan 8, 2024 at 12:01 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The select was lost by accident during the multiplatform conversion.
> Any davinci-only
>
> arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
> (.text+0x168): undefined reference to `arm926_flush_kern_cache_all'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I ran into this today for the first time after five years of randconfig testing
> with the bug in place, so it is clearly very hard to hit.
>
> It's an obvious fix, so I'm applying it to the soc/arm branch directly
> for this week's pull requests.
>
>
>  arch/arm/mach-davinci/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index 1c8bf56982e5..2a8a9fe46586 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -4,6 +4,7 @@ menuconfig ARCH_DAVINCI
>         bool "TI DaVinci"
>         depends on ARCH_MULTI_V5
>         depends on CPU_LITTLE_ENDIAN
> +       select CPU_ARM926T
>         select DAVINCI_TIMER
>         select ZONE_DMA
>         select PM_GENERIC_DOMAINS if PM
> --
> 2.39.2
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
patchwork-bot+linux-soc@kernel.org Jan. 9, 2024, 7:40 a.m. UTC | #2 
Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Mon,  8 Jan 2024 12:00:36 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The select was lost by accident during the multiplatform conversion.
> Any davinci-only
> 
> arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
> (.text+0x168): undefined reference to `arm926_flush_kern_cache_all'
> 
> [...]

Here is the summary with links:
  - ARM: davinci: always select CONFIG_CPU_ARM926T
    https://git.kernel.org/soc/soc/c/40974ee421b4

You are awesome, thank you!
diff mbox series

Patch

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 1c8bf56982e5..2a8a9fe46586 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -4,6 +4,7 @@  menuconfig ARCH_DAVINCI
 	bool "TI DaVinci"
 	depends on ARCH_MULTI_V5
 	depends on CPU_LITTLE_ENDIAN
+	select CPU_ARM926T
 	select DAVINCI_TIMER
 	select ZONE_DMA
 	select PM_GENERIC_DOMAINS if PM