| Message ID | 20240329130152.878944-3-renze@rnplus.nl (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: dts: Update devicetree of Asrock X570D4U BMC | expand |
Hi Renze, On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote: > This commit disables unused ADC channels and labels the ADC channels used with their function. Please run this through checkpatch and address the warnings. Also, the submitting patches documentation[1] suggests using the imperative mood - instead of "This commit disables ...", use "Disable ...". The change subject is phrased the expected way. [1]: https://docs.kernel.org/process/submitting-patches.html Taking the subject and the description together, the description feels a little redundant. Maybe it could be trimmed back to > Also, label the ADC channels used with their function. Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts index 34bc382bf492..e93c2f0b8414 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts @@ -358,20 +358,17 @@ fan@5 { &adc { status = "okay"; pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_adc0_default - &pinctrl_adc1_default - &pinctrl_adc2_default - &pinctrl_adc3_default - &pinctrl_adc4_default - &pinctrl_adc5_default - &pinctrl_adc6_default - &pinctrl_adc7_default - &pinctrl_adc8_default - &pinctrl_adc9_default - &pinctrl_adc10_default - &pinctrl_adc11_default - &pinctrl_adc12_default - &pinctrl_adc13_default - &pinctrl_adc14_default - &pinctrl_adc15_default>; + pinctrl-0 = <&pinctrl_adc0_default /* 3VSB */ + &pinctrl_adc1_default /* 5VSB */ + &pinctrl_adc2_default /* VCPU */ + &pinctrl_adc3_default /* VSOC */ + &pinctrl_adc4_default /* VCCM */ + &pinctrl_adc5_default /* APU-VDDP */ + &pinctrl_adc6_default /* PM-VDD-CLDO */ + &pinctrl_adc7_default /* PM-VDDCR-S5 */ + &pinctrl_adc8_default /* PM-VDDCR */ + &pinctrl_adc9_default /* VBAT */ + &pinctrl_adc10_default /* 3V */ + &pinctrl_adc11_default /* 5V */ + &pinctrl_adc12_default>; /* 12V */ };
This commit disables unused ADC channels and labels the ADC channels used with their function. Signed-off-by: Renze Nicolai <renze@rnplus.nl> --- .../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts | 29 +++++++++---------- 1 file changed, 13 insertions(+), 16 deletions(-)