From patchwork Thu Jun 13 16:10:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13697098 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12771C27C75 for ; Thu, 13 Jun 2024 16:11:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 0534AC4AF1C; Thu, 13 Jun 2024 16:11:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D17B8C2BBFC; Thu, 13 Jun 2024 16:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718295073; bh=UgUZg6hUDfFLzxpWFcFCweGPS+bRnUGd3mlfull7wAM=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=SybQh8uUEA9IcPljA5R7nV6vAOnXePeO6TIBGv2QULu+pv5hHoELHeZSwwbkNPyRv hDsZSCZ4WQhl7rn75+cj4/SpXHju0kPq2M3z3/iioFek7kjl56YZmMPD5KgAW4mG5Z VYJvcstRl6oxA9Ldwp+qYUJQywGuqP5Gl8ZX2FXM2dhgvOvIu9IviR5R3Gkj0YDuOL ijNoNtGGrckxDwGdKKuGbQgeJI95v6OZeuK2P7ozrpNNYaMSyt02k4HBRw+RroIkR6 giBMhtmqpOLqiJoBjfQSwWVUAqKAYOOEhYsW2JVPFAlEKE2sM4oMMgNwP29EHZxcuo ArkIqe2X/aCdw== From: =?utf-8?q?Marek_Beh=C3=BAn?= List-Id: To: Gregory CLEMENT , Andrew Lunn , Arnd Bergmann , soc@kernel.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: =?utf-8?q?Marek_Beh=C3=BAn?= Subject: [PATCH v2 09/17] firmware: turris-mox-rwtm: Simplify debugfs code Date: Thu, 13 Jun 2024 18:10:37 +0200 Message-ID: <20240613161045.29606-10-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240613161045.29606-1-kabel@kernel.org> References: <20240613161045.29606-1-kabel@kernel.org> MIME-Version: 1.0 Simplify debugfs code: do not check for errors, as debugfs errors should be ignored, and use devm action for dropping the debugfs directory. Signed-off-by: Marek Behún --- drivers/firmware/turris-mox-rwtm.c | 44 ++++++++---------------------- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c index d17dc0679439..a536c9c461a7 100644 --- a/drivers/firmware/turris-mox-rwtm.c +++ b/drivers/firmware/turris-mox-rwtm.c @@ -90,7 +90,6 @@ struct mox_rwtm { * It should be rewritten via crypto API once akcipher API is available * from userspace. */ - struct dentry *debugfs_root; u32 last_sig[MOX_ECC_SIGNATURE_WORDS]; bool last_sig_done; #endif @@ -405,39 +404,23 @@ static const struct file_operations do_sign_fops = { .llseek = no_llseek, }; -static int rwtm_register_debugfs(struct mox_rwtm *rwtm) +static void rwtm_debugfs_release(void *root) { - struct dentry *root, *entry; - - root = debugfs_create_dir("turris-mox-rwtm", NULL); - - if (IS_ERR(root)) - return PTR_ERR(root); - - entry = debugfs_create_file_unsafe("do_sign", 0600, root, rwtm, - &do_sign_fops); - if (IS_ERR(entry)) - goto err_remove; - - rwtm->debugfs_root = root; - - return 0; -err_remove: debugfs_remove_recursive(root); - return PTR_ERR(entry); } -static void rwtm_unregister_debugfs(struct mox_rwtm *rwtm) +static void rwtm_register_debugfs(struct mox_rwtm *rwtm) { - debugfs_remove_recursive(rwtm->debugfs_root); + struct dentry *root; + + root = debugfs_create_dir("turris-mox-rwtm", NULL); + + devm_add_action_or_reset(rwtm->dev, rwtm_debugfs_release, root); + + debugfs_create_file_unsafe("do_sign", 0600, root, rwtm, &do_sign_fops); } #else -static inline int rwtm_register_debugfs(struct mox_rwtm *rwtm) -{ - return 0; -} - -static inline void rwtm_unregister_debugfs(struct mox_rwtm *rwtm) +static inline void rwtm_register_debugfs(struct mox_rwtm *rwtm) { } #endif @@ -502,11 +485,7 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev) goto free_channel; } - ret = rwtm_register_debugfs(rwtm); - if (ret < 0) { - dev_err(dev, "Failed creating debugfs entries: %i\n", ret); - goto free_channel; - } + rwtm_register_debugfs(rwtm); dev_info(dev, "HWRNG successfully registered\n"); @@ -529,7 +508,6 @@ static void turris_mox_rwtm_remove(struct platform_device *pdev) { struct mox_rwtm *rwtm = platform_get_drvdata(pdev); - rwtm_unregister_debugfs(rwtm); mbox_free_channel(rwtm->mbox); }