| Message ID | 20241212155237.848336-4-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On 12/12/2024 16:52, Kevin Chen wrote: > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index 2f92b8ab08fa..20191fee1f5b 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -101,4 +101,10 @@ properties: > - ufispace,ncplite-bmc > - const: aspeed,ast2600 > > + - description: AST2700 based boards > + items: > + - enum: > + - aspeed,ast2700-evb > + - const: aspeed,ast2700 > + > additionalProperties: true This patchset is just corrupted. You already sent it as patch #1. Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
On 13/12/2024 08:59, Krzysztof Kozlowski wrote: > On 12/12/2024 16:52, Kevin Chen wrote: >> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> >> --- >> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> index 2f92b8ab08fa..20191fee1f5b 100644 >> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >> @@ -101,4 +101,10 @@ properties: >> - ufispace,ncplite-bmc >> - const: aspeed,ast2600 >> >> + - description: AST2700 based boards >> + items: >> + - enum: >> + - aspeed,ast2700-evb >> + - const: aspeed,ast2700 >> + >> additionalProperties: true > > > > This patchset is just corrupted. You already sent it as patch #1. > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. BTW, you already got here same comments before and this is third time you send exactly the same without implementing what we asked you. Three times same issue. NAK Best regards, Krzysztof
Hi Krzk, > > On 12/12/2024 16:52, Kevin Chen wrote: > >> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > >> --- > >> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > >> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > >> index 2f92b8ab08fa..20191fee1f5b 100644 > >> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > >> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > >> @@ -101,4 +101,10 @@ properties: > >> - ufispace,ncplite-bmc > >> - const: aspeed,ast2600 > >> > >> + - description: AST2700 based boards > >> + items: > >> + - enum: > >> + - aspeed,ast2700-evb > >> + - const: aspeed,ast2700 > >> + > >> additionalProperties: true > > > > > > > > This patchset is just corrupted. You already sent it as patch #1. > > > > Please run scripts/checkpatch.pl and fix reported warnings. Then > > please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. > > Some warnings can be ignored, especially from --strict run, but the > > code here looks like it needs a fix. Feel free to get in touch if the > > warning is not clear. > BTW, you already got here same comments before and this is third time you > send exactly the same without implementing what we asked you. Please check the following message. https://lore.kernel.org/lkml/PSAPR06MB494943F3F34881D23CEEBD9A897D2@PSAPR06MB4949.apcprd06.prod.outlook.com/ Or, how do you think what is better for me to add ast2700-evb? > > Three times same issue. > > NAK > > Best regards, > Krzysztof Best Regards, Kevin. Chen
On 18/12/2024 03:55, Kevin Chen wrote: > Hi Krzk, > >>> On 12/12/2024 16:52, Kevin Chen wrote: >>>> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> >>>> --- >>>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>>> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>>> index 2f92b8ab08fa..20191fee1f5b 100644 >>>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>>> @@ -101,4 +101,10 @@ properties: >>>> - ufispace,ncplite-bmc >>>> - const: aspeed,ast2600 >>>> >>>> + - description: AST2700 based boards >>>> + items: >>>> + - enum: >>>> + - aspeed,ast2700-evb >>>> + - const: aspeed,ast2700 >>>> + >>>> additionalProperties: true >>> >>> >>> >>> This patchset is just corrupted. You already sent it as patch #1. >>> >>> Please run scripts/checkpatch.pl and fix reported warnings. Then >>> please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. >>> Some warnings can be ignored, especially from --strict run, but the >>> code here looks like it needs a fix. Feel free to get in touch if the >>> warning is not clear. >> BTW, you already got here same comments before and this is third time you >> send exactly the same without implementing what we asked you. > Please check the following message. > https://lore.kernel.org/lkml/PSAPR06MB494943F3F34881D23CEEBD9A897D2@PSAPR06MB4949.apcprd06.prod.outlook.com/ > > Or, how do you think what is better for me to add ast2700-evb? Please stop responding just to make me go away. Read the comments from half a year ago, which you have never implemented: https://lore.kernel.org/lkml/e6cb6f26-fef2-49bc-ab25-fdc9a659f593@kernel.org/ On every new patch I was asking you to go back, but again you were ignoring each of such messages. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 2f92b8ab08fa..20191fee1f5b 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -101,4 +101,10 @@ properties: - ufispace,ncplite-bmc - const: aspeed,ast2600 + - description: AST2700 based boards + items: + - enum: + - aspeed,ast2700-evb + - const: aspeed,ast2700 + additionalProperties: true
Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 6 ++++++ 1 file changed, 6 insertions(+)