| Message ID | bd3872ce5125477ea80b1131ad9a34c98aa1a796.1665375018.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 390ca5bca7cdb95042dcb445375db0d9eba7aa4a |
| Headers | show |
| Series | ARM: spear6xx: Staticize few definitions | expand |
Hello: This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <arnd@arndb.de>: On Mon, 10 Oct 2022 09:41:07 +0530 you wrote: > Fix warnings with clang like: > > arch/arm/mach-spear/spear6xx.c:365:13: warning: no previous prototype for function 'spear6xx_map_io' [-Wmissing-prototypes] > > by making few definitions static. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > [...] Here is the summary with links: - ARM: spear6xx: Staticize few definitions https://git.kernel.org/soc/soc/c/390ca5bca7cd You are awesome, thank you!
On Sun, Oct 9, 2022 at 9:11 PM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > Fix warnings with clang like: > > arch/arm/mach-spear/spear6xx.c:365:13: warning: no previous prototype for function 'spear6xx_map_io' [-Wmissing-prototypes] > > by making few definitions static. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > Rebased on v6.0. > > arch/arm/mach-spear/spear6xx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-spear/spear6xx.c b/arch/arm/mach-spear/spear6xx.c > index 58183493e06d..7a5fff134872 100644 > --- a/arch/arm/mach-spear/spear6xx.c > +++ b/arch/arm/mach-spear/spear6xx.c > @@ -339,7 +339,7 @@ static struct pl08x_platform_data spear6xx_pl080_plat_data = { > * 0xD0000000 0xFD000000 > * 0xFC000000 0xFC000000 > */ > -struct map_desc spear6xx_io_desc[] __initdata = { > +static struct map_desc spear6xx_io_desc[] __initdata = { > { > .virtual = (unsigned long)VA_SPEAR6XX_ML_CPU_BASE, > .pfn = __phys_to_pfn(SPEAR_ICM3_ML1_2_BASE), > @@ -359,12 +359,12 @@ struct map_desc spear6xx_io_desc[] __initdata = { > }; > > /* This will create static memory mapping for selected devices */ > -void __init spear6xx_map_io(void) > +static void __init spear6xx_map_io(void) > { > iotable_init(spear6xx_io_desc, ARRAY_SIZE(spear6xx_io_desc)); > } > > -void __init spear6xx_timer_init(void) > +static void __init spear6xx_timer_init(void) > { > char pclk_name[] = "pll3_clk"; > struct clk *gpt_clk, *pclk; > @@ -394,7 +394,7 @@ void __init spear6xx_timer_init(void) > } > > /* Add auxdata to pass platform data */ > -struct of_dev_auxdata spear6xx_auxdata_lookup[] __initdata = { > +static struct of_dev_auxdata spear6xx_auxdata_lookup[] __initdata = { > OF_DEV_AUXDATA("arm,pl080", SPEAR_ICM3_DMA_BASE, NULL, > &spear6xx_pl080_plat_data), > {} > -- > 2.31.1.272.g89b43f80a514 >
diff --git a/arch/arm/mach-spear/spear6xx.c b/arch/arm/mach-spear/spear6xx.c index 58183493e06d..7a5fff134872 100644 --- a/arch/arm/mach-spear/spear6xx.c +++ b/arch/arm/mach-spear/spear6xx.c @@ -339,7 +339,7 @@ static struct pl08x_platform_data spear6xx_pl080_plat_data = { * 0xD0000000 0xFD000000 * 0xFC000000 0xFC000000 */ -struct map_desc spear6xx_io_desc[] __initdata = { +static struct map_desc spear6xx_io_desc[] __initdata = { { .virtual = (unsigned long)VA_SPEAR6XX_ML_CPU_BASE, .pfn = __phys_to_pfn(SPEAR_ICM3_ML1_2_BASE), @@ -359,12 +359,12 @@ struct map_desc spear6xx_io_desc[] __initdata = { }; /* This will create static memory mapping for selected devices */ -void __init spear6xx_map_io(void) +static void __init spear6xx_map_io(void) { iotable_init(spear6xx_io_desc, ARRAY_SIZE(spear6xx_io_desc)); } -void __init spear6xx_timer_init(void) +static void __init spear6xx_timer_init(void) { char pclk_name[] = "pll3_clk"; struct clk *gpt_clk, *pclk; @@ -394,7 +394,7 @@ void __init spear6xx_timer_init(void) } /* Add auxdata to pass platform data */ -struct of_dev_auxdata spear6xx_auxdata_lookup[] __initdata = { +static struct of_dev_auxdata spear6xx_auxdata_lookup[] __initdata = { OF_DEV_AUXDATA("arm,pl080", SPEAR_ICM3_DMA_BASE, NULL, &spear6xx_pl080_plat_data), {}
Fix warnings with clang like: arch/arm/mach-spear/spear6xx.c:365:13: warning: no previous prototype for function 'spear6xx_map_io' [-Wmissing-prototypes] by making few definitions static. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- Rebased on v6.0. arch/arm/mach-spear/spear6xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)