| Message ID | c557b149780faa2299700585afc9d270ede7f78b.1664285062.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 502647105a1d0302d5fc32814da45bb4772becda |
| Headers | show |
| Series | ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM | expand |
On Tue, 27 Sept 2022 at 15:26, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > On older platforms that boot an image with an appended DTB, or where > the boot loader has no support for updating chosen/bootargs, it is > common to rely on CMDLINE_FORCE. > > While a fixed command line can make the kernel unbootable on other > platforms, it is not guaranteed to cause that. E.g. all Renesas boards > use the same chosen/bootargs in upstream DTS, which works fine if your > DHCP server hands out proper nfsroot parameters. > > Fixes: 84fc863606239d8b ("ARM: make ARCH_MULTIPLATFORM user-visible") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Ard Biesheuvel <ardb@kernel.org> > --- > arch/arm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 22f62ad919bfd831..ea8adbf25651438a 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1616,7 +1616,6 @@ config CMDLINE_EXTEND > > config CMDLINE_FORCE > bool "Always use the default kernel command string" > - depends on !ARCH_MULTIPLATFORM > help > Always use the default kernel command string, even if the boot > loader passes other arguments to the kernel. > -- > 2.25.1 >
Hello: This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Tue, 27 Sep 2022 15:26:26 +0200 you wrote: > On older platforms that boot an image with an appended DTB, or where > the boot loader has no support for updating chosen/bootargs, it is > common to rely on CMDLINE_FORCE. > > While a fixed command line can make the kernel unbootable on other > platforms, it is not guaranteed to cause that. E.g. all Renesas boards > use the same chosen/bootargs in upstream DTS, which works fine if your > DHCP server hands out proper nfsroot parameters. > > [...] Here is the summary with links: - ARM: Drop CMDLINE_FORCE dependency on !ARCH_MULTIPLATFORM https://git.kernel.org/soc/soc/c/502647105a1d You are awesome, thank you!
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 22f62ad919bfd831..ea8adbf25651438a 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1616,7 +1616,6 @@ config CMDLINE_EXTEND config CMDLINE_FORCE bool "Always use the default kernel command string" - depends on !ARCH_MULTIPLATFORM help Always use the default kernel command string, even if the boot loader passes other arguments to the kernel.
On older platforms that boot an image with an appended DTB, or where the boot loader has no support for updating chosen/bootargs, it is common to rely on CMDLINE_FORCE. While a fixed command line can make the kernel unbootable on other platforms, it is not guaranteed to cause that. E.g. all Renesas boards use the same chosen/bootargs in upstream DTS, which works fine if your DHCP server hands out proper nfsroot parameters. Fixes: 84fc863606239d8b ("ARM: make ARCH_MULTIPLATFORM user-visible") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/Kconfig | 1 - 1 file changed, 1 deletion(-)