| Message ID | 1374161799-2929-1-git-send-email-jlayton@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, Jul 18, 2013 at 8:36 AM, Jeff Layton <jlayton@redhat.com> wrote: > this patch stops sparse from complaining about them not being defined: > > /usr/include/bits/stdio2.h:98:25: error: undefined identifier '__builtin_va_arg_pack' > /usr/include/bits/stdio2.h:98:25: error: not a function <noident> > > Probably, there is some better way to do this that actually validates > this function, but I'm not clear on how to do it. > Please add a test case for the typical usage case of __buildin_va_arg_pack() and __builtin_va_arg_pack_len(). At the very least, it needs to cover the real world breakage that bother you enough to submit a patch. The patch looks good otherwise. Thanks Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib.c b/lib.c index 7e822eb..3f687ae 100644 --- a/lib.c +++ b/lib.c @@ -777,6 +777,7 @@ void declare_builtin_functions(void) add_pre_buffer("extern long __builtin_alpha_cmpbge(long, long);\n"); add_pre_buffer("extern long __builtin_labs(long);\n"); add_pre_buffer("extern double __builtin_fabs(double);\n"); + add_pre_buffer("extern __SIZE_TYPE__ __builtin_va_arg_pack_len(void);\n"); add_pre_buffer("extern void __sync_synchronize();\n"); add_pre_buffer("extern int __sync_bool_compare_and_swap(void *, ...);\n"); @@ -876,6 +877,7 @@ void create_builtin_stream(void) add_pre_buffer("#define __builtin_va_copy(dest, src) ({ dest = src; (void)0; })\n"); add_pre_buffer("#define __builtin_va_end(arg)\n"); add_pre_buffer("#define __builtin_ms_va_end(arg)\n"); + add_pre_buffer("#define __builtin_va_arg_pack()\n"); /* FIXME! We need to do these as special magic macros at expansion time! */ add_pre_buffer("#define __BASE_FILE__ \"base_file.c\"\n");
this patch stops sparse from complaining about them not being defined: /usr/include/bits/stdio2.h:98:25: error: undefined identifier '__builtin_va_arg_pack' /usr/include/bits/stdio2.h:98:25: error: not a function <noident> Probably, there is some better way to do this that actually validates this function, but I'm not clear on how to do it. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- lib.c | 2 ++ 1 file changed, 2 insertions(+)