diff mbox series

fix infinite loop when expanding __builtin_object_size() with self-init vars

Message ID 20220521094959.48865-1-lucvoo@kernel.org (mailing list archive)
State Mainlined, archived
Headers show
Series fix infinite loop when expanding __builtin_object_size() with self-init vars | expand

Commit Message

Luc Van Oostenryck May 21, 2022, 9:49 a.m. UTC 
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

expand_object_size(), used to expand __builtin_object_size(),
recursively try to get the parent initializer. This fails miserably
by looping endlessly when the object is a self-initialized variable.

For the moment, fix this in the most obvious way: stop the recursion
and do not expand such variables.

Note: I wouldn't be surprised if these self-initialized variables create
      other problems elsewhere. Maybe we should remove their initializer
      and somehow mark them as "do not warn about -Wuninitialized"
      (well, there is no such warnings *yet*).

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 builtin.c                              |  8 ++++++++
 validation/builtin-objsize-self-init.c | 11 +++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 validation/builtin-objsize-self-init.c
diff mbox series

Patch

diff --git a/builtin.c b/builtin.c
index 8e1d2d7e9386..3a29c3aec8a6 100644
--- a/builtin.c
+++ b/builtin.c
@@ -546,11 +546,19 @@  static int expand_object_size(struct expression *expr, int cost)
 			// a deref is just intermediate variable
 			// and so the offset needs to be zeroed.
 			if (arg->op == '*') {
+				struct expression *parent = arg;
 				arg = arg->unop;
 				off = 0;
 				switch (arg->type) {
 				case EXPR_SYMBOL:
 					arg = arg->symbol->initializer;
+					if (arg == parent) {
+						// stop at self-initialized vars
+						// and do not expand them.
+						arg = NULL;
+						val = -1;
+						break;
+					}
 					continue;
 				default:
 					break;
diff --git a/validation/builtin-objsize-self-init.c b/validation/builtin-objsize-self-init.c
new file mode 100644
index 000000000000..77e3da43e6d2
--- /dev/null
+++ b/validation/builtin-objsize-self-init.c
@@ -0,0 +1,11 @@ 
+static void f(void)
+{
+	void *param = param;
+	__builtin_object_size(param, 0);
+}
+
+/*
+ * check-name: builtin-objsize-self-init
+ * check-timeout:
+ * check-error-end
+ */