| Message ID | 4A6233D0.1060502@ramsay1.demon.co.uk (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Sat, Jul 18, 2009 at 09:42:56PM +0100, Ramsay Jones wrote: > In particular, on systems which do not have 'pkg-config' installed, > every invocation of make issues the following message: > > /bin/sh: pkg-config: command not found > > Suppress the message by redirecting stderr to the bit-bucket. [...] > --- a/Makefile > +++ b/Makefile > @@ -15,7 +15,7 @@ AR = ar > # CFLAGS += -O0 -DDEBUG -g3 -gdwarf-2 > # > > -HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 && echo 'yes') > +HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 2>/dev/null && echo 'yes') Seems sensible; this way, systems without pkg-config will simply end up without HAVE_LIBXML. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On Sat, Jul 18, 2009 at 09:42:56PM +0100, Ramsay Jones wrote: >> In particular, on systems which do not have 'pkg-config' installed, >> every invocation of make issues the following message: >> >> Â Â /bin/sh: pkg-config: command not found >> >> Suppress the message by redirecting stderr to the bit-bucket. Applied. Thanks Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Christopher Li wrote: >> On Sat, Jul 18, 2009 at 09:42:56PM +0100, Ramsay Jones wrote: >>> In particular, on systems which do not have 'pkg-config' installed, >>> every invocation of make issues the following message: >>> >>> /bin/sh: pkg-config: command not found >>> >>> Suppress the message by redirecting stderr to the bit-bucket. > > Applied. > > Thanks Thanks. Hmm, I noticed that you edited the "subject line" when you applied the patch; namely s/shell/pkg-config/. I find this a little puzzling, since the error message *is* issued by the shell and is definitely *not* issued by pkg-config... which is kinda the point... ;-) ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 21, 2009 at 2:50 PM, Ramsay Jones<ramsay@ramsay1.demon.co.uk> wrote: > Hmm, I noticed that you edited the "subject line" when you applied > the patch; namely s/shell/pkg-config/. > > I find this a little puzzling, since the error message *is* issued > by the shell and is definitely *not* issued by pkg-config... which > is kinda the point... ;-) > Oh, right. The error is issue from shell when it try to run pkg-config. If I just read the title, it is hard for me to predict where the change is going to be. I just want to be more specific. There is a reason I haven't push those to official tree yet. We can still change it if we want. Suggestion? Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Christopher Li wrote: > On Tue, Jul 21, 2009 at 2:50 PM, Ramsay Jones<ramsay@ramsay1.demon.co.uk> wrote: >> Hmm, I noticed that you edited the "subject line" when you applied >> the patch; namely s/shell/pkg-config/. >> >> I find this a little puzzling, since the error message *is* issued >> by the shell and is definitely *not* issued by pkg-config... which >> is kinda the point... ;-) >> > Oh, right. The error is issue from shell when it try to run pkg-config. > If I just read the title, it is hard for me to predict where the change > is going to be. I just want to be more specific. > > There is a reason I haven't push those to official tree yet. We can > still change it if we want. Suggestion? I liked the original myself. :) The "Makefile:" prefix was intended to indicate where the change was made and I thought that the one-line summary was compact and accurate. It's a bit difficult to indicate that "the cause of the error, which is issued by the shell, is a missing pkg-config command on some systems" as part of the one-line summary. (So I didn't try ;P ) Having said that, I can't claim to be good at writing commit messages. So, feel free to re-write it as you wish. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Makefile b/Makefile index 72f3686..70ccbc9 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ AR = ar # CFLAGS += -O0 -DDEBUG -g3 -gdwarf-2 # -HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 && echo 'yes') +HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 2>/dev/null && echo 'yes') HAVE_GCC_DEP=$(shell touch .gcc-test.c && \ $(CC) -c -Wp,-MD,.gcc-test.d .gcc-test.c 2>/dev/null && \ echo 'yes'; rm -f .gcc-test.d .gcc-test.o .gcc-test.c)
In particular, on systems which do not have 'pkg-config' installed, every invocation of make issues the following message: /bin/sh: pkg-config: command not found Suppress the message by redirecting stderr to the bit-bucket. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)